Changeset c2866ec for perl/modules

Timestamp:

May 13, 2013, 8:11:59 PM (11 years ago)

Author:

Jason Gross <jgross@mit.edu>

Branches:

master, release-1.10

Children:

2e9b9ad, 53151d4, 67009f92

Parents:

0625919

git-author:

Jason Gross <jgross@mit.edu> (05/09/13 17:26:37)

git-committer:

Jason Gross <jgross@mit.edu> (05/13/13 20:11:59)

Message:

Split irc messages into chunks

From Zephyr:
   barnowl / irc-cutoff / kchen  2013-05-09 16:38  (Everyone Left Wheel Thru)
       This might be an IRC limitation.  RFC 1459 says:

       "IRC messages are always lines of characters terminated with a CR-LF
       (Carriage Return - Line Feed) pair, and these messages shall not
       exceed 512 characters in length, counting all characters including
       the trailing CR-LF. Thus, there are 510 characters maximum allowed
       for the command and its parameters.  There is no provision for
       continuation message lines.  See section 7 for more details about
       current implementations."

       (I didn't read the rest of the RFC to know how many other bytes are
       involved in sending a message.)

I chose 450 to be the default cut-off semi-arbitrarily; freenode seems
to allow up to about 463 characters (to channel #agda, with username
jgross).

File:

• perl/modules/IRC/lib/BarnOwl/Module/IRC.pm (modified) (3 diffs)

perl/modules/IRC/lib/BarnOwl/Module/IRC.pm

@@ -23 +23 @@
 use Getopt::Long;
 use Encode;
+use Text::Wrap;
 
 our $VERSION = 0.02;
@@ -65 +66 @@
         description => 'If set, each (space-separated) message type ' .
         'provided will be hidden and ignored if received.'
+       });
+
+    BarnOwl::new_variable_int('irc:max-message-length', {
+        default     => 450,
+        summary     => 'Split messages to at most this many characters.' .
+                       "If non-positive, don't split messages",
+        description => 'If set to a positive number, any paragraph in an ' .
+                       'IRC message will be split after this many characters.'
        });
 
@@ -427 +436 @@
     @msgs = split "\n\n", $fullbody;
     map { tr/\n/ / } @msgs;
+    # split each body at irc:max-message-length characters, if that number
+    # is positive.  Only split at space boundaries.  Start counting a-fresh
+    # at the beginning of each paragraph
+    my $max_len = BarnOwl::getvar('irc:max-message-length');
+    if ($max_len > 0) {
+        local($Text::Wrap::columns) = $max_len;
+        @msgs = split "\n", wrap("", "", join "\n", @msgs);
+    }
     for my $body (@msgs) {
         if ($body =~ /^\/me (.*)/) {