Changeset c3ab155

Timestamp:

Jun 17, 2003, 9:46:10 PM (22 years ago)

Author:

James M. Kretchmar <kretch@mit.edu>

Branches:

master, barnowl_perlaim, debian, owl, release-1.10, release-1.4, release-1.5, release-1.6, release-1.7, release-1.8, release-1.9

Children:

b1299da

Parents:

65e3901

Message:

Really use just one view now, named 'main' and recalculate
  messages when its filter is changed.  This is in preperation for
  other design changes
Added the 'default_style' variable
Added the 'toggle-oneline' command
the 'o' key is bound to 'toggle-oneline'

Files:

• ChangeLog (modified) (1 diff)
• commands.c (modified) (2 diffs)
• functions.c (modified) (3 diffs)
• keys.c (modified) (1 diff)
• owl.c (modified) (1 diff)
• owl.h (modified) (1 diff)
• stylefunc.c (modified) (1 diff)
• variable.c (modified) (1 diff)
• view.c (modified) (6 diffs)

ChangeLog

@@ -8 +8 @@
            format_msg() function is found in .owlconf
         Added the 'oneline' style
+        Added the 'default_style' variable
+        Added the 'toggle-oneline' command
+        the 'o' key is bound to 'toggle-oneline'
+        Really use just one view now, named 'main' and recalculate
+          messages when its filter is changed
         
 2.0.3

commands.c

@@ -270 +270 @@
               "alist",
               "Print a listing of buddies logged in, regardless of protocol."),
+
+  OWLCMD_ARGS("toggle-oneline", owl_command_toggleoneline, OWL_CTX_INTERACTIVE,
+              "Toggle the style between oneline and the default style",
+              "toggle-oneline",
+              ""),
 
   OWLCMD_VOID("recv:shiftleft", owl_command_shift_left, OWL_CTX_INTERACTIVE,
@@ -866 +871 @@
 char *owl_command_blist() {
   owl_function_buddylist(1, 1, NULL);
+  return(NULL);
+}
+
+char *owl_command_toggleoneline() {
+  owl_function_toggleoneline();
   return(NULL);
 }

functions.c

@@ -1955 +1955 @@
 }
 
-
-void owl_function_change_view(char *filtname)
+#if 0
+void owl_function_change_view_old(char *filtname)
 {
   owl_view *v;
@@ -1999 +1999 @@
   owl_global_set_curmsg(&g, newpos);
 
+  owl_function_calculate_topmsg(OWL_DIRECTION_DOWNWARDS);
+  owl_mainwin_redisplay(owl_global_get_mainwin(&g));
+  owl_global_set_direction_downwards(&g);
+}
+#endif
+
+void owl_function_change_view(char *filtname)
+{
+  owl_view *v;
+  owl_filter *f;
+  int curid=-1, newpos, curmsg;
+  owl_message *curm=NULL;
+
+  v=owl_global_get_current_view(&g);
+
+  curmsg=owl_global_get_curmsg(&g);
+  if (curmsg==-1) {
+    owl_function_debugmsg("Hit the curmsg==-1 case in change_view");
+  } else {
+    curm=owl_view_get_element(v, curmsg);
+    if (curm) {
+      curid=owl_message_get_id(curm);
+      owl_view_save_curmsgid(v, curid);
+    }
+  }
+
+  f=owl_global_get_filter(&g, filtname);
+  if (!f) {
+    owl_function_makemsg("Unknown filter");
+    return;
+  }
+
+  owl_view_new_filter(v, f);
+
+  /* Figure out what to set the current message to.
+   * - If the view we're leaving has messages in it, go to the closest message
+   *   to the last message pointed to in that view. 
+   * - If the view we're leaving is empty, try to restore the position
+   *   from the last time we were in the new view.  */
+  if (curm) {
+    newpos = owl_view_get_nearest_to_msgid(v, curid);
+  } else {
+    newpos = owl_view_get_nearest_to_saved(v);
+  }
+
+  owl_global_set_curmsg(&g, newpos);
   owl_function_calculate_topmsg(OWL_DIRECTION_DOWNWARDS);
   owl_mainwin_redisplay(owl_global_get_mainwin(&g));
@@ -2966 +3012 @@
   fclose(file);
 }
+
+void owl_function_toggleoneline()
+{
+  char *style;
+
+  style=owl_global_get_style(&g);
+
+  if (strcmp(style, "oneline")) {
+    owl_global_set_style(&g, "oneline");
+  } else {
+    owl_global_set_style(&g, owl_global_get_default_style(&g));
+  }
+}

keys.c

@@ -246 +246 @@
   BIND_CMD("T",   "delete trash",     "mark all 'trash' messages for deletion");
 
+  BIND_CMD("o",   "toggle-oneline", "");
+
   BIND_CMD("A",   "zaway toggle",     "toggles zaway on and off");
 

owl.c

@@ -211 +211 @@
 
   /* set the current view */
-  owl_view_create(owl_global_get_current_view(&g), f);
+  owl_view_create(owl_global_get_current_view(&g), "main", f, owl_global_get_style_by_name(&g, "default"));
 
   /* AIM init */

owl.h

@@ -314 +314 @@
 
 typedef struct _owl_view {
+  char *name;
   owl_filter *filter;
   owl_messagelist ml;
+  owl_style *style;
 } owl_view;
 

stylefunc.c

@@ -430 +430 @@
       
     /* make personal messages bold for smaat users */
-    if (owl_global_is_userclue(&g, OWL_USERCLUE_CLASSES) && owl_message_is_personal(m)) {
+    if (owl_global_is_userclue(&g, OWL_USERCLUE_CLASSES) &&
+        owl_message_is_personal(m) &&
+        owl_message_is_direction_in(m)) {
       owl_fmtext_addattr(fm, OWL_FMTEXT_ATTR_BOLD);
     }

variable.c

@@ -204 +204 @@
                       "available, 'perl'\n",
                       NULL, owl_variable_style_set, NULL),
+
+  OWLVAR_STRING( "default_style" /* %OwlVarStub */, "default",
+                 "name of the default formatting style",
+                 "This sets the default message formatting style. Possbile\n"
+                 "values include 'default' 'basic' 'oneline' and if\n"
+                 "available, 'perl'\n" ),
 
   OWLVAR_INT(    "edit:maxfillcols" /* %OwlVarStub:edit_maxfillcols */, 70,

view.c

@@ -4 +4 @@
 static const char fileIdent[] = "$Id$";
 
-void owl_view_create(owl_view *v, owl_filter *f) {
+void owl_view_create(owl_view *v, char *name, owl_filter *f, owl_style *s)
+{
+  v->name=owl_strdup(name);
   v->filter=f;
+  v->style=s;
   owl_messagelist_create(&(v->ml));
   owl_view_recalculate(v);
 }
 
-void owl_view_consider_message(owl_view *v, owl_message *m) {
-  /* if the message matches the filter then add to view */
+
+/* if the message matches the filter then add to view */
+void owl_view_consider_message(owl_view *v, owl_message *m)
+{
   if (owl_filter_message_match(v->filter, m)) {
     owl_messagelist_append_element(&(v->ml), m);
@@ -17 +22 @@
 }
 
-void owl_view_recalculate(owl_view *v) {
-  /* add all the global messages that match the filter */
+/* remove all messages, add all the global messages that match the
+ * filter.
+ */
+void owl_view_recalculate(owl_view *v)
+{
   int i, j;
   owl_messagelist *gml;
@@ -41 +49 @@
 }
 
-owl_message *owl_view_get_element(owl_view *v, int index) {
+void owl_view_new_filter(owl_view *v, owl_filter *f)
+{
+  v->filter=f;
+  owl_view_recalculate(v);
+}
+
+void owl_view_set_style(owl_view *v, owl_style *s)
+{
+  v->style=s;
+}
+
+owl_message *owl_view_get_element(owl_view *v, int index)
+{
   return(owl_messagelist_get_element(&(v->ml), index));
 }
 
-void owl_view_delete_element(owl_view *v, int index) {
+void owl_view_delete_element(owl_view *v, int index)
+{
   owl_messagelist_delete_element(&(v->ml), index);
 }
 
-void owl_view_undelete_element(owl_view *v, int index) {
+void owl_view_undelete_element(owl_view *v, int index)
+{
   owl_messagelist_undelete_element(&(v->ml), index);
 }
 
-int owl_view_get_size(owl_view *v) {
+int owl_view_get_size(owl_view *v)
+{
   return(owl_messagelist_get_size(&(v->ml)));
 }
@@ -59 +82 @@
 /* Returns the position in the view with a message closest 
  * to the passed msgid. */
-int owl_view_get_nearest_to_msgid(owl_view *v, int targetid) {
+int owl_view_get_nearest_to_msgid(owl_view *v, int targetid)
+{
   int i, bestdist=-1, bestpos=0, curid, curdist;
 
@@ -73 +97 @@
 }
 
-int owl_view_get_nearest_to_saved(owl_view *v) {
+int owl_view_get_nearest_to_saved(owl_view *v)
+{
   int cachedid;
 
@@ -83 +108 @@
 /* saves the current message position in the filter so it can 
  * be restored later if we switch back to this filter. */
-void owl_view_save_curmsgid(owl_view *v, int curid) {
+void owl_view_save_curmsgid(owl_view *v, int curid)
+{
   owl_filter_set_cachedmsgid(v->filter, curid);
 }
 
-char *owl_view_get_filtname(owl_view *v) {
+char *owl_view_get_filtname(owl_view *v)
+{
   return(owl_filter_get_name(v->filter));
 }
 
-void owl_view_free(owl_view *v) {
+void owl_view_free(owl_view *v)
+{
   owl_list_free_simple((owl_list *) &(v->ml));
+  if (v->name) owl_free(v->name);
 }