Changeset c6adf17 for perlglue.xs

Timestamp:

Oct 1, 2010, 9:22:20 PM (14 years ago)

Author:

David Benjamin <davidben@mit.edu>

Branches:

master, release-1.10, release-1.7, release-1.8, release-1.9

Children:

afaef6e

Parents:

385cce2

git-author:

David Benjamin <davidben@mit.edu> (09/25/10 02:02:45)

git-committer:

David Benjamin <davidben@mit.edu> (10/01/10 21:22:20)

Message:

Track names along with timers, add :show timers

This will help people with BarnOwls eating CPU to diagnose timer leaks.

File:

• perlglue.xs (modified) (3 diffs)

perlglue.xs

@@ -516 +516 @@
 
 IV
-add_timer(after, interval, cb)
+add_timer(after, interval, cb, name = NULL)
         int after
         int interval
         SV *cb
+        const char *name
         PREINIT:
                 SV *ref;
@@ -525 +526 @@
         CODE:
                 ref = sv_rvweaken(newSVsv(cb));
-                t = owl_select_add_timer(after,
+                t = owl_select_add_timer(name,
+                                         after,
                                          interval,
                                          owl_perlconfig_perl_timer,
                                          owl_perlconfig_perl_timer_destroy,
                                          ref);
-        owl_function_debugmsg("Created timer %p", t);
+                owl_function_debugmsg("Created timer %s: %p", t->name ? t->name : "(unnamed)", t);
         RETVAL = (IV)t;
         OUTPUT:
@@ -542 +544 @@
         CODE:
                 t = (owl_timer*)timer;
-                owl_function_debugmsg("Freeing timer %p", t);
-                                owl_select_remove_timer(t);
+                owl_function_debugmsg("Freeing timer %s: %p", t->name ? t->name : "(unnamed)", t);
+                owl_select_remove_timer(t);
 
 MODULE = BarnOwl                PACKAGE = BarnOwl::Editwin