Changeset c79a047

Timestamp:

Sep 28, 2009, 1:14:23 PM (15 years ago)

Author:

Anders Kaseorg <andersk@mit.edu>

Branches:

master, release-1.10, release-1.4, release-1.5, release-1.6, release-1.7, release-1.8, release-1.9

Children:

de8945b

Parents:

99068d3

git-author:

Anders Kaseorg <andersk@mit.edu> (09/27/09 19:29:43)

git-committer:

Anders Kaseorg <andersk@mit.edu> (09/28/09 13:14:23)

Message:

Correctly prototype functions with no parameters as foo(void), not foo().

foo() is a deprecated old-style prototype for a function that takes
any arguments.  Specifying foo(void) catches more bugs.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>

Files:

• aim.c (modified) (3 diffs)
• commands.c (modified) (8 diffs)
• fmtext.c (modified) (1 diff)
• functions.c (modified) (44 diffs)
• help.c (modified) (1 diff)
• logging.c (modified) (1 diff)
• message.c (modified) (2 diffs)
• owl.c (modified) (1 diff)
• select.c (modified) (4 diffs)
• util.c (modified) (3 diffs)
• zephyr.c (modified) (11 diffs)

aim.c

@@ -230 +230 @@
 }
 
-void owl_aim_logged_out()
+void owl_aim_logged_out(void)
 {
   if (owl_global_is_aimloggedin(&g)) owl_function_adminmsg("", "Logged out of AIM");
@@ -408 +408 @@
 }
 
-int owl_aim_process_events()
+int owl_aim_process_events(void)
 {
   aim_session_t *aimsess;
@@ -1995 +1995 @@
 }
 
-void owl_process_aim()
+void owl_process_aim(void)
 {
   if (owl_global_is_doaimevents(&g)) {

commands.c

@@ -995 +995 @@
 };
 
-void owl_command_info()
+void owl_command_info(void)
 {
   owl_function_info();
 }
 
-void owl_command_nop()
+void owl_command_nop(void)
 {
 }
@@ -1048 +1048 @@
 }
 
-void owl_command_alist()
+void owl_command_alist(void)
 {
   owl_function_buddylist(1, 0, NULL);
 }
 
-void owl_command_blist()
+void owl_command_blist(void)
 {
   owl_function_buddylist(1, 1, NULL);
 }
 
-void owl_command_toggleoneline()
+void owl_command_toggleoneline(void)
 {
   owl_function_toggleoneline();
 }
 
-void owl_command_about()
+void owl_command_about(void)
 {
   owl_function_about();
 }
 
-void owl_command_version()
+void owl_command_version(void)
 {
   owl_function_makemsg("BarnOwl version %s", OWL_VERSION_STRING);
@@ -1319 +1319 @@
 }
 
-void owl_command_expunge()
+void owl_command_expunge(void)
 {
   owl_function_expunge();
 }
 
-void owl_command_first()
+void owl_command_first(void)
 {
   owl_global_set_rightshift(&g, 0);
@@ -1330 +1330 @@
 }
 
-void owl_command_last()
+void owl_command_last(void)
 {
   owl_function_lastmsg();
 }
 
-void owl_command_resize()
+void owl_command_resize(void)
 {
   owl_function_resize();
 }
 
-void owl_command_redisplay()
+void owl_command_redisplay(void)
 {
   owl_function_full_redisplay();
@@ -1346 +1346 @@
 }
 
-void owl_command_shift_right()
+void owl_command_shift_right(void)
 {
   owl_function_shift_right();
 }
 
-void owl_command_shift_left()
+void owl_command_shift_left(void)
 {
   owl_function_shift_left();
 }
 
-void owl_command_unsuball()
+void owl_command_unsuball(void)
 {
   owl_function_unsuball();
@@ -1388 +1388 @@
 }
 
-void owl_command_suspend()
+void owl_command_suspend(void)
 {
   owl_function_suspend();
@@ -1672 +1672 @@
 }
 
-void owl_command_quit()
+void owl_command_quit(void)
 {
   owl_function_quit();
@@ -2311 +2311 @@
 }
 
-void owl_command_beep()
+void owl_command_beep(void)
 {
   owl_function_beep();

fmtext.c

@@ -830 +830 @@
 
 /* Reset used list */
-void owl_fmtext_reset_colorpairs()
+void owl_fmtext_reset_colorpairs(void)
 {
   if (owl_global_get_hascolors(&g)) {

functions.c

@@ -44 +44 @@
 }
 
-void owl_function_show_commands()
+void owl_function_show_commands(void)
 {
   owl_list l;
@@ -78 +78 @@
 }
 
-void owl_function_show_styles() {
+void owl_function_show_styles(void) {
   owl_list l;
   owl_fmtext fm;
@@ -120 +120 @@
 }
 
-void owl_function_show_license()
+void owl_function_show_license(void)
 {
   const char *text;
@@ -166 +166 @@
 }
 
-void owl_function_show_quickstart()
+void owl_function_show_quickstart(void)
 {
     const char *message =
@@ -357 +357 @@
 }
 
-void owl_function_loopwrite_setup()
+void owl_function_loopwrite_setup(void)
 {
   owl_editwin *e;
@@ -693 +693 @@
 }
 
-void owl_function_nextmsg()
+void owl_function_nextmsg(void)
 {
   owl_function_nextmsg_full(NULL, 0, 1);
 }
 
-void owl_function_prevmsg()
+void owl_function_prevmsg(void)
 {
   owl_function_prevmsg_full(NULL, 0, 1);
 }
 
-void owl_function_nextmsg_notdeleted()
+void owl_function_nextmsg_notdeleted(void)
 {
   owl_function_nextmsg_full(NULL, 1, 1);
 }
 
-void owl_function_prevmsg_notdeleted()
+void owl_function_prevmsg_notdeleted(void)
 {
   owl_function_prevmsg_full(NULL, 1, 1);
@@ -772 +772 @@
 }
 
-void owl_function_expunge()
+void owl_function_expunge(void)
 {
   int curmsg;
@@ -808 +808 @@
 }
 
-void owl_function_firstmsg()
+void owl_function_firstmsg(void)
 {
   owl_global_set_curmsg(&g, 0);
@@ -816 +816 @@
 }
 
-void owl_function_lastmsg_noredisplay()
+void owl_function_lastmsg_noredisplay(void)
 {
   int oldcurmsg, curmsg;
@@ -838 +838 @@
 }
 
-void owl_function_lastmsg()
+void owl_function_lastmsg(void)
 {
   owl_function_lastmsg_noredisplay();
@@ -844 +844 @@
 }
 
-void owl_function_shift_right()
+void owl_function_shift_right(void)
 {
   owl_global_set_rightshift(&g, owl_global_get_rightshift(&g)+10);
@@ -851 +851 @@
 }
 
-void owl_function_shift_left()
+void owl_function_shift_left(void)
 {
   int shift;
@@ -866 +866 @@
 }
 
-void owl_function_unsuball()
+void owl_function_unsuball(void)
 {
   unsuball();
@@ -946 +946 @@
 }
 
-void owl_function_suspend()
+void owl_function_suspend(void)
 {
   endwin();
@@ -956 +956 @@
 }
 
-void owl_function_zaway_toggle()
+void owl_function_zaway_toggle(void)
 {
   if (!owl_global_is_zaway(&g)) {
@@ -966 +966 @@
 }
 
-void owl_function_zaway_on()
+void owl_function_zaway_on(void)
 {
   owl_global_set_zaway_on(&g);
@@ -972 +972 @@
 }
 
-void owl_function_zaway_off()
+void owl_function_zaway_off(void)
 {
   owl_global_set_zaway_off(&g);
@@ -978 +978 @@
 }
 
-void owl_function_aaway_toggle()
+void owl_function_aaway_toggle(void)
 {
   if (!owl_global_is_aaway(&g)) {
@@ -988 +988 @@
 }
 
-void owl_function_aaway_on()
+void owl_function_aaway_on(void)
 {
   owl_global_set_aaway_on(&g);
@@ -995 +995 @@
 }
 
-void owl_function_aaway_off()
+void owl_function_aaway_off(void)
 {
   owl_global_set_aaway_off(&g);
@@ -1002 +1002 @@
 }
 
-void owl_function_quit()
+void owl_function_quit(void)
 {
   char *ret;
@@ -1227 +1227 @@
 }
 
-void owl_function_resize()
+void owl_function_resize(void)
 {
   owl_global_set_resize_pending(&g);
 }
 
-void owl_function_run_buffercommand()
+void owl_function_run_buffercommand(void)
 {
   owl_editwin_do_callback(owl_global_get_typwin(&g));
@@ -1264 +1264 @@
 }
 
-void owl_function_beep()
+void owl_function_beep(void)
 {
   if (owl_global_is_bell(&g)) {
@@ -1302 +1302 @@
 }
 
-void owl_function_full_redisplay()
+void owl_function_full_redisplay(void)
 {
   redrawwin(owl_global_get_curs_recwin(&g));
@@ -1384 +1384 @@
 }
 
-void owl_function_about()
+void owl_function_about(void)
 {
   owl_function_popless_text(
@@ -1410 +1410 @@
 }
 
-void owl_function_info()
+void owl_function_info(void)
 {
   const owl_message *m;
@@ -1545 +1545 @@
  * style the user may be using
  */
-void owl_function_curmsg_to_popwin()
+void owl_function_curmsg_to_popwin(void)
 {
   const owl_view *v;
@@ -1628 +1628 @@
 }
 
-void owl_function_mainwin_pagedown()
+void owl_function_mainwin_pagedown(void)
 {
   int i;
@@ -1643 +1643 @@
 }
 
-void owl_function_mainwin_pageup()
+void owl_function_mainwin_pageup(void)
 {
   owl_global_set_curmsg(&g, owl_global_get_topmsg(&g));
@@ -1649 +1649 @@
 }
 
-void owl_function_getsubs()
+void owl_function_getsubs(void)
 {
   char *buff;
@@ -1664 +1664 @@
 }
 
-void owl_function_printallvars()
+void owl_function_printallvars(void)
 {
   const char *name;
@@ -1691 +1691 @@
 }
 
-void owl_function_show_variables()
+void owl_function_show_variables(void)
 {
   owl_list varnames;
@@ -1745 +1745 @@
 }
 
-void owl_function_delete_automsgs()
+void owl_function_delete_automsgs(void)
 {
   /* mark for deletion all messages in the current view that match the
@@ -1778 +1778 @@
 }
 
-void owl_function_status()
+void owl_function_status(void)
 {
   char buff[MAXPATHLEN+1];
@@ -1858 +1858 @@
 }
 
-void owl_function_show_term()
+void owl_function_show_term(void)
 {
   owl_fmtext fm;
@@ -2271 +2271 @@
 }
 
-void owl_function_show_filters()
+void owl_function_show_filters(void)
 {
   const owl_list *l;
@@ -2316 +2316 @@
 }
 
-void owl_function_show_zpunts()
+void owl_function_show_zpunts(void)
 {
   const owl_filter *f;
@@ -2749 +2749 @@
 }
 
-void owl_function_show_colors()
+void owl_function_show_colors(void)
 {
   owl_fmtext fm;
@@ -2899 +2899 @@
 }
 
-void owl_function_show_keymaps()
+void owl_function_show_keymaps(void)
 {
   owl_list l;
@@ -3379 +3379 @@
 }
 
-void owl_function_toggleoneline()
+void owl_function_toggleoneline(void)
 {
   owl_view *v;
@@ -3438 +3438 @@
 }
 
-void owl_function_showerrs()
+void owl_function_showerrs(void)
 {
   owl_fmtext fm;
@@ -3552 +3552 @@
 }
 
-int owl_function_get_color_count()
+int owl_function_get_color_count(void)
 {
      return COLORS;
@@ -3579 +3579 @@
 }
 
-void owl_function_mark_message()
+void owl_function_mark_message(void)
 {
   const owl_message *m;
@@ -3598 +3598 @@
 }
 
-void owl_function_swap_cur_marked()
+void owl_function_swap_cur_marked(void)
 {
   int marked_id;

help.c

@@ -2 +2 @@
 #include <string.h>
 
-void owl_help()
+void owl_help(void)
 {
   owl_fmtext fm;

logging.c

@@ -179 +179 @@
 
   /* create a present message so we can pass it to
-   * owl_log_shouldlog_message()
+   * owl_log_shouldlog_message(void)
    */
   m = owl_malloc(sizeof(owl_message));

message.c

@@ -14 +14 @@
 static owl_fmtext_cache * fmtext_cache_next = fmtext_cache;
 
-void owl_message_init_fmtext_cache ()
+void owl_message_init_fmtext_cache(void)
 {
     int i;
@@ -23 +23 @@
 }
 
-owl_fmtext_cache * owl_message_next_fmtext() /*noproto*/
+owl_fmtext_cache *owl_message_next_fmtext(void) /*noproto*/
 {
     owl_fmtext_cache * f = fmtext_cache_next;

owl.c

@@ -46 +46 @@
 } owl_options;
 
-void usage()
+void usage(void)
 {
   fprintf(stderr, "Barnowl version %s\n", OWL_VERSION_STRING);

select.c

@@ -152 +152 @@
 }
 
-int owl_select_dispatch_count()
+int owl_select_dispatch_count(void)
 {
   return owl_list_get_size(owl_global_get_dispatchlist(&g));
@@ -215 +215 @@
 }
 
-void owl_select_gc()
+void owl_select_gc(void)
 {
   int i;
@@ -325 +325 @@
 }
 
-void owl_select_handle_intr()
+void owl_select_handle_intr(void)
 {
   owl_input in;
@@ -336 +336 @@
 }
 
-void owl_select()
+void owl_select(void)
 {
   int i, max_fd, aim_max_fd, aim_done, ret;

util.c

@@ -454 +454 @@
 
 /* Get the default tty name.  Caller must free the return */
-char *owl_util_get_default_tty()
+char *owl_util_get_default_tty(void)
 {
   const char *tmp;
@@ -475 +475 @@
 
 /* Animation hack */
-void owl_hack_animate()
+void owl_hack_animate(void)
 {
   const owl_messagelist *ml;
@@ -671 +671 @@
 }
 
-const char * owl_get_datadir()
+const char * owl_get_datadir(void)
 {
   const char * datadir = getenv("BARNOWL_DATA_DIR");

zephyr.c

@@ -15 +15 @@
 } owl_sub_list;
 
-Code_t ZResetAuthentication();
+Code_t ZResetAuthentication(void);
 #endif
 
@@ -21 +21 @@
 
 #ifdef HAVE_LIBZEPHYR
-void owl_zephyr_initialize()
+void owl_zephyr_initialize(void)
 {
   int ret;
@@ -127 +127 @@
 }
 
-void owl_zephyr_load_initial_subs() {
+void owl_zephyr_load_initial_subs(void) {
   int ret_sd, ret_bd, ret_u;
 
@@ -154 +154 @@
 }
 #else
-void owl_zephyr_initialize()
-{
-}
-#endif
-
-
-int owl_zephyr_shutdown()
+void owl_zephyr_initialize(void)
+{
+}
+#endif
+
+
+int owl_zephyr_shutdown(void)
 {
 #ifdef HAVE_LIBZEPHYR
@@ -171 +171 @@
 }
 
-int owl_zephyr_zpending()
+int owl_zephyr_zpending(void)
 {
 #ifdef HAVE_LIBZEPHYR
@@ -183 +183 @@
 }
 
-const char *owl_zephyr_get_realm()
+const char *owl_zephyr_get_realm(void)
 {
 #ifdef HAVE_LIBZEPHYR
@@ -192 +192 @@
 }
 
-const char *owl_zephyr_get_sender()
+const char *owl_zephyr_get_sender(void)
 {
 #ifdef HAVE_LIBZEPHYR
@@ -316 +316 @@
  * Return -2 if there is a failure from zephyr to load the subscriptions.
  */
-int owl_zephyr_loadbarnowldefaultsubs()
+int owl_zephyr_loadbarnowldefaultsubs(void)
 {
 #ifdef HAVE_LIBZEPHYR
@@ -340 +340 @@
 }
 
-int owl_zephyr_loaddefaultsubs()
+int owl_zephyr_loaddefaultsubs(void)
 {
 #ifdef HAVE_LIBZEPHYR
@@ -415 +415 @@
 }
 
-void unsuball()
+void unsuball(void)
 {
 #if HAVE_LIBZEPHYR
@@ -1124 +1124 @@
  * free the return.
  */
-char *owl_zephyr_getsubs()
+char *owl_zephyr_getsubs(void)
 {
 #ifdef HAVE_LIBZEPHYR