Changeset cb54527 for perl/lib/Net/Jabber/IQ.pm

Timestamp:

Mar 26, 2007, 9:04:54 PM (17 years ago)

Author:

Nelson Elhage <nelhage@mit.edu>

Branches:

master, barnowl_perlaim, debian, release-1.10, release-1.4, release-1.5, release-1.6, release-1.7, release-1.8, release-1.9

Children:

4c2ec6c

Parents:

18a99d2

git-author:

Nelson Elhage <nelhage@mit.edu> (03/26/07 21:04:37)

git-committer:

Nelson Elhage <nelhage@mit.edu> (03/26/07 21:04:54)

Message:

Getting rid of indirect object syntax new calls. Quoting perlobj:

> But what if there are no arguments? In that case, Perl must guess what
> you want. Even worse, it must make that guess *at compile time*. Usually
> Perl gets it right, but when it doesn't you get a function call compiled
> as a method, or vice versa. This can introduce subtle bugs that are hard
> to detect.
> 
> For example, a call to a method "new" in indirect notation -- as C++
> programmers are wont to make -- can be miscompiled into a subroutine
> call if there's already a "new" function in scope. You'd end up calling
> the current package's "new" as a subroutine, rather than the desired
> class's method. The compiler tries to cheat by remembering bareword
> "require"s, but the grief when it messes up just isn't worth the years
> of debugging it will take you to track down such subtle bugs.
    

File:

• perl/lib/Net/Jabber/IQ.pm (modified) (1 diff)

perl/lib/Net/Jabber/IQ.pm

@@ -63 +63 @@
 sub RemoveX  { my $self = shift; $self->RemoveChild(@_);  }
 
-sub _new_jid    { my $self = shift; return new Net::Jabber::JID(@_);    }
-sub _new_packet { my $self = shift; return new Net::Jabber::Stanza(@_); }
-sub _iq         { my $self = shift; return new Net::Jabber::IQ(@_);     }
+sub _new_jid    { my $self = shift; return Net::Jabber::JID->new(@_);    }
+sub _new_packet { my $self = shift; return Net::Jabber::Stanza->new(@_); }
+sub _iq         { my $self = shift; return Net::Jabber::IQ->new(@_);     }
 
 1;