Changeset cb54527 for perl/lib/Net/Jabber/Protocol.pm

Timestamp:

Mar 26, 2007, 9:04:54 PM (18 years ago)

Author:

Nelson Elhage <nelhage@mit.edu>

Branches:

master, barnowl_perlaim, debian, release-1.10, release-1.4, release-1.5, release-1.6, release-1.7, release-1.8, release-1.9

Children:

4c2ec6c

Parents:

18a99d2

git-author:

Nelson Elhage <nelhage@mit.edu> (03/26/07 21:04:37)

git-committer:

Nelson Elhage <nelhage@mit.edu> (03/26/07 21:04:54)

Message:

Getting rid of indirect object syntax new calls. Quoting perlobj:

> But what if there are no arguments? In that case, Perl must guess what
> you want. Even worse, it must make that guess *at compile time*. Usually
> Perl gets it right, but when it doesn't you get a function call compiled
> as a method, or vice versa. This can introduce subtle bugs that are hard
> to detect.
> 
> For example, a call to a method "new" in indirect notation -- as C++
> programmers are wont to make -- can be miscompiled into a subroutine
> call if there's already a "new" function in scope. You'd end up calling
> the current package's "new" as a subroutine, rather than the desired
> class's method. The compiler tries to cheat by remembering bareword
> "require"s, but the grief when it messes up just isn't worth the years
> of debugging it will take you to track down such subtle bugs.
    

File:

• perl/lib/Net/Jabber/Protocol.pm (modified) (4 diffs)

perl/lib/Net/Jabber/Protocol.pm

@@ -78 +78 @@
 
     use Net::Jabber qw( Client );
-    $Con = new Net::Jabber::Client();                # From
+    $Con = Net::Jabber::Client->new();                # From
     $status = $Con->Connect(hostname=>"jabber.org"); # Net::Jabber::Client
 
@@ -84 +84 @@
 
     use Net::Jabber qw( Component );
-    $Con = new Net::Jabber::Component();             #
+    $Con = Net::Jabber::Component->new();             #
     $status = $Con->Connect(hostname=>"jabber.org",  # From
                             secret=>"bob");          # Net::Jabber::Component
@@ -1660 +1660 @@
         if exists($Net::Jabber::Query::TAGS{'http://jabber.org/protocol/feature-neg'});
     
-    my $query = new Net::Jabber::Query($tag);
+    my $query = Net::Jabber::Query->new($tag);
     $query->SetXMLNS("http://jabber.org/protocol/feature-neg");
     my $xdata = $query->NewX("jabber:x:data");
@@ -2183 +2183 @@
     while($#_ >= 0) { $args{ lc pop(@_) } = pop(@_); }
 
-    my $query = new Net::Jabber::Stanza("query");
+    my $query = Net::Jabber::Stanza->new("query");
     $query->SetXMLNS("jabber:iq:rpc");