Changeset d222c44

Timestamp:

Jan 2, 2011, 3:35:15 PM (14 years ago)

Author:

David Benjamin <davidben@mit.edu>

Branches:

master, release-1.10, release-1.8, release-1.9

Children:

719119de

Parents:

2bc6ad35

git-author:

David Benjamin <davidben@mit.edu> (12/14/10 23:53:38)

git-committer:

David Benjamin <davidben@mit.edu> (01/02/11 15:35:15)

Message:

Kill owl_getquoting and fix quoting bugs

That function is nonsense. Fix a number of quoting bugs relating to its
use (and lack thereof).

Also quote regex characters in CC narrows.

Files:

• filterelement.c (modified) (3 diffs)
• functions.c (modified) (5 diffs)
• global.c (modified) (2 diffs)
• text.c (modified) (1 diff)

filterelement.c

@@ -139 +139 @@
 static void owl_filterelement_print_re(const owl_filterelement *fe, GString *buf)
 {
-  const char *re, *q;
+  const char *re;
   g_string_append(buf, fe->field);
   g_string_append(buf, " ");
 
   re = owl_regex_get_string(&(fe->re));
-  q = owl_getquoting(re);
-  g_string_append(buf, q);
-  g_string_append(buf, re);
-  g_string_append(buf, q);
+  owl_string_append_quoted_arg(buf, re);
 }
 
@@ -153 +150 @@
 {
   g_string_append(buf, "filter ");
-  g_string_append(buf, fe->field);
+  owl_string_append_quoted_arg(buf, fe->field);
 }
 
@@ -159 +156 @@
 {
   g_string_append(buf, "perl ");
-  g_string_append(buf, fe->field);
+  owl_string_append_quoted_arg(buf, fe->field);
 }
 

functions.c

@@ -1632 +1632 @@
 
   owl_function_popless_text(str->str);
-  g_string_free(str, TRUE);
+  g_string_free(str, true);
 }
 
@@ -2492 +2492 @@
 static char *owl_function_smartfilter_cc(const owl_message *m) {
   const char *ccs;
+  char *ccs_quoted;
   char *filtname;
-  char *text;
   owl_filter *f;
+  GString *buf;
 
   ccs = owl_message_get_attribute_value(m, "zephyr_ccs");
@@ -2505 +2506 @@
   }
 
-  text = owl_sprintf("type ^zephyr$ and filter personal and "
-                     "zephyr_ccs ^%s%s%s$",
-                     owl_getquoting(ccs), ccs, owl_getquoting(ccs));
-
-  f = owl_filter_new_fromstring(filtname, text);
+  buf = g_string_new("type ^zephyr$ and filter personal and "
+                     "zephyr_ccs ^");
+  ccs_quoted = owl_text_quote(ccs, OWL_REGEX_QUOTECHARS, OWL_REGEX_QUOTEWITH);
+  owl_string_append_quoted_arg(buf, ccs_quoted);
+  g_string_append_c(buf, '$');
+  owl_free(ccs_quoted);
+
+  f = owl_filter_new_fromstring(filtname, buf->str);
+  g_string_free(buf, true);
 
   owl_global_add_filter(&g, f);
-
-  owl_free(text);
 
   return filtname;
@@ -2611 +2614 @@
   const owl_view *v;
   const owl_message *m;
-  const char *cmdprefix, *mclass, *minst;
-  char *cmd;
+  const char *mclass, *minst;
+  GString *buf;
   
   v=owl_global_get_current_view(&g);
@@ -2638 +2641 @@
                          mclass, minst);
   } else {
-    cmdprefix = "start-command zpunt ";
-    cmd = owl_malloc(strlen(cmdprefix)+strlen(mclass)+strlen(minst)+10);
-    strcpy(cmd, cmdprefix);
-    strcat(cmd, owl_getquoting(mclass));
-    strcat(cmd, mclass);
-    strcat(cmd, owl_getquoting(mclass));
+    buf = g_string_new("start-command zpunt ");
+    owl_string_append_quoted_arg(buf, mclass);
     if (type) {
-      strcat(cmd, " ");
-      strcat(cmd, owl_getquoting(minst));
-      strcat(cmd, minst);
-      strcat(cmd, owl_getquoting(minst));
+      g_string_append_c(buf, ' ');
+      owl_string_append_quoted_arg(buf, minst);
     } else {
-      strcat(cmd, " *");
-    }
-    owl_function_command(cmd);
-    owl_free(cmd);
+      g_string_append(buf, " *");
+    }
+    owl_function_command(buf->str);
+    g_string_free(buf, true);
   }
 }

global.c

@@ -710 +710 @@
 {
   char *sn_escaped;
-  const char *quote;
   g->aim_loggedin=1;
   if (g->aim_screenname) owl_free(g->aim_screenname);
@@ -716 +715 @@
   g->aim_screenname=owl_strdup(screenname);
   sn_escaped = owl_text_quote(screenname, OWL_REGEX_QUOTECHARS, OWL_REGEX_QUOTEWITH);
-  quote = owl_getquoting(sn_escaped);
-  g->aim_screenname_for_filters=owl_sprintf("%s%s%s", quote, sn_escaped, quote);
+  g->aim_screenname_for_filters = owl_arg_quote(sn_escaped);
   owl_free(sn_escaped);
 }

text.c

@@ -262 +262 @@
   }
   return(1);
-}
-
-const char *owl_getquoting(const char *line)
-{
-  if (line[0]=='\0') return("'");
-  if (strchr(line, '\'')) return("\"");
-  if (strchr(line, '"')) return("'");
-  if (strcspn(line, "\n\t ") != strlen(line)) return("'");
-  return("");
 }