Changeset d427f08 for variable.c

Timestamp:

Jun 22, 2011, 3:40:50 PM (14 years ago)

Author:

Nelson Elhage <nelhage@mit.edu>

Branches:

master, release-1.10, release-1.8, release-1.9

Children:

b343c2c

Parents:

84a071f

git-author:

Jason Gross <jgross@mit.edu> (06/06/11 05:24:30)

git-committer:

Nelson Elhage <nelhage@mit.edu> (06/22/11 15:40:50)

Message:

Use G_GNUC_WARN_UNUSED_RESULT

Have gcc warn us when we ignore the result of a function that requires
the caller to free the result, or an initilization function that can
fail.  This might help (slightly) with preventing leaks and segfaults.

Additionally changed some functions that should never fail to not
return values.  (The owl_list_* functions changed only fail if
list->size < 0, which we assume is not the case elsewhere.)

File:

• variable.c (modified) (7 diffs)

variable.c

@@ -646 +646 @@
 }
 
-owl_variable * owl_variable_newvar(const char *name, const char *summary, const char * description) {
+G_GNUC_WARN_UNUSED_RESULT owl_variable *owl_variable_newvar(const char *name, const char *summary, const char *description)
+{
   owl_variable * var = g_new0(owl_variable, 1);
   var->name = g_strdup(name);
@@ -824 +825 @@
 }
 
-char *owl_variable_get_tostring(const owl_vardict *d, const char *name) {
+G_GNUC_WARN_UNUSED_RESULT char *owl_variable_get_tostring(const owl_vardict *d, const char *name)
+{
   owl_variable *v;
   if (!name) return NULL;
@@ -832 +834 @@
 }
 
-char *owl_variable_get_default_tostring(const owl_vardict *d, const char *name) {
+G_GNUC_WARN_UNUSED_RESULT char *owl_variable_get_default_tostring(const owl_vardict *d, const char *name)
+{
   owl_variable *v;
   if (!name) return NULL;
@@ -992 +995 @@
 }
 
-char *owl_variable_bool_get_tostring_default(const owl_variable *v, const void *val) {
+G_GNUC_WARN_UNUSED_RESULT char *owl_variable_bool_get_tostring_default(const owl_variable *v, const void *val)
+{
   if (val == NULL) {
     return g_strdup("<null>");
@@ -1027 +1031 @@
 }
 
-char *owl_variable_int_get_tostring_default(const owl_variable *v, const void *val) {
+G_GNUC_WARN_UNUSED_RESULT char *owl_variable_int_get_tostring_default(const owl_variable *v, const void *val)
+{
   if (val == NULL) {
     return g_strdup("<null>");
@@ -1066 +1071 @@
 }
 
-char *owl_variable_enum_get_tostring(const owl_variable *v, const void *val) {
+G_GNUC_WARN_UNUSED_RESULT char *owl_variable_enum_get_tostring(const owl_variable *v, const void *val)
+{
   char **enums;
   int nenums, i;
@@ -1106 +1112 @@
 }
 
-char *owl_variable_string_get_tostring_default(const owl_variable *v, const void *val) {
+G_GNUC_WARN_UNUSED_RESULT char *owl_variable_string_get_tostring_default(const owl_variable *v, const void *val)
+{
   if (val == NULL) {
     return g_strdup("<null>");