Changeset d4f33f1

Timestamp:

Jul 13, 2015, 12:59:05 PM (9 years ago)

Author:

Jason Gross <jgross@mit.edu>

Branches:

master, release-1.10

Children:

4379288

Parents:

5f3f1e4

Message:

Clean up ircnets on socketless disconnect

This allows recovery from the state that BarnOwl gets into when (I
think) a disconnect message from the server is dropped, and BarnOwl
thinks it's connected, and the IRC server thinks it's not, and so you
can neither disconnect nor reconnect.

File:

• perl/modules/IRC/lib/BarnOwl/Module/IRC.pm (modified) (1 diff)

perl/modules/IRC/lib/BarnOwl/Module/IRC.pm

@@ -562 +562 @@
                                "[" . $conn->alias . "] Reconnect cancelled");
         $conn->cancel_reconnect;
+        delete $ircnets{$conn->alias};
+    } elsif (exists $ircnets{$conn->alias}) { # inconsistent state; no socket, but not yet deleted
+        BarnOwl::admin_message('IRC',
+                               "[" . $conn->alias . "] Attempt to disconnect from a socketless connection; deleting it");
         delete $ircnets{$conn->alias};
     }