Changeset d689fc7 for lib

Timestamp:

Dec 10, 2008, 1:20:11 PM (16 years ago)

Author:

Nelson Elhage <nelhage@mit.edu>

Branches:

master, release-1.10, release-1.7, release-1.8, release-1.9

Children:

1f82df9

Parents:

51a7fc5

Message:

Fix an "undefined" warning

File:

• lib/BarnOwl/Module/Twitter.pm (modified) (3 diffs)

lib/BarnOwl/Module/Twitter.pm

@@ -35 +35 @@
 }
 
-# Don't redefine variables if they already exist
-# This is a workaround for http://barnowl.mit.edu/trac/ticket/44
-# Which was fixed in svn r819
-if((BarnOwl::getvar('twitter:class')||'') eq '') {
-    my $desc = <<'END_DESC';
+my $desc = <<'END_DESC';
 BarnOwl::Module::Twitter will watch for authentic zephyrs to
 -c $twitter:class -i $twitter:instance -O $twitter:opcode
@@ -47 +43 @@
 messages with any value of that field.
 END_DESC
-    BarnOwl::new_variable_string('twitter:class',
-                               {
-                                   default => $class,
-                                   summary => 'Class to watch for Twitter messages',
-                                   description => $desc
-                                  });
-    BarnOwl::new_variable_string('twitter:instance',
-                               {
-                                   default => $instance,
-                                   summary => 'Instance on twitter:class to watch for Twitter messages.',
-                                   description => $desc
-                                  });
-    BarnOwl::new_variable_string('twitter:opcode',
-                               {
-                                   default => $opcode,
-                                   summary => 'Opcode for zephyrs that will be sent as twitter updates',
-                                   description => $desc
-                                  });
+BarnOwl::new_variable_string(
+    'twitter:class',
+    {
+        default     => $class,
+        summary     => 'Class to watch for Twitter messages',
+        description => $desc
+    }
+);
+BarnOwl::new_variable_string(
+    'twitter:instance',
+    {
+        default => $instance,
+        summary => 'Instance on twitter:class to watch for Twitter messages.',
+        description => $desc
+    }
+);
+BarnOwl::new_variable_string(
+    'twitter:opcode',
+    {
+        default => $opcode,
+        summary => 'Opcode for zephyrs that will be sent as twitter updates',
+        description => $desc
+    }
+);
 }
 
@@ -135 +137 @@
                 direction => 'in',
                 source    => decode_entities($tweet->{source}),
-                location  => decode_entities($tweet->{user}{location}) || "",
+                location  => decode_entities($tweet->{user}{location}||""),
                 body      => decode_entities($tweet->{text})
                );