Changeset dfaa47d

Timestamp:

May 14, 2009, 11:41:34 PM (15 years ago)

Author:

Geoffrey Thomas <geofft@mit.edu>

Branches:

master, release-1.10, release-1.4, release-1.5, release-1.6, release-1.7, release-1.8, release-1.9

Children:

cdaf294

Parents:

e1b136bf

git-author:

Geoffrey Thomas <geofft@mit.edu> (05/14/09 23:39:12)

git-committer:

Geoffrey Thomas <geofft@mit.edu> (05/14/09 23:41:34)

Message:

Display context for personals, so as to make <message,*,%me> usable.

Signed-off-by: Geoffrey Thomas <geofft@mit.edu>

Files:

• perl/modules/IRC/lib/BarnOwl/Message/IRC.pm (modified) (1 diff)
• perl/modules/Jabber/lib/BarnOwl/Message/Jabber.pm (modified) (1 diff)
• perlwrap.pm (modified) (4 diffs)

perl/modules/IRC/lib/BarnOwl/Message/IRC.pm

@@ -70 +70 @@
 sub context {shift->{network};}
 sub subcontext {shift->{recipient};}
+sub personal_context {"on " . shift->{network};}
 
 sub long_sender {shift->{from} || ""};

perl/modules/Jabber/lib/BarnOwl/Message/Jabber.pm

@@ -50 +50 @@
 sub subcontext {
     return shift->subject || "";
+}
+
+sub personal_context {
+    return "to " . shift->to;
 }
 

perlwrap.pm

@@ -390 +390 @@
 sub pretty_sender    { return shift->sender; }
 sub pretty_recipient { return shift->recipient; }
+
+# Override if you want a context (instance, network, etc.) on personals
+sub personal_context { return ""; }
 
 sub delete {
@@ -584 +587 @@
     my ($m) = @_;
     return ((lc($m->class) eq "message")
-            && (lc($m->instance) eq "personal")
             && $m->is_private);
 }
@@ -601 +603 @@
     my ($m) = @_;
     return strip_realm($m->recipient);
+}
+
+sub personal_context {
+    my ($m) = @_;
+    if (lc($m->instance) eq "personal") {
+        return "";
+    } else {
+        return "-i " . $m->instance;
+    }
 }
 
@@ -1023 +1034 @@
     my $header;
     if ( $m->is_personal ) {
+        my $personal_context = $m->personal_context;
+        $personal_context = ' [' . $personal_context . ']' if $personal_context;
+
         if ( $m->direction eq "out" ) {
-            $header = ucfirst $m->type . " sent to " . $m->pretty_recipient;
+            $header = ucfirst $m->type . $personal_context . " sent to " . $m->pretty_recipient;
         } else {
-            $header = ucfirst $m->type . " from " . $m->pretty_sender;
+            $header = ucfirst $m->type . $personal_context . " from " . $m->pretty_sender;
         }
     } else {