Changes in / [1fdca1b:e1e59a7]

Files:

• .gitignore (modified) (1 diff)
• Makefile.am (modified) (1 diff)
• commands.c (modified) (1 diff)
• editwin.c (modified) (3 diffs)
• fmtext.c (modified) (3 diffs)
• functions.c (modified) (2 diffs)
• perl/lib/BarnOwl.pm (modified) (1 diff)
• perl/modules/Jabber/lib/BarnOwl/Module/Jabber.pm (modified) (1 diff)
• perl_tester.c (modified) (1 diff)
• perlglue.xs (modified) (5 diffs)
• zephyr.c (modified) (2 diffs)

.gitignore

@@ -4 +4 @@
 *~
 .#*
+.*.swp
 .deps
 META.yml

Makefile.am

@@ -20 +20 @@
 perl_tester_SOURCES = $(BASE_SRCS) \
      owl.h owl_perl.h config.h \
-     libzcrypt.a \
      $(GEN_C) $(GEN_H) \
      perl_tester.c
 
-perl_tester_LDADD = libfaim/libfaim.a libzcrypt.a
+perl_tester_LDADD = libfaim/libfaim.a
 
 TESTS=runtests.sh

commands.c

@@ -861 +861 @@
   OWLCMD_VOID_CTX("edit:history-next", owl_command_edit_history_next, 
                   OWL_CTX_EDIT,
-                  "replaces the text with the previous history",
+                  "replaces the text with the next history",
                   "", ""),
 

editwin.c

@@ -326 +326 @@
 static void oe_release_excursion(owl_editwin *e, oe_excursion *x)
 {
-  oe_excursion *p;
+  oe_excursion **px;
 
   x->valid = 0;
-  if (e->excursions == NULL)
-    /* XXX huh. */ ;
-  else if (e->excursions == x)
-    e->excursions = x->next;
-  else {
-    for (p = e->excursions; p->next != NULL; p = p->next)
-      if (p->next == x) {
-        p->next = p->next->next;
-        break;
-      }
-    /* and if we ran off the end? XXX */
-  }
+  for (px = &e->excursions; *px != NULL; px = &(*px)->next)
+    if (*px == x) {
+      *px = x->next;
+      return;
+    }
+  abort();
 }
 
@@ -1258 +1252 @@
 
   if (!g_unichar_iscntrl(c) || c == '\n' || c== '\t' ) {
-    memset(tmp, 0, 7);
-
     if (c == '\n' && e->style == OWL_EDITWIN_STYLE_ONELINE) {
       return;
@@ -1302 +1294 @@
       return; /* our work here is done */
 
-    g_unichar_to_utf8(c, tmp);
+    tmp[g_unichar_to_utf8(c, tmp)] = '\0';
     owl_editwin_replace(e, 0, tmp);
   }

fmtext.c

@@ -57 +57 @@
 
   /* Set attributes */
-  if (a) {
-    memset(attrbuff,0,6);
-    g_unichar_to_utf8(OWL_FMTEXT_UC_ATTR | attr, attrbuff);
-    strcat(f->textbuff, attrbuff);      
-  }
-  if (fg) {
-    memset(attrbuff,0,6);
-    g_unichar_to_utf8(OWL_FMTEXT_UC_FGCOLOR | fgcolor, attrbuff);
-    strcat(f->textbuff, attrbuff);      
-  }
-  if (bg) {
-    memset(attrbuff,0,6);
-    g_unichar_to_utf8(OWL_FMTEXT_UC_BGCOLOR | bgcolor, attrbuff);
-    strcat(f->textbuff, attrbuff);      
-  }
+  if (a)
+    strncat(f->textbuff, attrbuff,
+            g_unichar_to_utf8(OWL_FMTEXT_UC_ATTR | attr, attrbuff));
+  if (fg)
+    strncat(f->textbuff, attrbuff,
+            g_unichar_to_utf8(OWL_FMTEXT_UC_FGCOLOR | fgcolor, attrbuff));
+  if (bg)
+    strncat(f->textbuff, attrbuff,
+            g_unichar_to_utf8(OWL_FMTEXT_UC_BGCOLOR | bgcolor, attrbuff));
   
   strcat(f->textbuff, text);
@@ -202 +196 @@
   _owl_fmtext_realloc(f, newlen);
 
-  if (a) {
-    memset(attrbuff,0,6);
-    g_unichar_to_utf8(OWL_FMTEXT_UC_ATTR | attr, attrbuff);
-    strcat(f->textbuff, attrbuff);      
-  }
-  if (fg) {
-    memset(attrbuff,0,6);
-    g_unichar_to_utf8(OWL_FMTEXT_UC_FGCOLOR | fgcolor, attrbuff);
-    strcat(f->textbuff, attrbuff);      
-  }
-  if (bg) {
-    memset(attrbuff,0,6);
-    g_unichar_to_utf8(OWL_FMTEXT_UC_BGCOLOR | bgcolor, attrbuff);
-    strcat(f->textbuff, attrbuff);      
-  }
+  if (a)
+    strncat(f->textbuff, attrbuff,
+            g_unichar_to_utf8(OWL_FMTEXT_UC_ATTR | attr, attrbuff));
+  if (fg)
+    strncat(f->textbuff, attrbuff,
+            g_unichar_to_utf8(OWL_FMTEXT_UC_FGCOLOR | fgcolor, attrbuff));
+  if (bg)
+    strncat(f->textbuff, attrbuff,
+            g_unichar_to_utf8(OWL_FMTEXT_UC_BGCOLOR | bgcolor, attrbuff));
 
   strncat(f->textbuff, in->textbuff+start, stop-start+1);
@@ -315 +303 @@
         int start, end;
         while (owl_regex_compare(owl_global_get_search_re(&g), s, &start, &end) == 0) {
+          /* Prevent an infinite loop matching the empty string. */
+          if (end == 0)
+            break;
+
           /* Found search string, highlight it. */
 

functions.c

@@ -1941 +1941 @@
 {
   owl_fmtext fm;
-  char *ptr, buff[LINE];
+  char *ptr;
+  char *result;
   int i;
 
@@ -1947 +1948 @@
 
   for (i=0; i<argc; i++) {
-    ptr=long_zuser(argv[i]);
-    owl_zephyr_zlocate(ptr, buff, auth);
-    owl_fmtext_append_normal(&fm, buff);
+    ptr = long_zuser(argv[i]);
+    result = owl_zephyr_zlocate(ptr, auth);
+    owl_fmtext_append_normal(&fm, result);
+    owl_free(result);
     owl_free(ptr);
   }

perl/lib/BarnOwl.pm

@@ -435 +435 @@
 sub default_zephyr_signature
 {
-  if (my $zsig = getvar('zsig')) {
-    return $zsig;
+  my $zsig = getvar('zsig');
+  if (!$zsig && (my $zsigproc = getvar('zsigproc'))) {
+    $zsig = `$zsigproc`;
+  } elsif (!defined($zsig = get_zephyr_variable('zwrite-signature'))) {
+    $zsig = ((getpwuid($<))[6]);
+    $zsig =~ s/,.*//;
   }
-  if (my $zsigproc = getvar('zsigproc')) {
-    return `$zsigproc`;
-  }
-  my $zwrite_signature = get_zephyr_variable('zwrite-signature');
-  if (defined($zwrite_signature)) {
-    return $zwrite_signature;
-  }
-  my $name = ((getpwuid($<))[6]);
-  $name =~ s/,.*//;
-  return $name;
+  chomp($zsig);
+  return $zsig;
 }
 

perl/modules/Jabber/lib/BarnOwl/Module/Jabber.pm

@@ -321 +321 @@
               . "add <jid>     Adds <jid> to your roster.\n\n"
               . "unsub <jid>   Unsubscribe from <jid>'s presence.\n\n"
-              . "remove <jid>  Removes <jid> to your roster. (implicit unsub)\n\n"
+              . "remove <jid>  Removes <jid> from your roster. (implicit unsub)\n\n"
               . "auth <jid>    Authorizes <jid> to subscribe to your presence.\n\n"
               . "deauth <jid>  De-authorizes <jid>'s subscription to your presence.\n\n"

perl_tester.c

@@ -32 +32 @@
   perl_free(my_perl);
   PERL_SYS_TERM();
+  return 0;
 }
 

perlglue.xs

@@ -142 +142 @@
                 if (rv) owl_free(rv);
 
-void queue_message(msg) 
+void
+queue_message(msg)
         SV *msg
         PREINIT:
@@ -157 +158 @@
         }
 
-void admin_message(header, body) 
+void
+admin_message(header, body)
         const char *header
         const char *body
@@ -165 +167 @@
         }
 
-void start_question(line, callback)
+void
+start_question(line, callback)
         const char *line
         SV *callback
@@ -180 +183 @@
         }
 
-void start_password(line, callback)
+void
+start_password(line, callback)
         const char *line
         SV *callback
@@ -195 +199 @@
         }
 
-void start_edit_win(line, callback)
+void
+start_edit_win(line, callback)
         const char *line
         SV *callback

zephyr.c

@@ -911 +911 @@
 #endif
 
-void owl_zephyr_zlocate(const char *user, char *out, int auth)
+char *owl_zephyr_zlocate(const char *user, int auth)
 {
 #ifdef HAVE_LIBZEPHYR
@@ -918 +918 @@
   ZLocations_t locations;
   char *myuser;
-  
-  strcpy(out, "");
+  char *p, *result;
+
   ZResetAuthentication();
-  ret=ZLocateUser(zstr(user),&numlocs,auth?ZAUTH:ZNOAUTH);
-  if (ret != ZERR_NONE) {
-    sprintf(out, "Error locating user %s\n", user);
-    return;
-  }
-
-  if (numlocs==0) {
-    myuser=short_zuser(user);
-    sprintf(out, "%s: Hidden or not logged in\n", myuser);
-    owl_free(myuser);
-    return;
-  }
-    
-  for (;numlocs;numlocs--) {
-    ZGetLocations(&locations,&one);
-    myuser=short_zuser(user);
-    sprintf(out + strlen(out), "%s: %s\t%s\t%s\n", myuser,
-            locations.host ? locations.host : "?",
-            locations.tty ? locations.tty : "?",
-            locations.time ? locations.time : "?");
-    owl_free(myuser);
-  }
+  ret = ZLocateUser(zstr(user), &numlocs, auth ? ZAUTH : ZNOAUTH);
+  if (ret != ZERR_NONE)
+    return owl_sprintf("Error locating user %s: %s\n",
+                       user, error_message(ret));
+
+  myuser = short_zuser(user);
+  if (numlocs == 0) {
+    result = owl_sprintf("%s: Hidden or not logged in\n", myuser);
+  } else {
+    result = owl_strdup("");
+    for (; numlocs; numlocs--) {
+      ZGetLocations(&locations, &one);
+      p = owl_sprintf("%s%s: %s\t%s\t%s\n",
+                          result, myuser,
+                          locations.host ? locations.host : "?",
+                          locations.tty ? locations.tty : "?",
+                          locations.time ? locations.time : "?");
+      owl_free(result);
+      result = p;
+    }
+  }
+
+  return result;
+#else
+  return owl_strdup("");
 #endif
 }