Changeset e4e1dcb for lib/BarnOwl/Module/Twitter/Handle.pm

Timestamp:

Dec 19, 2009, 11:41:06 PM (15 years ago)

Author:

Nelson Elhage <nelhage@mit.edu>

Branches:

master, release-1.10, release-1.7, release-1.8, release-1.9

Children:

4ae10de

Parents:

e4951ea (diff), 0948fa0f (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

Message:

Merge branch 'master' into timer

Conflicts:
	lib/BarnOwl/Module/Twitter/Handle.pm

File:

• lib/BarnOwl/Module/Twitter/Handle.pm (modified) (15 diffs)

lib/BarnOwl/Module/Twitter/Handle.pm

@@ -15 +15 @@
 
 use Net::Twitter::Lite;
+BEGIN {
+    # Backwards compatibility with version of Net::Twitter::Lite that
+    # lack home_timeline.
+    if(!defined(*Net::Twitter::Lite::home_timeline{CODE})) {
+        *Net::Twitter::Lite::home_timeline =
+          \&Net::Twitter::Lite::friends_timeline;
+    }
+}
 use HTML::Entities;
 
@@ -71 +79 @@
     $self->{twitter}  = Net::Twitter::Lite->new(%twitter_args);
 
-    my $timeline = eval { $self->{twitter}->friends_timeline({count => 1}) };
-    warn "$@" if $@;
+    my $timeline = eval { $self->{twitter}->home_timeline({count => 1}) };
+    warn "$@\n" if $@;
 
     if(!defined($timeline)) {
@@ -86 +94 @@
         $self->{last_direct} = $self->{twitter}->direct_messages()->[0]{id};
     };
-    warn "$@" if $@;
+    warn "$@\n" if $@;
     $self->{last_direct} = 1 unless defined($self->{last_direct});
 
@@ -92 +100 @@
         $self->{twitter}->{ua}->timeout(1);
     };
-    warn "$@" if $@;
+    warn "$@\n" if $@;
 
     $self->sleep(0);
@@ -129 +137 @@
 }
 
+=head2 twitter_command COMMAND ARGS...
+
+Call the specified method on $self->{twitter} with an extended
+timeout. This is intended for interactive commands, with the theory
+that if the user explicitly requested an action, it is slightly more
+acceptable to hang the UI for a second or two than to fail just
+because Twitter is being slightly slow. Polling commands should be
+called normally, with the default (short) timeout, to prevent
+background Twitter suckage from hosing the UI normally.
+
+=cut
+
+sub twitter_command {
+    my $self = shift;
+    my $cmd = shift;
+
+    eval { $self->{twitter}->{ua}->timeout(5); };
+    my $result = eval {
+        $self->{twitter}->$cmd(@_);
+    };
+    my $error = $@;
+    eval { $self->{twitter}->{ua}->timeout(1); };
+    if ($error) {
+        die($error);
+    }
+    return $result;
+}
+
 sub twitter_error {
     my $self = shift;
 
     my $ratelimit = eval { $self->{twitter}->rate_limit_status };
-    warn "$@" if $@;
+    warn "$@\n" if $@;
     unless(defined($ratelimit) && ref($ratelimit) eq 'HASH') {
         # Twitter's probably just sucking, try again later.
@@ -157 +193 @@
     BarnOwl::debug("Polling " . $self->{cfg}->{account_nickname});
 
-    my $timeline = eval { $self->{twitter}->friends_timeline( { since_id => $self->{last_id} } ) };
-    warn "$@" if $@;
+    my $timeline = eval { $self->{twitter}->home_timeline( { since_id => $self->{last_id} } ) };
+    warn "$@\n" if $@;
     unless(defined($timeline) && ref($timeline) eq 'ARRAY') {
         $self->twitter_error();
@@ -166 +202 @@
     if ($self->{cfg}->{show_mentions}) {
         my $mentions = eval { $self->{twitter}->mentions( { since_id => $self->{last_id} } ) };
-        warn "$@" if $@;
+        warn "$@\n" if $@;
         unless (defined($mentions) && ref($mentions) eq 'ARRAY') {
             $self->twitter_error();
@@ -211 +247 @@
 
     my $direct = eval { $self->{twitter}->direct_messages( { since_id => $self->{last_direct} } ) };
-    warn "$@" if $@;
+    warn "$@\n" if $@;
     unless(defined($direct) && ref($direct) eq 'ARRAY') {
         $self->twitter_error();
@@ -228 +264 @@
                 location  => decode_entities($tweet->{sender}{location}||""),
                 body      => decode_entities($tweet->{text}),
-                isprivate => 'true',
+                private => 'true',
                 service   => $self->{cfg}->{service},
                 account   => $self->{cfg}->{account_nickname},
@@ -249 +285 @@
         $self->twitter_direct($1, $2);
     } elsif(defined $self->{twitter}) {
-        if(defined($reply_to)) {
-            $self->{twitter}->update({
-                status => $msg,
-                in_reply_to_status_id => $reply_to
-               });
-        } else {
-            $self->{twitter}->update($msg);
+        if(length($msg) > 140) {
+            die("Twitter: Message over 140 characters long.\n");
         }
+        $self->twitter_command('update', {
+            status => $msg,
+            defined($reply_to) ? (in_reply_to_status_id => $reply_to) : ()
+           });
     }
 }
@@ -266 +301 @@
     my $msg = shift;
     if(defined $self->{twitter}) {
-        $self->{twitter}->new_direct_message({
+        $self->twitter_command('new_direct_message', {
             user => $who,
             text => $msg
@@ -277 +312 @@
                 direction => 'out',
                 body      => $msg,
-                isprivate => 'true',
+                private => 'true',
                 service   => $self->{cfg}->{service},
                );
@@ -298 +333 @@
 }
 
+sub twitter_retweet {
+    my $self = shift;
+    my $msg = shift;
+
+    if($msg->service ne $self->{cfg}->{service}) {
+        die("Cannot retweet a message from a different service.\n");
+    }
+    $self->twitter_command(retweet => $msg->{status_id});
+}
+
 sub twitter_follow {
     my $self = shift;
@@ -303 +348 @@
     my $who = shift;
 
-    my $user = $self->{twitter}->create_friend($who);
+    my $user = $self->twitter_command('create_friend', $who);
     # returns a string on error
     if (defined $user && !ref $user) {
@@ -317 +362 @@
     my $who = shift;
 
-    my $user = $self->{twitter}->destroy_friend($who);
+    my $user = $self->twitter_command('destroy_friend', $who);
     # returns a string on error
     if (defined $user && !ref $user) {