Changeset e849734

Timestamp:

Feb 28, 2007, 9:07:37 PM (17 years ago)

Author:

Nelson Elhage <nelhage@mit.edu>

Branches:

master, barnowl_perlaim, debian, release-1.10, release-1.4, release-1.5, release-1.6, release-1.7, release-1.8, release-1.9

Children:

50622a5

Parents:

e7dc035

git-author:

Nelson Elhage <nelhage@mit.edu> (02/27/07 23:59:11)

git-committer:

Nelson Elhage <nelhage@mit.edu> (02/28/07 21:07:37)

Message:

Intern hostnames and message attribute keys

File:

• message.c (modified) (2 diffs)

message.c

@@ -39 +39 @@
 {
   int i, j;
-  owl_pair *p;
-
-  /* look for an existing pair with this key, and nuke the entry if
-     found */
+  owl_pair *p = NULL, *pair = NULL;
+
+  /* look for an existing pair with this key, */
   j=owl_list_get_size(&(m->attributes));
   for (i=0; i<j; i++) {
     p=owl_list_get_element(&(m->attributes), i);
     if (!strcmp(owl_pair_get_key(p), attrname)) {
-      owl_free(owl_pair_get_key(p));
       owl_free(owl_pair_get_value(p));
-      owl_free(p);
-      owl_list_remove_element(&(m->attributes), i);
+      pair = p;
       break;
     }
   }
 
-  p=owl_malloc(sizeof(owl_pair));
-  owl_pair_create(p, owl_strdup(attrname), owl_strdup(attrvalue));
-  owl_list_append_element(&(m->attributes), p);
+  if(pair ==  NULL) {
+    pair = owl_malloc(sizeof(owl_pair));
+    owl_pair_create(pair, owl_global_intern(&g, attrname), NULL);
+    owl_list_append_element(&(m->attributes), pair);
+  }
+  owl_pair_set_value(pair, owl_strdup(attrvalue));
 }
 
@@ -483 +483 @@
 void owl_message_set_hostname(owl_message *m, char *hostname)
 {
-  if (m==NULL) return;
-  if (m->hostname!=NULL) {
-    owl_free(m->hostname);
-  }
-  m->hostname=owl_strdup(hostname);
+  m->hostname=owl_global_intern(&g, hostname);
 }