Changeset eb6cedc

Timestamp:

Jul 17, 2009, 11:52:30 PM (15 years ago)

Author:

Nelson Elhage <nelhage@mit.edu>

Branches:

master, release-1.10, release-1.4, release-1.5, release-1.6, release-1.7, release-1.8, release-1.9

Children:

96f7b07

Parents:

b4ef908

git-author:

Nelson Elhage <nelhage@mit.edu> (07/17/09 23:31:14)

git-committer:

Nelson Elhage <nelhage@mit.edu> (07/17/09 23:52:30)

Message:

Push commands into BarnOwl:: instead of AUTOLOAD'ing them

Files:

• cmd.c (modified) (2 diffs)
• global.c (modified) (2 diffs)
• owl.c (modified) (1 diff)
• perl/lib/BarnOwl.pm (modified) (1 diff)
• perl/lib/BarnOwl/Hooks.pm (modified) (2 diffs)
• perlconfig.c (modified) (1 diff)

cmd.c

@@ -27 +27 @@
 int owl_cmddict_add_from_list(owl_cmddict *cd, owl_cmd *cmds) {
   owl_cmd *cur, *cmd;
-  for (cur = cmds; cur->name != NULL; cur++) {  
-    cmd = owl_malloc(sizeof(owl_cmd));
-    owl_cmd_create_from_template(cmd, cur);
-    owl_dict_insert_element(cd, cmd->name, (void*)cmd, NULL);
-  }
-  return 0;
+  int ret = 0;
+  for (cur = cmds; cur->name != NULL; cur++) {
+    ret = owl_cmddict_add_cmd(cd, cur);
+    if (ret < 0) break;
+  }
+  return ret;
 }
 
@@ -63 +63 @@
     return -1;
   }
-  owl_function_debugmsg("Add cmd %s", cmd->name);
+  owl_perlconfig_new_command(cmd->name);
   return owl_dict_insert_element(cd, newcmd->name, (void*)newcmd, (void(*)(void*))owl_cmd_free);
 }

global.c

@@ -40 +40 @@
 
   owl_variable_dict_setup(&(g->vars));
-  owl_cmddict_setup(&(g->cmds));
 
   g->lines=LINES;
@@ -121 +120 @@
 }
 
+/* Called once perl has been initialized */
+void owl_global_complete_setup(owl_global *g)
+{
+  owl_cmddict_setup(&(g->cmds));
+}
+
 void _owl_global_setup_windows(owl_global *g) {
   int cols, typwin_lines;

owl.c

@@ -235 +235 @@
     exit(1);
   }
+
+  owl_global_complete_setup(&g);
 
   /* setup the default filters */

perl/lib/BarnOwl.pm

@@ -167 +167 @@
     $m->legacy_populate_global();
     return &BarnOwl::Hooks::_receive_msg($m);
-}
-
-=head2 AUTOLOAD
-
-BarnOwl.pm has a C<AUTOLOAD> method that translates unused names in
-the BarnOwl:: namespace to a call to BarnOwl::command() with that
-command. Underscores are also translated to C<->s, so you can do
-e.g. C<BarnOwl::start_command()> and it will be translated into
-C<start-command>.
-
-So, if you're looking for functionality that you can't find in the
-perl interface, check C<:show commands> or C<commands.c> in the
-BarnOwl source tree -- there's a good chance it exists as a BarnOwl
-command.
-
-=head3 BUGS
-
-There are horrible quoting issues here. The AUTOLOAD simple joins your
-commands with spaces and passes them unmodified to C<::command>
-
-=cut
-
-# make BarnOwl::<command>("foo") be aliases to BarnOwl::command("<command> foo");
-sub AUTOLOAD {
-    our $AUTOLOAD;
-    my $called = $AUTOLOAD;
-    $called =~ s/.*:://;
-    $called =~ s/_/-/g;
-    return &BarnOwl::command("$called ".join(" ",@_));
 }
 

perl/lib/BarnOwl/Hooks.pm

@@ -3 +3 @@
 
 package BarnOwl::Hooks;
+
+use Carp;
 
 =head1 BarnOwl::Hooks
@@ -180 +182 @@
 }
 
+sub _new_command {
+    my $command = shift;
+    (my $symbol = $command) =~ s/-/_/g;
+    my $package = "BarnOwl";
+
+    if($symbol =~ m{^edit:(.+)$}) {
+        $symbol = $1;
+        $package = "BarnOwl::Editwin";
+    } else {
+        $symbol =~ s/:/_/;
+    }
+    {
+        no strict 'refs';
+        if(defined(*{"${package}::${symbol}"}{CODE})) {
+            return;
+        }
+        *{"${package}::${symbol}"} = sub {
+            if(@_ == 1 && $_[0] =~ m{\s}) {
+                carp "DEPRECATED: ${package}::${symbol}: Tokenizing argument on ' '.\n"
+                . "In future versions, the argument list will be passed to\n"
+                . "'$command' directly. Tokenize yourself, or use BarnOwl::command()\n"
+            }
+            BarnOwl::command($command . " " . join(" ", @_))
+          };
+    }
+}
 
 1;

perlconfig.c

@@ -429 +429 @@
 }
 
+void owl_perlconfig_new_command(char *name)
+{
+  int i, count;
+  SV *rv;
+  dSP;
+
+  ENTER;
+  SAVETMPS;
+
+  PUSHMARK(SP);
+  XPUSHs(sv_2mortal(newSVpv(name, 0)));
+  PUTBACK;
+
+  call_pv("BarnOwl::Hooks::_new_command", G_SCALAR|G_VOID);
+
+  SPAGAIN;
+
+  if(SvTRUE(ERRSV)) {
+    owl_function_error("%s", SvPV_nolen(ERRSV));
+  }
+
+  FREETMPS;
+  LEAVE;
+}
+
 char *owl_perlconfig_perlcmd(owl_cmd *cmd, int argc, char **argv)
 {