Changeset eea7bed4 for perl/modules/Jabber

Timestamp:

Aug 16, 2017, 12:53:41 PM (7 years ago)

Author:

Jason Gross <jasongross9@gmail.com>

Branches:

master

Children:

ff528e6

Parents:

da7341e

git-author:

Jason Gross <jgross@mit.edu> (07/12/11 14:42:39)

git-committer:

Jason Gross <jasongross9@gmail.com> (08/16/17 12:53:41)

Message:

Moved log file name generation to perl

I don't think that the class/personal distinction is the best for
general protocols, but I don't know what should replace it.  I've made
class-logging default to only zephyr (a slight change from previous
behavior, where jabber MUC's would be logged to $classlogpath, as well
as all non-private non-login messages from other protocols), but made
logging path generation overridable.

TODO: Decide whether or not to filter out more 'bad' characters.
Perhaps we should remove '!' because it indicates history in some shells
and makes things obnoxious, or '~' becase it indicates homedirs in many
shells.
* '/' is for separating directories, and we don't want to accidentally
  make subdirectories

We first NFKC for zephyrs, and then apply lc.  The zephyr servers
apply case-folded NFKC (so says
http://zephyr.1ts.org/browser/zephyr/server/zstring.c).  We should
probably use Unicode::CaseFold instead of lc.  I'm also not sure what
the order case-adjustment and normalization should be.

We first NFKC, then apply lc, to jabbers, as per
http://xmpp.org/internet-drafts/attic/draft-ietf-xmpp-nodeprep-03.html
(though I can't actually find anything that specifies the case-folding
algorithm, nor the ordering).

We now use lc instead of g_utf8_strdown to normalize AIM screennames.

File:

• perl/modules/Jabber/lib/BarnOwl/Message/Jabber.pm (modified) (2 diffs)

perl/modules/Jabber/lib/BarnOwl/Message/Jabber.pm

@@ -15 +15 @@
 
 use base qw( BarnOwl::Message );
+use Unicode::Normalize qw( NFKC );
 
 sub jtype { shift->{jtype} };
@@ -172 +173 @@
 }
 
+sub log_filenames {
+    return map { lc(NFKC($_)) } BarnOwl::Message::log_filenames(@_);
+}
+
 =head1 SEE ALSO