Changeset f25df21 for keymap.c


Ignore:
Timestamp:
Mar 24, 2011, 4:05:29 PM (10 years ago)
Author:
David Benjamin <davidben@mit.edu>
Branches:
master, release-1.8, release-1.9
Children:
c809f5e
Parents:
e56303f
git-author:
David Benjamin <davidben@mit.edu> (03/08/11 15:04:52)
git-committer:
David Benjamin <davidben@mit.edu> (03/24/11 16:05:29)
Message:
Don't call owl_list_create in owl_dict_get_keys

Until we get rid of this owl_list thing altogether, there should be a
convention as to who initializes the thing. Otherwise, we leak memory
from people initializing it too many times.

Whoever reviews this probably wants to look over this very carefully in
case I missed one of the owl_list_creates.

Also kill the various wrappers over owl_list_cleanup as they are not the
inverse of any operation.
File:
1 edited

Legend:

Unmodified
Added
Removed
  • keymap.c

    r3472845 rf25df21  
    217217}
    218218
    219 /* free the list with owl_cmddict_namelist_cleanup */
    220219void owl_keyhandler_get_keymap_names(const owl_keyhandler *kh, owl_list *l)
    221220{
    222221  owl_dict_get_keys(&kh->keymaps, l);
    223222}
    224 
    225 void owl_keyhandler_keymap_namelist_cleanup(owl_list *l)
    226 {
    227   owl_list_cleanup(l, g_free);
    228 }
    229 
    230223
    231224
Note: See TracChangeset for help on using the changeset viewer.