Changeset f421190 for perl/modules/Jabber/lib/BarnOwl/Module/Jabber.pm

Timestamp:

Mar 14, 2012, 12:57:21 PM (12 years ago)

Author:

David Benjamin <davidben@mit.edu>

Children:

5832433

Parents:

d474ee9

git-author:

David Benjamin <davidben@mit.edu> (03/13/12 14:05:14)

git-committer:

David Benjamin <davidben@mit.edu> (03/14/12 12:57:21)

Message:

Load Jabber implementation lazily

Brings our startup RSS down from about 45MB to 32MB. Fixes #213.

File:

• perl/modules/Jabber/lib/BarnOwl/Module/Jabber.pm (modified) (3 diffs)

perl/modules/Jabber/lib/BarnOwl/Module/Jabber.pm

@@ -16 +16 @@
 use BarnOwl;
 use BarnOwl::Hooks;
-use BarnOwl::Module::Jabber::Impl;
 
 use utf8;
 
 our $VERSION = 0.1;
+
+our $impl_loaded;
+$impl_loaded = 0 unless defined($impl_loaded);
+
+sub _load_impl {
+    unless ($impl_loaded) {
+        BarnOwl::debug("_load_impl");
+        require BarnOwl::Module::Jabber::Impl;
+        $impl_loaded = 1;
+        BarnOwl::Module::Jabber::Impl::onStart();
+    }
+}
 
 sub onStart {
@@ -51 +62 @@
                                 });
 
-        BarnOwl::Module::Jabber::Impl::onStart();
+        # If we're called as part of module reload, let Impl's reload
+        # code run too.
+        if ($impl_loaded) {
+            BarnOwl::Module::Jabber::Impl::onStart();
+        }
     } else {
         # Our owl doesn't support queue_message. Unfortunately, this
@@ -64 +79 @@
     my $func = shift;
     return sub {
+        _load_impl();
         no strict 'refs';
         &{"BarnOwl::Module::Jabber::Impl::$func"};