Changeset f89cc6f

Timestamp:

Sep 30, 2011, 11:09:17 PM (12 years ago)

Author:

David Benjamin <davidben@mit.edu>

Branches:

master, release-1.10, release-1.9

Children:

215b8d5, f49afc3, f34728b, ba4d1ad

Parents:

6329cd5

git-author:

David Benjamin <davidben@mit.edu> (09/30/11 20:58:39)

git-committer:

David Benjamin <davidben@mit.edu> (09/30/11 23:09:17)

Message:

Use the pre-parsed argc/argv in building owl_zwrites

When called programmatically, the buff argument is, unfortunately,
bogus. Quoting that correctly is somewhat more of a pain due to
skiptokens commands. (See e3c8332fa85642544dba1222912b77cf6e32ce8c and
6a7111370ea0e1de2c3eb86a85f34cd68848d4b1. Though we really should fix
that properly sometime.) This fixes programmatically sending zwrites
from perl with spaces and such. For instance,

  BarnOwl::zwrite('-c', 'barnowl', '-i', 'spaces yay?');

and

  BarnOwl::zwrite('davidben', '-m', "mangoes\nare\ntasty");

It also, as a side effect, brings us one small step closer to
eliminating the buff argument from C commands.

Reported-by: Alex Dehnert <adehnert@mit.edu>

File:

• commands.c (modified) (1 diff)

commands.c

@@ -1985 +1985 @@
   }
   /* check for a zwrite -m */
-  z = owl_zwrite_new_from_line(buff);
+  z = owl_zwrite_new(argc, argv);
   if (!z) {
     owl_function_error("Error in zwrite arguments");