Changeset f98c74e for functions.c

Timestamp:

Apr 5, 2009, 7:36:53 PM (15 years ago)

Author:

James M. Kretchmar <kretch@mit.edu>

Branches:

owl

Children:

51b6c7c

Parents:

9948234

Message:

Fix some strcpy's that could be vulnerable
Remove an unused function

File:

• functions.c (modified) (4 diffs)

functions.c

@@ -290 +290 @@
 {
   owl_editwin *e;
-  char buff[1024];
+  char *buff;
   owl_zwrite z;
   int ret;
@@ -320 +320 @@
   owl_editwin_clear(e);
   owl_editwin_set_dotsend(e);
-  strcpy(buff, "----> ");
-  strcat(buff, line);
-  strcat(buff, "\n");
+  buff=owl_sprintf("----> %s\n", line);
   owl_editwin_set_locktext(e, buff);
 
-  /* make it active */
   owl_global_set_typwin_active(&g);
 
   owl_global_set_buffercommand(&g, line);
+  owl_free(buff);
 }
 
@@ -334 +332 @@
 {
   owl_editwin *e;
-  char buff[1024];
+  char *buff;
 
   /* check the arguments */
@@ -350 +348 @@
   owl_editwin_clear(e);
   owl_editwin_set_dotsend(e);
-  strcpy(buff, "----> ");
-  strcat(buff, line);
-  strcat(buff, "\n");
+  buff=owl_sprintf("----> %s\n", line);
   owl_editwin_set_locktext(e, buff);
 
-  /* make it active */
   owl_global_set_typwin_active(&g);
 
   owl_global_set_buffercommand(&g, line);
+  owl_free(buff);
 }