Changeset fafb842

Timestamp:

Mar 25, 2011, 3:46:46 AM (13 years ago)

Author:

David Benjamin <davidben@mit.edu>

Children:

96ade35

Parents:

cd28517

git-author:

David Benjamin <davidben@mit.edu> (02/26/11 00:15:35)

git-committer:

David Benjamin <davidben@mit.edu> (03/25/11 03:46:46)

Message:

First go at sigwait-based signal handling

SIGINT doesn't quite work.

Files:

• Makefile.am (modified) (1 diff)
• functions.c (modified) (4 diffs)
• global.c (modified) (5 diffs)
• owl.c (modified) (4 diffs)
• owl.h (modified) (2 diffs)
• select.c (modified) (1 diff)
• signal.c (added)

Makefile.am

@@ -45 +45 @@
      aim.c buddy.c buddylist.c style.c errqueue.c \
      zbuddylist.c popexec.c select.c wcwidth.c \
-     glib_compat.c mainpanel.c msgwin.c sepbar.c editcontext.c
+     glib_compat.c mainpanel.c msgwin.c sepbar.c editcontext.c signal.c
 
 NORMAL_SRCS = filterproc.c window.c windowcb.c

functions.c

@@ -2995 +2995 @@
       i--;
     }
+#if 0
+    /* FIXME!!! */
     owl_function_mask_sigint(NULL);
     if(owl_global_is_interrupted(&g)) {
@@ -3004 +3006 @@
     }
     owl_function_unmask_sigint(NULL);
+#endif
   }
   owl_mainwin_redisplay(owl_global_get_mainwin(&g));
@@ -3086 +3089 @@
           ret=ZLocateUser(zstr(user), &numlocs, ZAUTH);
 
+#if 0
+          /* FIXME!! */
           owl_function_mask_sigint(NULL);
           if(owl_global_is_interrupted(&g)) {
@@ -3096 +3101 @@
 
           owl_function_unmask_sigint(NULL);
+#endif
 
           if (ret!=ZERR_NONE) {

global.c

@@ -16 +16 @@
 
   g_type_init();
+  g_thread_init(NULL);
 
   owl_select_init();
@@ -101 +102 @@
 
   owl_errqueue_init(&(g->errqueue));
-  g->got_err_signal=0;
 
   owl_zbuddylist_create(&(g->zbuddies));
@@ -112 +112 @@
   owl_list_create(&(g->psa_list));
   g->timerlist = NULL;
-  g->interrupted = FALSE;
   g->kill_buffer = NULL;
 }
@@ -826 +825 @@
 }
 
-void owl_global_set_errsignal(owl_global *g, int signum, siginfo_t *siginfo)
-{
-  g->got_err_signal = signum;
-  if (siginfo) {
-    g->err_signal_info = *siginfo;
-  } else {
-    siginfo_t si;
-    memset(&si, 0, sizeof(si));
-    g->err_signal_info = si;
-  }
-}
-
-int owl_global_get_errsignal_and_clear(owl_global *g, siginfo_t *siginfo)
-{
-  int signum;
-  if (siginfo && g->got_err_signal) {
-    *siginfo = g->err_signal_info;
-  } 
-  signum = g->got_err_signal;
-  g->got_err_signal = 0;
-  return signum;
-}
-
-
 owl_zbuddylist *owl_global_get_zephyr_buddylist(owl_global *g)
 {
@@ -888 +863 @@
 {
   return &(g->timerlist);
-}
-
-int owl_global_is_interrupted(const owl_global *g) {
-  return g->interrupted;
-}
-
-void owl_global_set_interrupted(owl_global *g) {
-  g->interrupted = 1;
-}
-
-void owl_global_unset_interrupted(owl_global *g) {
-  g->interrupted = 0;
 }
 

owl.c

@@ -354 +354 @@
 }
 
-void sig_handler(int sig, siginfo_t *si, void *data)
-{
-  if (sig==SIGWINCH) {
+static void sig_handler(int sig, void *data) {
+  owl_function_debugmsg("Got signal %d", sig);
+  /* TODO: These don't need to be re-entrant anymore! */
+  if (sig == SIGWINCH) {
     /* we can't inturrupt a malloc here, so it just sets a flag
      * schedulding a resize for later
      */
     owl_function_resize();
-  } else if (sig==SIGPIPE || sig==SIGCHLD) {
-    /* Set a flag and some info that we got the sigpipe
-     * so we can record that we got it and why... */
-    owl_global_set_errsignal(&g, sig, si);
-  } else if (sig==SIGTERM || sig==SIGHUP) {
+  } else if (sig == SIGPIPE || sig == SIGCHLD) {
+    owl_function_error("Got unexpected signal: %d %s",
+                       sig, (sig == SIGPIPE) ? "SIGPIPE" : "SIGCHLD");
+  } else if (sig == SIGTERM || sig == SIGHUP) {
     owl_function_quit();
-  }
-}
-
-void sigint_handler(int sig, siginfo_t *si, void *data)
-{
-  owl_global_set_interrupted(&g);
-}
-
-static int owl_errsignal_pre_select_action(owl_ps_action *a, void *data)
-{
-  siginfo_t si;
-  int signum;
-  if ((signum = owl_global_get_errsignal_and_clear(&g, &si)) > 0) {
-    owl_function_error("Got unexpected signal: %d %s  (code: %d band: %ld  errno: %d)",
-        signum, signum==SIGPIPE?"SIGPIPE":"SIG????",
-        si.si_code, si.si_band, si.si_errno);
-  }
-  return 0;
+  } else if (sig == SIGINT) {
+    owl_input in;
+    in.ch = in.uch = owl_global_get_startup_tio(&g)->c_cc[VINTR];
+    owl_process_input_char(in);
+  }
 }
 
 void owl_register_signal_handlers(void) {
-  struct sigaction sigact;
-
-  /* signal handler */
-  /*sigact.sa_handler=sig_handler;*/
-  sigact.sa_sigaction=sig_handler;
-  sigemptyset(&sigact.sa_mask);
-  sigact.sa_flags=SA_SIGINFO;
-  sigaction(SIGWINCH, &sigact, NULL);
-  sigaction(SIGALRM, &sigact, NULL);
-  sigaction(SIGPIPE, &sigact, NULL);
-  sigaction(SIGTERM, &sigact, NULL);
-  sigaction(SIGHUP, &sigact, NULL);
-
-  sigact.sa_sigaction=sigint_handler;
-  sigaction(SIGINT, &sigact, NULL);
+  sigset_t sigset;
+
+  sigemptyset(&sigset);
+  sigaddset(&sigset, SIGWINCH);
+  sigaddset(&sigset, SIGALRM);
+  sigaddset(&sigset, SIGPIPE);
+  sigaddset(&sigset, SIGTERM);
+  sigaddset(&sigset, SIGHUP);
+  sigaddset(&sigset, SIGINT);
+
+  owl_signal_init(&sigset, sig_handler, NULL);
 }
 
@@ -479 +462 @@
   g.load_initial_subs = opts.load_initial_subs;
 
-  owl_register_signal_handlers();
   owl_start_curses();
 
@@ -491 +473 @@
   g_strfreev(argv_copy);
   owl_global_set_haveaim(&g);
+
+  owl_register_signal_handlers();
 
   /* register STDIN dispatch; throw away return, we won't need it */
@@ -591 +575 @@
   g_source_unref(source);
 
-  owl_select_add_pre_select_action(owl_errsignal_pre_select_action, NULL, NULL);
-
   owl_function_debugmsg("startup: entering main loop");
   owl_select_run_loop();

owl.h

@@ -629 +629 @@
   int haveaim;
   int ignoreaimlogin;
-  volatile sig_atomic_t got_err_signal; /* 1 if we got an unexpected signal */
-  volatile siginfo_t err_signal_info;
   owl_zbuddylist zbuddies;
   GList *zaldlist;
@@ -640 +638 @@
   owl_timer *aim_nop_timer;
   int load_initial_subs;
-  volatile sig_atomic_t interrupted;
   FILE *debug_file;
   char *kill_buffer;

select.c

@@ -335 +335 @@
     owl_function_makemsg("Unable to handle keypress");
   }
-}
-
-void owl_select_mask_signals(sigset_t *oldmask) {
-  sigset_t set;
-
-  sigemptyset(&set);
-  sigaddset(&set, SIGWINCH);
-  sigaddset(&set, SIGALRM);
-  sigaddset(&set, SIGPIPE);
-  sigaddset(&set, SIGTERM);
-  sigaddset(&set, SIGHUP);
-  sigaddset(&set, SIGINT);
-  sigprocmask(SIG_BLOCK, &set, oldmask);
-}
-
-void owl_select_handle_intr(sigset_t *restore)
-{
-  owl_input in;
-
-  owl_global_unset_interrupted(&g);
-
-  sigprocmask(SIG_SETMASK, restore, NULL);
-
-  in.ch = in.uch = owl_global_get_startup_tio(&g)->c_cc[VINTR];
-  owl_process_input_char(in);
 }