Changeset fde6d80

Timestamp:

Jan 23, 2010, 10:49:54 AM (15 years ago)

Author:

Nelson Elhage <nelhage@mit.edu>

Branches:

master, release-1.10, release-1.6, release-1.7, release-1.8, release-1.9

Children:

c3a47c9

Parents:

2fec14b

Message:

owl_style_create_perl: Change refcounting convention.

Make owl_style_create_perl assume ownership of an existing ref, rather
than SvREFCNT_inc'ing its argument, for consistency with both perl
APIs and other code paths that retain SVs.

Files:

• perlglue.xs (modified) (1 diff)
• style.c (modified) (1 diff)

perlglue.xs

@@ -279 +279 @@
         {
                 s = owl_malloc(sizeof(owl_style));
-                owl_style_create_perl(s, name, sv_2mortal(newSVsv(object)));
+                owl_style_create_perl(s, name, newSVsv(object));
                 owl_global_add_style(&g, s);
         }

style.c

@@ -2 +2 @@
 #include "owl.h"
 
+/* Assumes owenership of one existing ref on `obj`*/
 void owl_style_create_perl(owl_style *s, const char *name, SV *obj)
 {
   s->name=owl_strdup(name);
-  s->perlobj = SvREFCNT_inc(obj);
+  s->perlobj = obj;
 }