Opened 15 years ago
Closed 14 years ago
#132 closed defect (fixed)
Reply does not handle newlines correctly
Reported by: | cesium@mit.edu | Owned by: | nelhage@mit.edu |
---|---|---|---|
Priority: | minor | Milestone: | BarnOwl 1.5 |
Component: | internals | Keywords: | |
Cc: |
Description
If I send a zephyr to instance "ab\ncd", and then reply to it, the zwrite line looks like
----> zwrite -c foo -i ab cd
This causes the zephyr to be sent to class foo instance ab, as well as the single recipient cd.
If I reply to instance "ab\ncd ef", on the other hand, or include quotes inside the instance, BarnOwl seems to quote correctly.
Change History (3)
comment:1 Changed 15 years ago by davidben@mit.edu
comment:2 Changed 15 years ago by nelhage@mit.edu
- Owner set to nelhage@mit.edu
While we should deal with the broader issues of handling newlines in the command line, I think the proximal issue for this ticket is that BarnOwl::quote doesn't quote newlines (and tabs, as it turns out) properly.
I'll throw together a patch later today.
comment:3 Changed 14 years ago by nelhage@mit.edu
- Resolution set to fixed
- Status changed from new to closed
Note: See
TracTickets for help on using
tickets.
We've got a number of issues when inserting a line break into the command line. search, for instance, gets very very confused. Perhaps we want to use only soft line breaks (does the editwin support that well?) in single-line editwins.
It'd also be good to make sure all our tokenizing code handles newlines properly, but I believe a lot of commands do their own parsing?