Opened 11 years ago

Last modified 10 years ago

#145 new defect

jwrite guesses wrong JID

Reported by: andersk@mit.edu Owned by:
Priority: major Milestone:
Component: jabber Keywords:
Cc:

Description

jwrite should be smarter about guessing the JID when one of the results is a MUC.

barnowl / jabber / andersk  15:49  (Anders Kaseorg)
    What’s going on here?
       Jabber [from andersk@chat.ksplice.com/dr-wily] sent to andersk@conference.mit.edu  15:48  (andersk@chat.ksplice.com/dr-wily)
           test
       OWL ADMIN
           Error 404 sending to andersk@conference.mit.edu
barnowl / jabber / andersk  15:49  (Anders Kaseorg)
    It’s as if it doesn’t know andersk@conference.mit.edu is a MUC.
…
barnowl / jabber / andersk  15:52  (Anders Kaseorg)
    But now I see: it’s guessing the source JID wrong.
barnowl / jabber / asedeno  15:53  (Alejandro R. Sedeno)
    And that's not something it should ever guess wrong when there's only one
    reasonable choice.
barnowl / jabber / andersk  16:01  (Anders Kaseorg)
    BarnOwl::Module::Jabber::guess_jwrite(undef,
    'andersk@conference.mit.edu') returns
      [
        'andersk@chat.ksplice.com/dr-wily',
        'andersk@conference.mit.edu',
        'chat'
      ],
      [
        'andersk@mit.edu/dr-wily',
        'andersk@conference.mit.edu',
        'groupchat'
      ],
      [
        'andersk@chat.ksplice.com/dr-wily',
        'andersk@conference.mit.edu',
        'chat'
      ],
      [
        'andersk@mit.edu/dr-wily',
        'andersk@conference.mit.edu',
        'groupchat'
      ]
barnowl / jabber / andersk  16:04  (Anders Kaseorg)
    In fact, looking at the code, I’m not really sure why it wouldn’t
    return that.
barnowl / jabber / asedeno  16:05  (Alejandro R. Sedeno)
    Yeah. That's a bug.
barnowl / jabber / asedeno  16:06  (Alejandro R. Sedeno)
    I'm thinking that if any results are MUCs, we should filter out the
    non-MUC guesses.

Change History (1)

comment:1 Changed 10 years ago by jgross@mit.edu

  • Component changed from internals to jabber
Note: See TracTickets for help on using tickets.