Opened 15 years ago
Closed 13 years ago
#96 closed enhancement (fixed)
keybindings for sending to a user often results in mixes as not added to command history
Reported by: | nygren@MIT.EDU | Owned by: | adehnert@mit.edu |
---|---|---|---|
Priority: | minor | Milestone: | |
Component: | ui | Keywords: | |
Cc: | adehnert@mit.edu |
Description
I've found that having a keybinding such as:
bindkey recv H command aimwrite aphacker
often results in me mixing messages to people. I'm not sure if other have the same problem? When I press "H" and send a message, I sometimes subsequently try to send a message to the same user with "M-x CURSORUP RETURN" (which is how I usually send to other users that I've just sent a message to). However, as the "aimwrite aphacker" is not added to the command history, I send a mix to the previous person I'd been conversing with. This has been embarrassing at least once.
I wonder what a good way to address this would be? Perhaps a prefix command that adds a command to the history prior to executing it? For example:
bindkey recv H command with-history aimwrite aphacker
would add "aimwrite aphacker" to the command history and then run that command?
Change History (2)
comment:1 Changed 15 years ago by adehnert@mit.edu
- Cc adehnert@mit.edu added
- Owner changed from nelhage@mit.edu to adehnert@mit.edu
comment:2 Changed 13 years ago by jgross@mit.edu
- Resolution set to fixed
- Status changed from new to closed
Patch by adehnert has been merged (see https://github.com/barnowl/barnowl/commit/35d2091772439c27428e56487a6734d50d2840ca).
I took a stab at implementing with-history as described here. It's at http://github.com/dehnert/barnowl/tree/with-history (http://github.com/dehnert/barnowl/commit/f02672dc3fbd6dd6c16c70096d1ed0d17cf055c9). It seems to mostly work, with the caveat that I think I'm getting more empty strings in my history when activating with-history via bindkey. I'm not sure why that would be, though I might be missing something obvious in my somewhat sleepy state.