Timeline


and

Mar 23, 2010:

6:10 PM WikiStart edited by nelhage@mit.edu
(diff)
6:03 PM WikiStart edited by nelhage@mit.edu
(diff)
6:03 PM Contributing created by nelhage@mit.edu
5:23 PM Changeset [59ab8dd]release-1.6release-1.7release-1.8release-1.9 by Nelson Elhage <nelhage@ksplice.com>
Erase the editwin WINDOW on resizes if there is no editwin
5:23 PM Changeset [5934b87]release-1.6release-1.7release-1.8release-1.9 by Nelson Elhage <nelhage@ksplice.com>
Merge editline:done with edit:done as well.
5:23 PM Changeset [d83621c4]release-1.6release-1.7release-1.8release-1.9 by Nelson Elhage <nelhage@ksplice.com>
Call the editwin callback after deactivating the editwin. This fixes at least two outstanding bugs: One, it is now possible to spawn a new editwin from the editwin callback, and have the right thing happen. Two, the callback now happens in the context we were in before opening the editwin, not in editwin context.
5:23 PM Changeset [0d17295]release-1.6release-1.7release-1.8release-1.9 by Nelson Elhage <nelhage@ksplice.com>
Merge editresponse:done and edit:done into a single command.
5:23 PM Changeset [38cc669]release-1.6release-1.7release-1.8release-1.9 by Nelson Elhage <nelhage@ksplice.com>
Create/destroy editwins rather than reusing a single one.
5:23 PM Changeset [8dfb59c]release-1.6release-1.7release-1.8release-1.9 by Nelson Elhage <nelhage@ksplice.com>
Nuke the editwin buffercommand. This was really just an alternate name for callback data that was known to be a string. Now that we can safely pass callback data that needs to be destroyed, it's redundant.
5:23 PM Changeset [1b1cd2c]release-1.6release-1.7release-1.8release-1.9 by Nelson Elhage <nelhage@ksplice.com>
Editwin: Add a callback to destroy cbdata
5:23 PM Changeset [6b78afb]release-1.6release-1.7release-1.8release-1.9 by Nelson Elhage <nelhage@ksplice.com>
start_question: Use the proper keymap

Mar 22, 2010:

11:13 PM Changeset [8a921b5]release-1.6release-1.7release-1.8release-1.9 by Leonid Grinberg <leonidg@mit.edu>
Add new command unbindkey for removing keybindings

Mar 21, 2010:

1:12 AM Changeset [5643f99]release-1.6release-1.7release-1.8release-1.9 by Leonid Grinberg <leonidg@mit.edu>
Abstract owl_keybinding_make_keys from owl_keybinding_init

Mar 17, 2010:

11:30 PM Changeset [2b7ef0a]release-1.6release-1.7release-1.8release-1.9 by Nelson Elhage <nelhage@ksplice.com>
Merge zcrypt into master. Merge commit 'de4233c011ac179c086b916b7d71923f6e9bda13' into HEAD
11:30 PM Changeset [e832a52]release-1.6release-1.7release-1.8release-1.9 by Nelson Elhage <nelhage@ksplice.com>
const-ify most of the strings in zcrypt.c
11:30 PM Changeset [6d7f2a8]release-1.6release-1.7release-1.8release-1.9 by Nelson Elhage <nelhage@ksplice.com>
zcrypt: Make encryption/decryption algorithms into a table.
11:30 PM Changeset [8bd190d]release-1.6release-1.7release-1.8release-1.9 by Nelson Elhage <nelhage@ksplice.com>
zcrypt: Implement AES encryption support using GPG.
11:15 PM Changeset [d564c3d]release-1.6release-1.7release-1.8release-1.9 by Nelson Elhage <nelhage@ksplice.com>
Replace the built-in zcrypt with shelling out to the zcrypt binary.
10:47 PM Changeset [c836519]release-1.6release-1.7release-1.8release-1.9 by Nelson Elhage <nelhage@ksplice.com>
Import our OpenSSL compatibility fix for zcrypt.
10:36 PM Changeset [9a4077c]release-1.6release-1.7release-1.8release-1.9 by Nelson Elhage <nelhage@ksplice.com>
zcrypt.c: Refactor encryption.
10:36 PM Changeset [f7f35c0]release-1.6release-1.7release-1.8release-1.9 by Nelson Elhage <nelhage@ksplice.com>
zcrypt.c: untabify
10:36 PM Changeset [4133e34]release-1.6release-1.7release-1.8release-1.9 by Nelson Elhage <nelhage@ksplice.com>
zcrypt: Improve error handling behavior slightly. * Don't print usage if we have valid usage, but couldn't find a key. * Exit with an appropriate exit code
10:36 PM Changeset [a08bfc3]release-1.6release-1.7release-1.8release-1.9 by Nelson Elhage <nelhage@ksplice.com>
zcrypt: Send errors to stderr, not stdout.
10:36 PM Changeset [356465e]release-1.6release-1.7release-1.8release-1.9 by Nelson Elhage <nelhage@ksplice.com>
zcrypt.c: Clean up warnings.
10:36 PM Changeset [49bc81e]release-1.6release-1.7release-1.8release-1.9 by Nelson Elhage <nelhage@ksplice.com>
zcrypt: Fix the <des.h> include.
10:36 PM Changeset [6b1c3b6]release-1.6release-1.7release-1.8release-1.9 by Nelson Elhage <nelhage@ksplice.com>
zcrypt.c: Fix the zcrypt CVEs
10:36 PM Changeset [4942723]release-1.6release-1.7release-1.8release-1.9 by Nelson Elhage <nelhage@ksplice.com>
Add a Makefile

Mar 15, 2010:

10:37 PM Changeset [51dbfb5]release-1.6release-1.7release-1.8release-1.9 by Nelson Elhage <nelhage@mit.edu>
Add usage messages to everything in scripts/
9:37 PM Changeset [edae037]release-1.6release-1.7release-1.8release-1.9 by Nelson Elhage <nelhage@mit.edu>
Import zcrypt.[c1] from outland.
10:42 AM Changeset [25bfc10]release-1.6release-1.7release-1.8release-1.9 by Alex Vandiver <alexmv@mit.edu>
Fix minor documentation typo

Mar 11, 2010:

9:37 PM Changeset [dfe94f9]release-1.6release-1.7release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Check for dirty windows in owl_function_set_cursor
9:37 PM Changeset [f449096]release-1.6release-1.7release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Drop calls to update_panels outside main loop One call is sufficient. Also, it doesn't do anything without a doupdate anyway.
9:37 PM Changeset [03c5bdd]release-1.6release-1.7release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Drop owl_popwin's first_refresh book-keeping b928b3a911f5fc1f205c12ca900557d21f47e7e2 removed all uses of the value.
9:37 PM Changeset [8830df47]release-1.6release-1.7release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
libpanel makes owl_popwin_refresh unnecessary
9:36 PM Changeset [4cca591]release-1.6release-1.7release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Drop doupdate call in owl_viewwin_redisplay Instead, set refresh flag and let the main loop take care of it.

Mar 9, 2010:

5:47 PM Changeset [2ee9e8d]release-1.6release-1.7release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Drop doupdate call in owl_editwin_redisplay It isn't being used, and we should call doupdate consistently.

Mar 8, 2010:

9:37 AM Ticket #124 (Allow cancelling IRC reconnects) closed by nelhage@mit.edu
fixed

Mar 7, 2010:

11:50 PM Changeset [1286893]release-1.6release-1.7release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
Document the init/cleanup vs. new/delete naming conventions. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Nelson Elhage <nelhage@mit.edu>
10:30 PM Changeset [f8074e9]release-1.6release-1.7release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
Use bool from <stdbool.h> instead of an ad-hoc definition in libfaim/aim.h. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Nelson Elhage <nelhage@mit.edu>
10:28 PM Changeset [423adcb]release-1.6release-1.7release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
owl_fmtext_get_colorpair: Remove unused variable default_bg. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Nelson Elhage <nelhage@mit.edu>
10:28 PM Changeset [66a8cd6]release-1.6release-1.7release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
Copy structs without memcpy. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Nelson Elhage <nelhage@mit.edu>
10:28 PM Changeset [46d940a]release-1.6release-1.7release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
atokenize: Use owl_strdup instead of memcpy. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Nelson Elhage <nelhage@mit.edu>
10:26 PM Changeset [1c4b4ca]release-1.6release-1.7release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
Rename owl_buddylist_free to owl_buddylist_cleanup. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Nelson Elhage <nelhage@mit.edu>
10:26 PM Changeset [a038c2a3]release-1.6release-1.7release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
Rename owl_buddy_free to owl_buddy_cleanup. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Nelson Elhage <nelhage@mit.edu>
10:26 PM Changeset [bb0d439]release-1.6release-1.7release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
Rename owl_keyhandler_keymap_namelist_free to owl_keyhandler_keymap_namelist_cleanup. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Nelson Elhage <nelhage@mit.edu>
10:26 PM Changeset [0bdb3a6]release-1.6release-1.7release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
Rename owl_keymap_free to owl_keymap_cleanup. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Nelson Elhage <nelhage@mit.edu>
10:26 PM Changeset [920201c]release-1.6release-1.7release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
Rename owl_keybinding_free_all to owl_keybinding_delete. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Nelson Elhage <nelhage@mit.edu>
10:26 PM Changeset [b646d00]release-1.6release-1.7release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
Rename owl_keybinding_free to owl_keybinding_cleanup. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Nelson Elhage <nelhage@mit.edu>
10:26 PM Changeset [30bb10a]release-1.6release-1.7release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
Rename owl_editwin_free to owl_editwin_delete. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Nelson Elhage <nelhage@mit.edu>
10:26 PM Changeset [94b0b1d]release-1.6release-1.7release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
Rename owl_view_free to owl_view_cleanup. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Nelson Elhage <nelhage@mit.edu>
10:26 PM Changeset [5294cbf]release-1.6release-1.7release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
Rename owl_global_free_filter_ent to owl_global_delete_filter_ent. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Nelson Elhage <nelhage@mit.edu>
10:26 PM Changeset [75c7e8e]release-1.6release-1.7release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
Rename owl_filterelement_free to owl_filterelement_cleanup. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Nelson Elhage <nelhage@mit.edu>
10:26 PM Changeset [5cbc929]release-1.6release-1.7release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
Rename owl_regex_free to owl_regex_cleanup. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Nelson Elhage <nelhage@mit.edu>
10:26 PM Changeset [963b471]release-1.6release-1.7release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
Rename owl_viewwin_free to owl_viewwin_cleanup. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Nelson Elhage <nelhage@mit.edu>
10:26 PM Changeset [b585ba2]release-1.6release-1.7release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
Rename owl_style_free to owl_style_cleanup. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Nelson Elhage <nelhage@mit.edu>
10:26 PM Changeset [a44cd91]release-1.6release-1.7release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
Rename owl_message_free to owl_message_cleanup. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Nelson Elhage <nelhage@mit.edu>
10:26 PM Changeset [c230bc1]release-1.6release-1.7release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
Rename owl_zwrite_free to owl_zwrite_cleanup. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Nelson Elhage <nelhage@mit.edu>
10:26 PM Changeset [8d4b521]release-1.6release-1.7release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
Rename owl_cmddict_namelist_free to owl_cmddict_namelist_cleanup. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Nelson Elhage <nelhage@mit.edu>
10:26 PM Changeset [685e96f]release-1.6release-1.7release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
Rename owl_cmd_free to owl_cmd_cleanup. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Nelson Elhage <nelhage@mit.edu>
10:26 PM Changeset [8f2d9bf]release-1.6release-1.7release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
Rename owl_perlconfig_cmd_free to owl_perlconfig_cmd_cleanup. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Nelson Elhage <nelhage@mit.edu>
10:26 PM Changeset [d537350]release-1.6release-1.7release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
Inline owl_dict_free_simple. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Nelson Elhage <nelhage@mit.edu>
10:26 PM Changeset [bf7aa1d]release-1.6release-1.7release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
Rename owl_dict_free_all to owl_dict_cleanup. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Nelson Elhage <nelhage@mit.edu>
10:26 PM Changeset [a1074de]release-1.6release-1.7release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
owl_dict_insert_element: Rename free_on_replace argument to delete_on_replace. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Nelson Elhage <nelhage@mit.edu>
10:26 PM Changeset [0e57335]release-1.6release-1.7release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
Rename owl_variable_dict_namelist_free to owl_variable_dict_namelist_cleanup. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Nelson Elhage <nelhage@mit.edu>
10:26 PM Changeset [5e5f08f]release-1.6release-1.7release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
Make owl_list_free_simple a special case of owl_list_cleanup. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Nelson Elhage <nelhage@mit.edu>
10:26 PM Changeset [8c59178]release-1.6release-1.7release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
Rename owl_list_free_all to owl_list_cleanup. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Nelson Elhage <nelhage@mit.edu>
10:26 PM Changeset [7ab0020]release-1.6release-1.7release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
Rename owl_fmtext_free to owl_fmtext_cleanup. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Nelson Elhage <nelhage@mit.edu>
10:25 PM Changeset [0fef6eb]release-1.6release-1.7release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
Rename owl_variable_dict_free to owl_variable_dict_cleanup. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Nelson Elhage <nelhage@mit.edu>
10:25 PM Changeset [bbd74a9]release-1.6release-1.7release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
Rename owl_variable.free_fn to delete_fn. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Nelson Elhage <nelhage@mit.edu>
10:25 PM Changeset [3b0edaa]release-1.6release-1.7release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
Rename owl_variable_free to owl_variable_delete. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Nelson Elhage <nelhage@mit.edu>
10:25 PM Changeset [40d22cf]release-1.6release-1.7release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
Rename owl_parsefree to owl_parse_delete. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Nelson Elhage <nelhage@mit.edu>
10:25 PM Changeset [1672650]release-1.6release-1.7release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
Rename atokenize_free to atokenize_delete. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Nelson Elhage <nelhage@mit.edu>
10:21 PM Changeset [43e8bb2]release-1.6release-1.7release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
owl_function_typefilt: Don’t leak an owl_filter. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Nelson Elhage <nelhage@mit.edu>
6:56 PM Changeset [b30c256]release-1.6release-1.7release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Add edit:help command for zsh-style in-edit help zsh has this convenient feature where pressing M-h while typing a command will look up the man page for the current command and fully restore your editting session afterwards. This command brings a similar feature to BarnOwl. Instead of launching man, we open the usual popwin, which is much easier to restore from. Signed-off-by: David Benjamin <davidben@mit.edu>
6:56 PM Changeset [d64f963]release-1.6release-1.7release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Prefer popwin to typwin for cursor placement If we somehow have a popwin open while the typwin is active, the popwin should have preferred cursor position. This makes the cursor position match the ordering in the old owl_process_input_char. We should probably associate a WINDOW with each context, but that might want to wait until we get a wrapper that persists across resizes. PANEL might work, but if we ever use subwins... Signed-off-by: David Benjamin <davidben@mit.edu>
6:54 PM Changeset [30c5aab]release-1.6release-1.7release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Add function for point-less parses Often, you don't care very much about the point when you do the parse. We rename existing tokenize to tokenize_with_point and add tokenize that does point-less parses. Signed-off-by: David Benjamin <davidben@mit.edu>

Mar 2, 2010:

9:19 PM barnowl-1.5.1-announce edited by nelhage@mit.edu
(diff)
9:16 PM barnowl-1.5.1-announce edited by nelhage@mit.edu
(diff)
9:14 PM Changeset [2d232ed]release-1.6release-1.7release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Move Completion::Context::tokenize into own module Also add TODO for future work. Signed-off-by: David Benjamin <davidben@mit.edu>
9:14 PM Changeset [af21934]release-1.6release-1.7release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Fix leading whitespace in tokenizer and refactor Should make tests pass. Leading whitespace now works. Also, we remove the dummy '' append in tokenize() and move it as a post-processing step in Context::new. This is so tokenize() is a little more generic. Signed-off-by: David Benjamin <davidben@mit.edu>
9:14 PM Changeset [ccafe64]release-1.6release-1.7release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Add additional (failing) tests for completer parse Completer should ignore leading whitespace. Also, to avoid invalid indices and different behavior for first word compared to rest, we change the empty string to give [''] as opposed to []. Signed-off-by: David Benjamin <davidben@mit.edu>
9:14 PM Changeset [dffb8b8]release-1.6release-1.7release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Drop popwin and borderwin from owl_popwin Again, the WINDOWs are effectively owned by their PANELs, so we remove the extra reference to avoid possible inconsistency. Because del_panel fails to delwin, we need a little dance to delete both at once. A future abstraction layer should take care of that.
9:14 PM Changeset [b3adfb5]release-1.6release-1.7release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Remove {rec,sep,msg,typ}win from owl_global With libpanel, the WINDOWs are actually owned by the corresponding PANEL object. To avoid confusion, we remove the pointers to them in the owl_window altogether. Signed-off-by: David Benjamin <davidben@mit.edu>
9:14 PM Changeset [8099357]release-1.6release-1.7release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Remove some mentions of global windows from main Sadly, we can't kill sepwin and typwin yet, as they're needed for placing the text cursor. Signed-off-by: David Benjamin <davidben@mit.edu>
9:14 PM Changeset [b928b3a]release-1.6release-1.7release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Remove popwin special-casing Finally, we can have our cake! Now that libpanel takes care of stacking, we can get rid of a lot of the painting logic that has to think about and special-case window order. Here's the first of the lobotomies. Signed-off-by: David Benjamin <davidben@mit.edu>
9:14 PM Changeset [8ae2de9]release-1.6release-1.7release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Attach PANELs to all of our WINDOWs We replace wnoutrefresh with update_panels (except in set cursor; there we have to guarantee that the window is empty.). The viewwin does not get a PANEL because it's weird and currently leeches onto someone else's WINDOW. Resizing is also rather fiddly because panel wants to know about window resizes. Not completely sure I got it right yet. The only library I know of that does something like with with ncurses (libgnt) and they endwin/refresh to resize the screen. Signed-off-by: David Benjamin <davidben@mit.edu>
9:14 PM Changeset [be1ae91]release-1.6release-1.7release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Allow compiling with panels included Add the typedef needed for the ncurses/perl arbitration. Signed-off-by: David Benjamin <davidben@mit.edu>
9:14 PM Changeset [59077f9]release-1.6release-1.7release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Link to libpanel (provided with ncurses) libpanel makes life easier with overlapping windows. Signed-off-by: David Benjamin <davidben@mit.edu>
9:14 PM WikiStart edited by nelhage@mit.edu
(diff)
9:13 PM barnowl-1.5.1-announce created by nelhage@mit.edu
8:55 PM WikiStart edited by nelhage@mit.edu
barnowl 1.5.1 (diff)
6:23 PM Changeset [050d25e]release-1.5 by Nelson Elhage <nelhage@ksplice.com>
BarnOwl 1.5.1

Mar 1, 2010:

8:33 PM Changeset [c4d1f12]release-1.5 by Nelson Elhage <nelhage@mit.edu>
Add owl_buddy_delete to fix leaks. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Alejandro R. Sedeño <asedeno@mit.edu>
8:33 PM Changeset [5e8bec6]release-1.5 by Nelson Elhage <nelhage@mit.edu>
Add owl_style_delete to fix leaks. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Alejandro R. Sedeño <asedeno@mit.edu>
8:33 PM Changeset [a96b109]release-1.5 by Nelson Elhage <nelhage@mit.edu>
Add owl_message_delete to fix leaks. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Alejandro R. Sedeño <asedeno@mit.edu>
8:33 PM Changeset [d89c61f]release-1.5 by Nelson Elhage <nelhage@mit.edu>
Add owl_cmd_delete to fix leaks. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Alejandro R. Sedeño <asedeno@mit.edu>
8:33 PM Changeset [3c0ec97]release-1.5 by Nelson Elhage <nelhage@mit.edu>
owl_cmddict_execute: Don’t leak buffers when given no arguments. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Alejandro R. Sedeño <asedeno@mit.edu>
8:33 PM Changeset [c8211b5]release-1.5 by Nelson Elhage <nelhage@mit.edu>
_owl_zephyr_process_events: Don’t leak ignored ZNotices. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Alejandro R. Sedeño <asedeno@mit.edu>
8:33 PM Changeset [7306b0f]release-1.5 by Nelson Elhage <nelhage@mit.edu>
owl_variable_enum_get_tostring: Don’t leak the tokenized settings. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Alejandro R. Sedeño <asedeno@mit.edu>
8:33 PM Changeset [337f7d5]release-1.5 by Nelson Elhage <nelhage@mit.edu>
owl_zcrypt_decrypt, owl_zcrypt_encrypt: Don’t leak the key filename. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Alejandro R. Sedeño <asedeno@mit.edu>
8:33 PM Changeset [2d0de76]release-1.5 by Nelson Elhage <nelhage@mit.edu>
owl_fmtext_appendf_normal: Don’t leak the formatted string to append. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Alejandro R. Sedeño <asedeno@mit.edu>
8:33 PM Changeset [3959547]release-1.5 by Nelson Elhage <nelhage@mit.edu>
owl_viewwin_init_fmtext: Don’t leak the temporary formatted text. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Alejandro R. Sedeño <asedeno@mit.edu>
8:33 PM Changeset [5cebc0e]release-1.5 by Nelson Elhage <nelhage@mit.edu>
owl_function_exec: Don’t leak the redirected command string. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
8:33 PM Changeset [8ea0ffc]release-1.5 by Nelson Elhage <nelhage@mit.edu>
main: Don’t leak the default tty name. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Alejandro R. Sedeño <asedeno@mit.edu>
8:33 PM Changeset [d836977c]release-1.5 by Nelson Elhage <nelhage@mit.edu>
owl_command_zwrite, owl_command_zcrypt: Don’t leak an owl_zwrite on error. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Alejandro R. Sedeño <asedeno@mit.edu>
8:33 PM Changeset [dd8340b]release-1.5 by Nelson Elhage <nelhage@mit.edu>
owl_message_get_cc_without_recipient: Don’t overflow the output buffer. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Nelson Elhage <nelhage@mit.edu>
8:33 PM Changeset [3d0a253]release-1.5 by Nelson Elhage <nelhage@mit.edu>
owl_command_aimwrite: Fix a buffer overflow on aimwrite -m. I’ve tested that this works at least as well as the old code. There’s still something wrong here because aimwrite concatenates its arguments to get the screenname and aimwrite -m doesn’t, but I don’t care anymore because libfaim is going away (right? RIGHT?). Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Sam Hartman <hartmans@mit.edu>
8:33 PM Changeset [526f630]release-1.5 by Nelson Elhage <nelhage@mit.edu>
_owl_fmtext_curs_waddstr: Quash an uninitialized variable warning. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Nelson Elhage <nelhage@mit.edu>
8:33 PM Changeset [97f85c3]release-1.5 by Nelson Elhage <nelhage@mit.edu>
owl_zephyr_get_anyone_list: Fix a leak. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Nelson Elhage <nelhage@mit.edu>
8:33 PM Changeset [67e5f4c9]release-1.5 by Nelson Elhage <nelhage@mit.edu>
owl_util_file_deleteline: Fix a leak. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Nelson Elhage <nelhage@mit.edu>
8:33 PM Changeset [212d8b7]release-1.5 by Nelson Elhage <nelhage@mit.edu>
zcrypt: Don’t allocate 32 times as much memory as we need for decrypting. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Nelson Elhage <nelhage@mit.edu>
8:33 PM Changeset [ccfa7d1]release-1.5 by Nelson Elhage <nelhage@mit.edu>
zcrypt: Don’t read off the end of misaligned input messages. This fixes an input buffer overflow noticed by asedeno and andersk. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Nelson Elhage <nelhage@mit.edu>
8:33 PM Changeset [19b2766]release-1.5 by Nelson Elhage <nelhage@mit.edu>
zcrypt: Add tests. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Nelson Elhage <nelhage@mit.edu>
8:33 PM Changeset [c4b5de8]release-1.5 by Nelson Elhage <nelhage@mit.edu>
zcrypt: Don’t append a newline when decrypting. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Nelson Elhage <nelhage@mit.edu>
8:33 PM Changeset [8fff19a]release-1.5 by Nelson Elhage <nelhage@mit.edu>
zcrypt: Add separate functions for zcrypting with a particular key. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Nelson Elhage <nelhage@mit.edu>
8:33 PM Changeset [54e1fe4]release-1.5 by Nelson Elhage <nelhage@mit.edu>
zcrypt: Change zcrypt functions to allocate their output buffer. The logic to determine the right buffer size is complicated and does not belong in callers. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Nelson Elhage <nelhage@mit.edu>
8:33 PM Changeset [b381b55]release-1.5 by Nelson Elhage <nelhage@mit.edu>
zcrypt: Don’t leak the body after decrypting a message. This fixes a leak noticed by nelhage. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Nelson Elhage <nelhage@mit.edu>
8:33 PM Changeset [b22170c]release-1.5 by Nelson Elhage <nelhage@mit.edu>
Fix zcrypt when compiling without krb4 OpenSSL's "compatibility" DES API makes des_key_schedule a structure containing an array, while in krb4 it was an array directly. Thus, we need to pass a key schedule pointer to owl_zcrypt_string_to_schedule, instead of passing the key schedule by value. The compatibility macros defined in OpenSSL's des_old.h allow that function's passing of *schedule to des_key_sched() to DTRT. Reviewed-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Nelson Elhage <nelhage@mit.edu>
8:33 PM Changeset [7d6a751]release-1.5 by Nelson Elhage <nelhage@mit.edu>
Move cachedmsgid from owl_filter to owl_view. This fixes a use-after-free bug: owl_function_create_filter sets inuse=1, removes the current filter (hence freeing it), then calls owl_function_change_currentview_filter → owl_view_save_curmsgid → owl_filter_set_cachedmsgid, which writes to the filter that was just freed. This means that you can no longer keep two independent positions in two different filters by repeatedly switching between filter1 → empty → filter2 → empty → filter1. But I doubt anyone even knew that was possible before. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Nelson Elhage <nelhage@mit.edu>
8:33 PM Changeset [7fd450f]release-1.5 by Nelson Elhage <nelhage@mit.edu>
perlglue.xs: Copy passed-in SV*s before storing them. Perl gives us a pointer to the same SV* that the caller was using, so if the caller mutates it in some way after the call, it affects our saved copy. This is definitely not what we want. Reported-by: William Throwe <wthrowe@MIT.EDU>
8:33 PM Changeset [65fca7a0]release-1.5 by Nelson Elhage <nelhage@mit.edu>
Squelch an 'uninitialized' warning in recv:shift-left.
8:15 PM Changeset [80b5c42]release-1.6release-1.7release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
Add owl_buddy_delete to fix leaks. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Alejandro R. Sedeño <asedeno@mit.edu>
8:15 PM Changeset [516c27e]release-1.6release-1.7release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
Add owl_style_delete to fix leaks. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Alejandro R. Sedeño <asedeno@mit.edu>
8:15 PM Changeset [91634ec]release-1.6release-1.7release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
Add owl_message_delete to fix leaks. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Alejandro R. Sedeño <asedeno@mit.edu>
8:15 PM Changeset [b0da027]release-1.6release-1.7release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
Add owl_cmd_delete to fix leaks. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Alejandro R. Sedeño <asedeno@mit.edu>
8:15 PM Changeset [62a000b]release-1.6release-1.7release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
owl_cmddict_execute: Don’t leak buffers when given no arguments. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Alejandro R. Sedeño <asedeno@mit.edu>
8:15 PM Changeset [46c7f5b]release-1.6release-1.7release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
_owl_zephyr_process_events: Don’t leak ignored ZNotices. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Alejandro R. Sedeño <asedeno@mit.edu>
8:15 PM Changeset [7a3a747]release-1.6release-1.7release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
owl_variable_enum_get_tostring: Don’t leak the tokenized settings. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Alejandro R. Sedeño <asedeno@mit.edu>
8:15 PM Changeset [732cc15]release-1.6release-1.7release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
owl_zcrypt_decrypt, owl_zcrypt_encrypt: Don’t leak the key filename. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Alejandro R. Sedeño <asedeno@mit.edu>
8:15 PM Changeset [1a01720]release-1.6release-1.7release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
owl_fmtext_appendf_normal: Don’t leak the formatted string to append. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Alejandro R. Sedeño <asedeno@mit.edu>
8:15 PM Changeset [3e55268]release-1.6release-1.7release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
owl_viewwin_init_fmtext: Don’t leak the temporary formatted text. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Alejandro R. Sedeño <asedeno@mit.edu>
8:15 PM Changeset [b85c1c4]release-1.6release-1.7release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
owl_function_exec: Don’t leak the redirected command string. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
8:15 PM Changeset [1915073]release-1.6release-1.7release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
main: Don’t leak the default tty name. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Alejandro R. Sedeño <asedeno@mit.edu>
8:15 PM Changeset [1a0874f]release-1.6release-1.7release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
owl_command_zwrite, owl_command_zcrypt: Don’t leak an owl_zwrite on error. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Alejandro R. Sedeño <asedeno@mit.edu>
3:56 PM Ticket #131 (Segfault on malformed CC line) closed by andersk@mit.edu
fixed: Fixed in commit ce5d18124622414778781327150c74b8ed4206fb. Thanks for …
3:53 PM Changeset [ce5d181]release-1.6release-1.7release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
owl_message_get_cc_without_recipient: Don’t overflow the output buffer. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Nelson Elhage <nelhage@mit.edu>
2:01 PM Ticket #131 (Segfault on malformed CC line) created by cesium@mit.edu
If I send a zephyr where the first line is something like […] …

Feb 28, 2010:

9:55 PM Changeset [181ea08]release-1.6release-1.7release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
owl_command_aimwrite: Fix a buffer overflow on aimwrite -m. I’ve tested that this works at least as well as the old code. There’s still something wrong here because aimwrite concatenates its arguments to get the screenname and aimwrite -m doesn’t, but I don’t care anymore because libfaim is going away (right? RIGHT?). Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Sam Hartman <hartmans@mit.edu>
4:41 AM Ticket #130 (Use-after-free with pexec) created by andersk@mit.edu
On current master (18fb86e), valgrind detects this problem after …

Feb 25, 2010:

11:04 PM Changeset [18fb86ee]release-1.6release-1.7release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
_owl_fmtext_curs_waddstr: Quash an uninitialized variable warning. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Nelson Elhage <nelhage@mit.edu>
10:58 PM Changeset [6b31006]release-1.6release-1.7release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
owl_zephyr_get_anyone_list: Fix a leak. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Nelson Elhage <nelhage@mit.edu>
10:58 PM Changeset [a61daae]release-1.6release-1.7release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
owl_util_file_deleteline: Fix a leak. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Nelson Elhage <nelhage@mit.edu>
Note: See TracTimeline for information about the timeline view.