Timeline


and

Mar 5, 2011:

3:25 PM Changeset [e3a75ed]release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Replace the remaining snprintfs with g_strdup_printf Hard-coded buffer sizes are silly.
3:25 PM Changeset [010a951]release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Make owl_variable's get_tostring_fn return a newly allocated string The mess with buffer lengths and whatnot is obnoxious. Note that this does change semantics slightly: instead of (optionally) filling a buffer and giving a return code for good vs no-variable/invalid, we now return NULL for missing variables and always return a string if the variable exists. This also appears to be more accurate from the perspective of the calls anyway.

Mar 2, 2011:

1:10 PM Changeset [9620c8d]release-1.8release-1.9 by Nelson Elhage <nelhage@mit.edu>
Load Encode module for IRC. This normally doesn't cause any problems because the Jabber module has already loaded Encode.pm, but can manifest if you run a barnowl with IRC loaded but not Jabber. It's clearly wrong, in any case.

Feb 26, 2011:

8:10 PM Changeset [f54b07d]release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Use g_get_host_name instead of gethostname and MAXHOSTNAMELEN This lets us punt thishost from owl_global. g_get_host_name implements the same localhost fallback, so we really don't need it. Also, Solaris gets upset about MAXHOSTNAMELEN when you define _XOPEN_SOURCE=500 without __EXTENSIONS__, if we ever care to get rid of that. (That said, glib's answer to this is lame. They just hardcode 100 and even forget to NUL-terminate the buffer; POSIX is apparently braindead and leaves truncation undefined. glibc is kind enough to give you ENAMETOOLONG.)
12:59 AM Changeset [cb6c9e1]release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Apply default attributes after processing commands Otherwise we reset the color after every clump of formatting characters, whether it includes a color or not. (Though this never happens because of how we generate fmtext.) Also, actually modify the current attr so that default_attrs works with search. (While I'm at it, simplify _owl_fmtext_append_fmtext a bit.)
12:58 AM Changeset [237d02c]release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Remove default_{attrs,fgcolor,bgcolor} from owl_fmtext They didn't quite behave when appending two owl_fmtexts together; what does it mean to append a string whose default color is red to one whose default color is blue? (And then you set the default to green afterwards...) Now owl_fmtext is merely a unicode string with formatting characters. Default attributes are instead a property of how you view the string and are passed to owl_fmtext_curs_waddstr. Which unfortunately means it has a lot of arguments. :-/
12:57 AM Changeset [7659079]release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Don't precompute UTF-8 encodings of format characters GString can append gunichar just fine.

Feb 23, 2011:

9:25 PM Changeset [fb6e8e3]release-1.8release-1.9 by Nelson Elhage <nelhage@mit.edu>
Sort the output of :irc-names
5:07 PM Changeset [259e0475]release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Push typos in unpunt synopsis
5:07 PM Changeset [bb85767]release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Should owl_zwrite_new fail to parse zaway, check the result In particular, should I try to reply to my good friend '-c', I might find myself a little bit depressed. Though we ought to take care of this case otherwise.
5:07 PM Changeset [eb8d9c1]release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Correctly quote reply messages in owl_zephyr_zaway Oh, I'll just go and send an automated away message to my good friend, '-c sipb'. It's not that big of a deal since we only make outgoing messages out of this though.
5:07 PM Changeset [1137802]release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Kill owl_fmtext_set_char This function is a little disturbing and, thankfully, no longer used by anyone.
12:09 AM Changeset [60d7935]release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
Use owl_util_makepath instead of faking ~ expansion by owl_text_substitute Signed-off-by: Anders Kaseorg <andersk@mit.edu>

Feb 22, 2011:

11:09 PM Changeset [5738650]release-1.8release-1.9 by Nelson Elhage <nelhage@nelhage.com>
Prepend "UNAUTH: " to displayed sender for unauthenticated zephyrs This patch extends the default style to indicate if a zephyr message is unauthenticated. [nelhage@nelhage.com: Tweak the styling, and also catch personals.]

Feb 13, 2011:

7:54 PM Changeset [8a97586]release-1.8release-1.9 by Nelson Elhage <nelhage@nelhage.com>
Fix a typo in zephyr.c

Feb 11, 2011:

5:18 PM Changeset [3472845]release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
Replace owl_sprintf with g_strdup_printf. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Karl Ramm <kcr@mit.edu>
4:31 PM Changeset [d4927a7]release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
Replace owl_strdup with g_strdup. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Karl Ramm <kcr@mit.edu>
4:31 PM Changeset [ddbbcffa]release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
Replace owl_free with g_free. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Karl Ramm <kcr@mit.edu>
4:31 PM Changeset [35b6eb9]release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
Replace owl_realloc with g_renew. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Karl Ramm <kcr@mit.edu>
4:31 PM Changeset [96828e4]release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
Replace owl_malloc with g_new and g_new0. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: Karl Ramm <kcr@mit.edu>
1:22 AM Changeset [9518a85]release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
owl_function_classinstfilt: Do not turn [ '"] into . This transformation was not invertible, and narrowing to some instances made it impossible to narrow to other instances that map to the same filter name. We have already fixed most of the quoting problems that resulted in [ '"] getting mishandled. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
1:22 AM Changeset [fba2a65]release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
For ‘punt’ with one argument, quote the filter name Signed-off-by: Anders Kaseorg <andersk@mit.edu>
1:22 AM Changeset [2c68a93]release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
Fix spurious error running ‘punt’ with no arguments Signed-off-by: Anders Kaseorg <andersk@mit.edu>

Feb 10, 2011:

11:59 PM Changeset [ab9bf01]release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
Disable special handling of START and STOP characters (^Q and ^S) Signed-off-by: Anders Kaseorg <andersk@mit.edu>
11:59 PM Changeset [7488f27]release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
Use STDIN_FILENO instead of 0 Signed-off-by: Anders Kaseorg <andersk@mit.edu>
9:10 PM Changeset [edd0be7]release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Only handle CCs in messages sent directly to you. A zephyr with a CC line received on @SOME-REALM would still handle the CC logic in replycmd. This oddity could possibly be retrofited to allow @SOME-REALM to participate in CC'd messages, but that would require us to handle CC lines on messages received on *. In the meantime, let's not leave a half-baked not-feature. Also refactor the block slightly. The original formulation is confusing; it means to condition on the recipient of the message we reply to, but actually checks $to, the recipient we use in the reply. It just happens that in one case, the two are equal. The original code would assume that case and then change its mind if it was wrong.
9:08 PM Changeset [3f82515]release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Rewrite aimwrite This now makes more gratuitous use of glib and should, as a bonus, be more sensible. In particular, we now consistently handle multi-word recipients with and without -m. Also avoid duplicating sending code.

Feb 9, 2011:

10:59 PM Changeset [6965867]release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
g_ptr_array_new_with_free_func is glib 2.22+ Use g_ptr_array_foreach instead. Reported-by: Adam Glasgall <adam@crossproduct.net>

Feb 8, 2011:

2:27 AM Changeset [8061a6a]release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
Move glib libraries from LDFLAGS to LIBS This fixes linker errors on wheezy and natty: http://wiki.debian.org/ToolChain/DSOLinking Signed-off-by: Anders Kaseorg <andersk@mit.edu> Reviewed-by: David Benjamin <davidben@mit.edu>
12:39 AM 256Colors edited by andersk@mit.edu
Debian screen-256color underline bug (diff)

Feb 7, 2011:

9:21 PM Ticket #158 (./configure --without-zephyr && make fails with undefined reference to ...) closed by jgross@mit.edu
fixed: Fixed by commit f85278b8943b3c38ffc7ed08dfb9869f6cb7f1b9

Feb 6, 2011:

1:11 AM WikiStart edited by davidben@mit.edu
(diff)
1:11 AM release-notes/1.7.1 edited by davidben@mit.edu
(diff)
1:10 AM release-notes/1.7.1 created by davidben@mit.edu

Feb 5, 2011:

11:57 PM Changeset [63d9de9]release-1.7 by David Benjamin <davidben@mit.edu>
BarnOwl 1.7.1
11:54 PM Changeset [c268c9e]release-1.7 by David Benjamin <davidben@mit.edu>
Update do-release's output to match the wiki The actual wording we use has some differences in capitalization, etc.
11:52 PM Changeset [27705b65]release-1.7 by David Benjamin <davidben@mit.edu>
Append sender's realm to Cc'd unqualified names when replying Currently, if you reply to a personal from a user in another realm, that message was Cc'd to other people on their realm, and the sender didn't specify their realm, Barnowl will try to Cc the message to users of the same name in your realm. So, if you are 'bar@EXAMPLE.ORG' and you get a message from 'foo@EXAMPLE.COM' cc'd to 'bletch', if you try to reply, Barnowl will address it to foo@EXAMPLE.COM, cc'd to 'bletch', which would be bletch@EXAMPLE.ORG, which is clearly wrong. This patch appends the sender's realm to unqualified names in the message's Cc line when generating the reply zwrite command line. [davidben@mit.edu: Fix up some edge case handling]
11:28 PM Changeset [8d553bf]release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Append sender's realm to Cc'd unqualified names when replying Currently, if you reply to a personal from a user in another realm, that message was Cc'd to other people on their realm, and the sender didn't specify their realm, Barnowl will try to Cc the message to users of the same name in your realm. So, if you are 'bar@EXAMPLE.ORG' and you get a message from 'foo@EXAMPLE.COM' cc'd to 'bletch', if you try to reply, Barnowl will address it to foo@EXAMPLE.COM, cc'd to 'bletch', which would be bletch@EXAMPLE.ORG, which is clearly wrong. This patch appends the sender's realm to unqualified names in the message's Cc line when generating the reply zwrite command line. [davidben@mit.edu: Fix up some edge case handling]

Feb 4, 2011:

5:33 PM Changeset [22662d7]release-1.7 by David Benjamin <davidben@mit.edu>
Don't reset colorpairs in the middle of drawing Resetting colorpairs while drawing the mainwin causes the existing contents in a popwin to refer to invalid color pairs. We used to draw the mainwin first and redraw the contents of each window from scratch. Moving to libpanel in 1.6 changed this, so background colors occasionally bled into your popwin. This changes the colorpair logic to only trigger when we need to, and to forcibly dirty every window if needed. NOTE: if we don't have enough color-pairs to draw the current screen, this will draw everything twice. But it will probably almost never happen. Reported-by: Alex Dehnert <adehnert@mit.edu> Reviewed-by: Alejandro R. Sedeño <asedeno@mit.edu>
5:33 PM Changeset [b1ed3e2]release-1.7 by David Benjamin <davidben@mit.edu>
Refactor some common code in colorpair_mgr Reviewed-by: Alejandro R. Sedeño <asedeno@mit.edu>
5:32 PM Changeset [099597c]release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Don't reset colorpairs in the middle of drawing Resetting colorpairs while drawing the mainwin causes the existing contents in a popwin to refer to invalid color pairs. We used to draw the mainwin first and redraw the contents of each window from scratch. Moving to libpanel in 1.6 changed this, so background colors occasionally bled into your popwin. This changes the colorpair logic to only trigger when we need to, and to forcibly dirty every window if needed. NOTE: if we don't have enough color-pairs to draw the current screen, this will draw everything twice. But it will probably almost never happen. Reported-by: Alex Dehnert <adehnert@mit.edu> Reviewed-by: Alejandro R. Sedeño <asedeno@mit.edu>
5:32 PM Changeset [e062f97]release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Refactor some common code in colorpair_mgr Reviewed-by: Alejandro R. Sedeño <asedeno@mit.edu>
3:49 PM Changeset [4d24650]release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Make owl_text_indent return a new string You can't really use it correctly as it is.
3:49 PM Changeset [e3c8332]release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Use GString in owl_cmddict_execute_argv While we're at it, provide a correctly quoted command-line.
3:49 PM Changeset [c6b1782]release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Use g_strjoinv in parsing zwrite lines
3:49 PM Changeset [0290b2a]release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Use GString instead of allocating a giant buffer in owl_parseline
3:49 PM Changeset [df3a1f4]release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Replace realloc logic in owl_zephyr_getsubs with GString
3:49 PM Changeset [9de316d1]release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
No need to NULL-terminate argument vectors owl_parseline does it for us now.
3:49 PM Changeset [7e111f4]release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Replace owl_fmtext's buffer management with GString reallocs are hard. Let's go shopping^Wuse GString!
3:49 PM Changeset [d3c318b]release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Don't stick random NULs when waddnstr exists
3:49 PM Changeset [dfe5829]release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Be more accurate in allocating argument vector in owl_command_view 50 is a pretty random number.
3:49 PM Changeset [fc7481a]release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
strndup is pretty awesome and doesn't involve adding 5
3:49 PM Changeset [65c753e]release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Use a GPtrArray to manage the growing list in owl_parseline It's much nicer than dealing with piles of owl_realloc. Also ensure that our argvs are NULL-terminated so we may used the various *v glib functions.
3:49 PM Changeset [d3941a0]release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Use g_strjoinv in owl_global_set_startupargs It's much nicer than dealing with string lengths, although it does mean we lose const-correctness because glib just gives up on that with lists of strings. Also make a copy of the argument list because getopt_long messes around with argument lists anyway.
Note: See TracTimeline for information about the timeline view.