Mar 21, 2011:

1:47 AM Ticket #166 (warning: implicit declaration of function ‘pselect’) created by andersk@mit.edu
If PERL_CFLAGS does not contain -D_GNU_SOURCE, then BarnOwl …

Mar 19, 2011:

11:21 PM Changeset [4dde585]release-1.10release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
compat/compat.h: Add #include guards Signed-off-by: Anders Kaseorg <andersk@mit.edu>
11:19 PM Changeset [2cbe7c3]release-1.10release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
Protect memrchr prototype by !HAVE_DECL_MEMCHR instead of !HAVE_MEMCHR This fixes viewwin.c:393:7: warning: implicit declaration of function ‘memrchr’ on platforms where PERL_CFLAGS doesn’t contain -D_GNU_SOURCE. !HAVE_MEMRCHR means that memrchr is undefined at link time, so we need to provide our own implementation; but !HAVE_DECL_MEMRCHR means that memrchr is not declared at compile time, so we need to provide our own prototype. http://lists.gnu.org/archive/html/bug-autoconf/2008-12/msg00037.html Signed-off-by: Anders Kaseorg <andersk@mit.edu>

Mar 14, 2011:

3:02 PM Changeset [41f0cf3]release-1.10release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
Add | to OWL_REGEX_QUOTECHARS This fixes searching for |. regex(7) lists the metacharacters “^.[$()|*+?{\”, so we actually have all of them now. Signed-off-by: Anders Kaseorg <andersk@mit.edu>

Mar 6, 2011:

2:14 PM Changeset [7d969f3]release-1.10release-1.8release-1.9 by Karl Ramm <kcr@1ts.org>
refactor owl_zephyr_zlog_in and report errors in owl_zephyr_zlog_{in,out} Use the function ZParseExposureLevel thoughtfully provided by the library, and see what happens when we actually report errors that occur here. Reviewed-By: Nelson Elhage <nelhage@nelhage.com>
2:14 PM Changeset [c518676]release-1.10release-1.8release-1.9 by Karl Ramm <kcr@1ts.org>
refactor owl_zephyr_get_message Refactor and make the control flow simpler. Really this code should get moved to perl. Reviewed-By: Nelson Elhage <nelhage@nelhage.com>
2:14 PM Changeset [00842c3]release-1.10release-1.8release-1.9 by Karl Ramm <kcr@1ts.org>
make the unsuball functions's error handling fit in with the rest of the program "what is this, I don't even" runing com_err in the middle of a curses program is just plain wrong. Reviewed-By: Nelson Elhage <nelhage@nelhage.com>
2:14 PM Changeset [c73a22d]release-1.10release-1.8release-1.9 by Karl Ramm <kcr@1ts.org>
when something goes wrong, give more information about what happened These various utility functions, instead of just saying "there was an error", should report to the user what the library thinks went wrong so they user has some small chance of debugging the problem. Reviewed-By: Nelson Elhage <nelhage@nelhage.com>
2:12 PM Changeset [488913a]release-1.10release-1.8release-1.9 by Karl Ramm <kcr@1ts.org>
owl_zephyr_initialize only needs one zephyr library return value It doesn't need two separate return-value variabels, and the one should be a Code_t. Reviewed-By: Nelson Elhage <nelhage@nelhage.com>

Mar 5, 2011:

3:25 PM Changeset [e3a75ed]release-1.10release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Replace the remaining snprintfs with g_strdup_printf Hard-coded buffer sizes are silly.
3:25 PM Changeset [010a951]release-1.10release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Make owl_variable's get_tostring_fn return a newly allocated string The mess with buffer lengths and whatnot is obnoxious. Note that this does change semantics slightly: instead of (optionally) filling a buffer and giving a return code for good vs no-variable/invalid, we now return NULL for missing variables and always return a string if the variable exists. This also appears to be more accurate from the perspective of the calls anyway.

Mar 2, 2011:

1:10 PM Changeset [9620c8d]release-1.10release-1.8release-1.9 by Nelson Elhage <nelhage@mit.edu>
Load Encode module for IRC. This normally doesn't cause any problems because the Jabber module has already loaded Encode.pm, but can manifest if you run a barnowl with IRC loaded but not Jabber. It's clearly wrong, in any case.

Feb 26, 2011:

8:10 PM Changeset [f54b07d]release-1.10release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Use g_get_host_name instead of gethostname and MAXHOSTNAMELEN This lets us punt thishost from owl_global. g_get_host_name implements the same localhost fallback, so we really don't need it. Also, Solaris gets upset about MAXHOSTNAMELEN when you define _XOPEN_SOURCE=500 without __EXTENSIONS__, if we ever care to get rid of that. (That said, glib's answer to this is lame. They just hardcode 100 and even forget to NUL-terminate the buffer; POSIX is apparently braindead and leaves truncation undefined. glibc is kind enough to give you ENAMETOOLONG.)
12:59 AM Changeset [cb6c9e1]release-1.10release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Apply default attributes after processing commands Otherwise we reset the color after every clump of formatting characters, whether it includes a color or not. (Though this never happens because of how we generate fmtext.) Also, actually modify the current attr so that default_attrs works with search. (While I'm at it, simplify _owl_fmtext_append_fmtext a bit.)
12:58 AM Changeset [237d02c]release-1.10release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Remove default_{attrs,fgcolor,bgcolor} from owl_fmtext They didn't quite behave when appending two owl_fmtexts together; what does it mean to append a string whose default color is red to one whose default color is blue? (And then you set the default to green afterwards...) Now owl_fmtext is merely a unicode string with formatting characters. Default attributes are instead a property of how you view the string and are passed to owl_fmtext_curs_waddstr. Which unfortunately means it has a lot of arguments. :-/
12:57 AM Changeset [7659079]release-1.10release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Don't precompute UTF-8 encodings of format characters GString can append gunichar just fine.

Feb 23, 2011:

9:25 PM Changeset [fb6e8e3]release-1.10release-1.8release-1.9 by Nelson Elhage <nelhage@mit.edu>
Sort the output of :irc-names
5:07 PM Changeset [259e0475]release-1.10release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Push typos in unpunt synopsis
5:07 PM Changeset [bb85767]release-1.10release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Should owl_zwrite_new fail to parse zaway, check the result In particular, should I try to reply to my good friend '-c', I might find myself a little bit depressed. Though we ought to take care of this case otherwise.
5:07 PM Changeset [eb8d9c1]release-1.10release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Correctly quote reply messages in owl_zephyr_zaway Oh, I'll just go and send an automated away message to my good friend, '-c sipb'. It's not that big of a deal since we only make outgoing messages out of this though.
5:07 PM Changeset [1137802]release-1.10release-1.8release-1.9 by David Benjamin <davidben@mit.edu>
Kill owl_fmtext_set_char This function is a little disturbing and, thankfully, no longer used by anyone.
12:09 AM Changeset [60d7935]release-1.10release-1.8release-1.9 by Anders Kaseorg <andersk@mit.edu>
Use owl_util_makepath instead of faking ~ expansion by owl_text_substitute Signed-off-by: Anders Kaseorg <andersk@mit.edu>

Feb 22, 2011:

11:09 PM Changeset [5738650]release-1.10release-1.8release-1.9 by Nelson Elhage <nelhage@nelhage.com>
Prepend "UNAUTH: " to displayed sender for unauthenticated zephyrs This patch extends the default style to indicate if a zephyr message is unauthenticated. [nelhage@nelhage.com: Tweak the styling, and also catch personals.]
Note: See TracTimeline for information about the timeline view.