Timeline


and

Aug 15, 2011:

11:32 PM Ticket #198 (Recovery instructions for ticket-failed messages) created by rlhatton@mit.edu
Currently, barnowl offers no instruction to the user of how to recover …

Aug 7, 2011:

6:20 AM Ticket #197 (BarnOwl sometimes segfaults on $m->delete_and_expunge called from the ...) created by jgross@mit.edu
If you call $m->delete_and_expunge with the object passed to the …

Aug 3, 2011:

7:08 PM Ticket #196 (Tab completion is incorrect after `:set $variable-name `) created by jgross@mit.edu
When you tab after :set $valid-variable-name , you get -q. The …
7:06 PM Ticket #195 (Completion for `:set` should provide appropriate options for bool and ...) created by jgross@mit.edu
Currently, we provide completion for variable names for :set, but …
6:55 PM Changeset [6edc38b] by Jason Gross <jgross@mit.edu>
Complete unstartup command just like startup command
6:49 PM Ticket #194 (Tabbing at the beginning of a command with words after it adds space) created by jgross@mit.edu
If I tab from the middle of a command that is already completed, for …

Aug 1, 2011:

11:28 PM Changeset [0071c88] by David Benjamin <davidben@mit.edu>
Restore correct semantics of message 'time' attribute This rewrites part of 4ebbfbc5360fa004637dd101f5a0c833cdccd60a. We can't replace every instance of ctime with a user-formatted time, as the time attribute is not user-formatted. It is (unfortunately) the API for perl to override the timestamp and owl_perlconfig_hashref2message expects a particular format for strptime. We should not then flip the values around once they reach C. (Especially not a locale-dependent one.) Rename *_to_timestr functions to owl_util_format_* so it is clear the function should only be used for user-formatted times.

Jul 31, 2011:

1:55 AM Changeset [6ddeb17] by GitHub Merge Button <merge-button@github.com>
Merge 3b17b576fd1ea9cad1bfe24591b287425172db9a into 9078f69bca3842103a42b6ff02451b229988753a
1:53 AM Changeset [3b17b57]release-1.9 by David Benjamin <davidben@mit.edu>
Kill owl_function_lastmsg_noredisplay Now that owl_window exists and owl_mainwin_redisplay merely sets a dirty flag, we don't have to care that it only gets called once. It's cheap.

Jul 30, 2011:

3:11 AM Changeset [9078f69]release-1.9 by Geoffrey Thomas <geofft@mit.edu>
Remove ^noc from reply-lockout Given our current user base and how it is no longer primarily people in MIT's Network group, the danger of having legitimate classes starting with "noc" overrides the usefulness of having -c noc itself and affiliated classes in reply-lockout. This leaves reply-lockout with just class ^mail$. Ideally we'd write an Athena-specific customization module... Signed-off-by: Geoffrey Thomas <geofft@mit.edu> Reviewed-by: David Benjamin <davidben@mit.edu>

Jul 25, 2011:

1:39 AM Changeset [42247d8] by GitHub Merge Button <merge-button@github.com>
Merge a74a04441b9bb3d375840a9198cd9c529be66f9f into f271129fbb186598811b923e406d65f9d2b3031a
1:35 AM Changeset [a74a044]release-1.9 by David Benjamin <davidben@mit.edu>
Free the owl_message created for testing It's safe to do so now.
1:35 AM Changeset [b9517cf]release-1.9 by David Benjamin <davidben@mit.edu>
Explicitly store whether an owl_message has a ZNotice_t We should remove it altogether in perlmessages, but in the meantime, we shouldn't be crashing on faked incoming zephyr messages. Also drop the attempted fake ZNotice_t in owl_perlconfig_hashref2message. No one could have relied on it safely today because any such message would crash on delete.

Jul 24, 2011:

9:02 PM Changeset [8c3cae0] by GitHub Merge Button <merge-button@github.com>
Merge f271129fbb186598811b923e406d65f9d2b3031a into 30428a9bdfbc16468abbf043db65d5c4cb37218f
9:01 PM Changeset [f271129]release-1.9 by Jason Gross <jgross@mit.edu>
Fix up headers The additions to owl.h and some of the removals were done by Alejandro Sedeño <asedeno@mit.edu> in commit 77a0258b3919468fc9d7f7602588ac427ab36e6c. Notes: * I think owl.c lost the need for sys/time.h when we punted select() in favor of glib's main loop. * We don't actually need to include things like stdarg.h, stdio.h, glib/gstdio.h, glib-object.h. I think they get indirectly included via owl.h and/or glib.h. They're left in (or added in to) the files that use functions/types from them. * I'm not entirely sure what sys/socket.h is doing in message.c. It is there from the initial commit. I suspect it might have had something to do with the call to getnameinfo. message.c compiles without it, but http://pubs.opengroup.org/onlinepubs/009695399/functions/getnameinfo.html suggests that we're supposed to include it? *shrugs* I'm leaving it in, for now. (Rather, I'll leave one copy of the #include in.)
7:05 PM Changeset [8e755c6]release-1.8 by David Benjamin <davidben@mit.edu>
Fix missing NULL check on anyone list return value Error handling changed in ecffae6c5b3fd57d8ca74cd2ba142098748bfe7c.
7:05 PM Changeset [efef058]release-1.8 by David Benjamin <davidben@mit.edu>
Fix the description of disable-ctrl-d It was backwards. Now it's not. Reported By: William Throwe <wthrowe@mit.edu>
7:05 PM Changeset [30428a9]release-1.9 by David Benjamin <davidben@mit.edu>
Fix missing NULL check on anyone list return value Error handling changed in ecffae6c5b3fd57d8ca74cd2ba142098748bfe7c.
6:57 PM Changeset [40de739]release-1.9 by Jason Gross <jgross@mit.edu>
Fix the description of disable-ctrl-d It was backwards. Now it's not. Reported By: William Throwe <wthrowe@mit.edu>
6:23 PM Changeset [15a7aee] by David Benjamin <davidben@mit.edu>
Fix missing NULL check on anyone list return value Error handling changed in ecffae6c5b3fd57d8ca74cd2ba142098748bfe7c.
5:18 PM Changeset [2994ca2] by GitHub Merge Button <merge-button@github.com>
Merge 1314e4984b5e0326d385bdc2aebb7903f3583f67 into 7abfcf2abcef37025bc4c07654f96ccce56aabe3
3:42 PM Changeset [d98e501]release-1.8 by David Benjamin <davidben@mit.edu>
Workaround color-pairs and broken build on Solaris locker build This reverts commit a71b4e049b7d1a44ddd3f918e67c45e2f8bbef2f. Really should have verified the Solaris build first. Everything is ready for us to not need this change, but the locker build of ncurses needs to be updated. In the meantime, hack around the bug by clamping color pairs. Also revert wbkgrndset because it requires cchar_t. That gets defined on _XOPEN_SOURCE_EXTENDED or _XOPEN_SOURCE>=500. Unfortunately, the check for the latter was added after the locker version, and Solaris is a stickler about flags so _XOPEN_SOURCE>=500 and _XOPEN_SOURCE_EXTENDED conflict. Revert this change when we bundle a newer ncurses.
2:34 PM Changeset [a71b4e0]release-1.8 by David Benjamin <davidben@mit.edu>
Use wbkgrndset instead of wbkgdset in _owl_fmtext_wcolor_set This allows color pairs past 255 in an ext-color-enabled build to work. In theory anyway. Turns out ncurses is buggy and setcchar doesn't work, but when the patch is accepted upstream we can update the ncurses in the locker.
2:32 PM Changeset [7abfcf2]release-1.9 by David Benjamin <davidben@mit.edu>
Use wbkgrndset instead of wbkgdset in _owl_fmtext_wcolor_set This allows color pairs past 255 in an ext-color-enabled build to work. In theory anyway. Turns out ncurses is buggy and setcchar doesn't work, but when the patch is accepted upstream we can update the ncurses in the locker.
2:26 PM Changeset [7e9fa84] by GitHub Merge Button <merge-button@github.com>
Merge 14c15d942910b33590fc67229a029540a97eb9ac into 323412185513364eaef94cf3f6cbb70957d93c5f
10:33 AM Changeset [1314e49] by Jason Gross <jgross@mit.edu>
Fix the description of disable-ctrl-d It was backwards. Now it's not. Reported By: William Throwe <wthrowe@mit.edu>
10:17 AM Ticket #193 (M-q (edit:fill-paragraph) should be better at finding the end of a sentence) created by jgross@mit.edu
As discussed on zephyr, M-q should DTRT on (sentences in …

Jul 23, 2011:

11:30 PM Changeset [96e3221]release-1.8 by David Benjamin <davidben@mit.edu>
Don't spin CPU in AIM connections Embarrasing little bug. We were inheriting the G_IO_OUT from the login code in the branch below and thus waking up from the event loop all the time. Also adjust the comment for G_IO_OUT. It makes it sound like far more of a hack than it really is. Reported-by: Edward Z. Yang <ezyang@mit.edu>
11:28 PM Changeset [39adf06] by GitHub Merge Button <merge-button@github.com>
Merge 323412185513364eaef94cf3f6cbb70957d93c5f into cbc86575b336c399f09c67886f79383681d3e36a
11:28 PM Changeset [3234121]release-1.9 by David Benjamin <davidben@mit.edu>
Don't spin CPU in AIM connections Embarrasing little bug. We were inheriting the G_IO_OUT from the login code in the branch below and thus waking up from the event loop all the time. Also adjust the comment for G_IO_OUT. It makes it sound like far more of a hack than it really is. Reported-by: Edward Z. Yang <ezyang@mit.edu>
9:25 PM Changeset [18fd5685]release-1.8 by David Benjamin <davidben@mit.edu>
Assign all watched signals to a dummy no-op disposition Otherwise some (namely SIGWINCH) may have SIG_DFL = SIG_IGN. This means that the signal is ignored if the signal thread is in the middle of processing another signal (a race condition), and on Solaris it's not delivered at all. Also more consistently consider errors in setup here fatal. And rename CHECK_RESULT to OR_DIE. Reported-by: Benjamin Kaduk <kaduk@mit.edu> Reviewed-by: Adam Glasgall <adam@crossproduct.net>
9:24 PM Changeset [c36f4d0] by GitHub Merge Button <merge-button@github.com>
Merge c40d11a3d527920acd6063b93f1de30d1f668c96 into 4ebbfbc5360fa004637dd101f5a0c833cdccd60a
9:23 PM Changeset [cbc8657]release-1.9 by David Benjamin <davidben@mit.edu>
Don't hardcode regerror buffer size This lets us kill the silly LINE macro. regerror can be called first to get the length, and then the data.
9:23 PM Changeset [287c634]release-1.9 by David Benjamin <davidben@mit.edu>
Don't attempt to switch filters in :view -d if invalid Add return value to owl_function_create_filter and check before switching.
9:23 PM Changeset [e5baf0a]release-1.9 by David Benjamin <davidben@mit.edu>
Remove unused macro We determine the startup file relative to the OWL_CONFIG_DIR now.
8:26 PM Changeset [4ebbfbc]release-1.9 by Jason Gross <jgross@mit.edu>
Show the time zone in :info; replace ctime with strftime This fixes trac-#146. The new function owl_util_time_to_timestr takes a const struct tm * instead of a const time_t because, although we pass around time_t for just about everything else, this lets the caller decide whether to use localtime or gmtime (UTC). Note: I'm not sure that "%c" (which is locale-dependent) will always include the time zone. If not, or if we want a bit more consistency, we can switch to something like "%a %b %d %H:%M:%S %Y %Z" (like "Fri Jul 22 15:39:45 2011 EDT") or "%a %b %d, %Y %h:%M:%S %p %Z" (like "Fri Jul 22, 2011 03:39:45 PM 2011 EDT") or something. On linerva, "%c" seems to be equivalent to "%a %d %b %Y %h:%M:%S %p %Z" (like "Fri 22 Jul 2011 03:39:45 PM EDT").
8:09 PM Changeset [85bb19b] by GitHub Merge Button <merge-button@github.com>
Merge 11e78d5550a8ce2849db8c922b6515bc8d8c2616 into a7fac140d17626bc37808cae6b389f3240135903
7:32 PM Changeset [d933c3ca] by GitHub Merge Button <merge-button@github.com>
Merge a7fac140d17626bc37808cae6b389f3240135903 into f661cee8c04d441ed1b519ade4e831bb8f46b934
7:30 PM Changeset [a7fac14]release-1.9 by David Benjamin <davidben@mit.edu>
Assign all watched signals to a dummy no-op disposition Otherwise some (namely SIGWINCH) may have SIG_DFL = SIG_IGN. This means that the signal is ignored if the signal thread is in the middle of processing another signal (a race condition), and on Solaris it's not delivered at all. Also more consistently consider errors in setup here fatal. And rename CHECK_RESULT to OR_DIE. Reported-by: Benjamin Kaduk <kaduk@mit.edu> Reviewed-by: Adam Glasgall <adam@crossproduct.net>
7:22 PM Changeset [c40d11a] by David Benjamin <davidben@mit.edu>
Don't hardcode regerror buffer size This lets us kill the silly LINE macro. regerror can be called first to get the length, and then the data.
7:22 PM Changeset [83e023e] by David Benjamin <davidben@mit.edu>
Don't attempt to switch filters in :view -d if invalid Add return value to owl_function_create_filter and check before switching.
7:22 PM Changeset [e9a939b] by David Benjamin <davidben@mit.edu>
Remove unused macro We determine the startup file relative to the OWL_CONFIG_DIR now.

Jul 22, 2011:

7:20 PM Changeset [11e78d5] by Jason Gross <jgross@mit.edu>
Show the time zone in :info; replace ctime with strftime This fixes trac-#146. The new function owl_util_time_to_timestr takes a const struct tm * instead of a const time_t because, although we pass around time_t for just about everything else, this lets the caller decide whether to use localtime or gmtime (UTC). Note: I'm not sure that "%c" (which is locale-dependent) will always include the time zone. If not, or if we want a bit more consistency, we can switch to something like "%a %b %d %H:%M:%S %Y %Z" (like "Fri Jul 22 15:39:45 2011 EDT") or "%a %b %d, %Y %h:%M:%S %p %Z" (like "Fri Jul 22, 2011 03:39:45 PM 2011 EDT") or something. On linerva, "%c" seems to be equivalent to "%a %d %b %Y %h:%M:%S %p %Z" (like "Fri 22 Jul 2011 03:39:45 PM EDT").
10:59 AM Ticket #192 (Editwin prompt for jwrite is slightly inaccurate when disable-ctrl-d is off) created by jgross@mit.edu
In C, we use owl_function_write_setup and branch based on …
3:05 AM Ticket #81 (M-q messes with end-of-sentence spacing when period is in quotes) closed by jgross@mit.edu
fixed
3:00 AM Changeset [f661cee]release-1.9 by Jason Gross <jgross@mit.edu>
Treat [!.?]" as end of sentence in edit:fill-paragraph This fixes trac-#81 (M-q messes with end-of-sentence spacing when period is in quotes).
2:56 AM Changeset [092806c] by GitHub Merge Button <merge-button@github.com>
Merge e736dcbe0f115b53809df6d099b183a245c540d8 into 6500907f6e410b9b8ffb57962f97795ebeb0ccd5
2:30 AM Changeset [e736dcb] by Jason Gross <jgross@mit.edu>
Treat [!.?]" as end of sentence in edit:fill-paragraph This fixes trac-#81 (M-q messes with end-of-sentence spacing when period is in quotes).

Jul 21, 2011:

5:12 PM Changeset [6500907]release-1.9 by Jason Gross <jgross@mit.edu>
Correctly display multiline fields in :info Commit 259e60a8abc2d2d41bc7a484b02a334fdd13857f removed the length limit on :info, but kept the replacement of '\n' with '~' and '\r' with '!'. This replacement came with the initial commit, with a comment of "/* just for testing for now */". This commit does away with that replacement, and indents the fields for display purposes. This is particularly useful for messages that have very long fields, such as the original xml field for jabber messages. Trailing newlines (e.g., in formats or in the message body) are doubled, because the code is simpler that way, and because I don't see a compelling reason to strip them.
5:06 PM Changeset [14be3a5]release-1.9 by Jason Gross <jgross@mit.edu>
Give owl_text_indent an indent_first_line parameter This is useful if you need to indent text that isn't broken into chunks that end with newlines. This is primarily in preparation for the next commit, where we need to replace the indent on the first line by a prefix. The other (reasonable) option is to make owl_text_indent always prefix the string it's given with an indent, even when it's given the empty string. This would break the nice property that indent(A + B) = indent(A) + indent(B) whenever A ended with a newline. After some discussion on zephyr and on the github pull request, I decided to go with this option.
2:19 AM Ticket #191 (multiple BarnOwls in AFS should DTRT with respect to logging) closed by davidben@mit.edu
invalid: Closing this so that discussion stays with the zephyr thread from …
1:03 AM Ticket #191 (multiple BarnOwls in AFS should DTRT with respect to logging) created by jgross@mit.edu
If I have multiple BarnOwls running in AFS, all with logging turned …

Jul 20, 2011:

11:12 PM Ticket #10 (barnowl needs a test system) closed by jgross@mit.edu
fixed: We now have a "test system". At least, we have tester.c, t/, and …
11:10 PM Ticket #166 (warning: implicit declaration of function ‘pselect’) closed by jgross@mit.edu
fixed: Fixed by the g_main_loop branch (specifically commit …
4:42 PM Changeset [f60b417] by GitHub Merge Button <merge-button@github.com>
Merge ac919d96a68d7391f70c2a23255449d5f0b686fd into d8f22b65abfc43c50c273302ba9cffe7dc383ed0
4:39 PM Changeset [ac919d96] by Jason Gross <jgross@mit.edu>
Correctly display multiline fields in :info Commit 259e60a8abc2d2d41bc7a484b02a334fdd13857f removed the length limit on :info, but kept the replacement of '\n' with '~' and '\r' with '!'. This replacement came with the initial commit, with a comment of "/* just for testing for now */". This commit does away with that replacement, and indents the fields for display purposes. This is particularly useful for messages that have very long fields, such as the original xml field for jabber messages. Trailing newlines (e.g., in formats or in the message body) are doubled, because the code is simpler that way, and because I don't see a compelling reason to strip them.
4:39 PM Changeset [4d4f0ba] by Jason Gross <jgross@mit.edu>
Give owl_text_indent an indent_first_line parameter This is useful if you need to indent text that isn't broken into chunks that end with newlines.

Jul 19, 2011:

3:51 AM Changeset [aaf8a77]release-1.8 by David Benjamin <davidben@mit.edu>
Don't leak @commands we don't understand That code seriously needs a rewrite. In the meantime, plug a leak.
3:51 AM Changeset [522e03d]release-1.8 by David Benjamin <davidben@mit.edu>
Don't leak realmsg when... what is this I don't even I don't know what in the world this code is doing after the return, but it leaks!
3:51 AM Changeset [25f2e21]release-1.8 by David Benjamin <davidben@mit.edu>
Don't leak filtname when viewing an aim filter twice
3:32 AM Changeset [5787ccc] by GitHub Merge Button <merge-button@github.com>
Merge d8f22b65abfc43c50c273302ba9cffe7dc383ed0 into fa180a3e29ecef2a60831689e626652afe399964
3:30 AM Changeset [d8f22b6]release-1.9 by David Benjamin <davidben@mit.edu>
Don't leak @commands we don't understand That code seriously needs a rewrite. In the meantime, plug a leak.
3:30 AM Changeset [ff7449e]release-1.9 by David Benjamin <davidben@mit.edu>
Don't leak realmsg when... what is this I don't even I don't know what in the world this code is doing after the return, but it leaks!
3:30 AM Changeset [837bd81]release-1.9 by David Benjamin <davidben@mit.edu>
Don't leak filtname when viewing an aim filter twice
3:29 AM Changeset [aec79a1]release-1.8 by David Benjamin <davidben@mit.edu>
Don't stomp over past what owl_text_indent returns Otherwise we may eat some malloc book-keeping structures, experience some slight turbulence, and explode.
3:13 AM Changeset [9ba51c2] by GitHub Merge Button <merge-button@github.com>
Merge fa180a3e29ecef2a60831689e626652afe399964 into 6f7d4f6001eb475eed5eb55eed0ab6e14ee65e00
3:13 AM Changeset [fa180a3]release-1.9 by David Benjamin <davidben@mit.edu>
Don't stomp over past what owl_text_indent returns Otherwise we may eat some malloc book-keeping structures, experience some slight turbulence, and explode.
2:25 AM Changeset [650415e]release-1.8 by David Benjamin <davidben@mit.edu>
Pass initval to owl_variable_dict_newvar_bool as int, not bool While bool is ostensibly cleaner, the rest of the code dealing with bool owl_variables treats it as an int. Switching only this one results in valgrind complaining about conditioning on uninitialized values because we end up casting bool* to int*.
2:16 AM Changeset [778e230] by GitHub Merge Button <merge-button@github.com>
Merge 6f7d4f6001eb475eed5eb55eed0ab6e14ee65e00 into 883502d79716230ee4f4a70d9168bd87c780a7ef
2:00 AM Changeset [6f7d4f6]release-1.9 by David Benjamin <davidben@mit.edu>
Pass initval to owl_variable_dict_newvar_bool as int, not bool While bool is ostensibly cleaner, the rest of the code dealing with bool owl_variables treats it as an int. Switching only this one results in valgrind complaining about conditioning on uninitialized values because we end up casting bool* to int*.

Jul 18, 2011:

10:15 AM Ticket #190 (Warn when AFS tickets close to expiring) created by ezyang@mit.edu
Seems like a pretty reasonable thing to have built in, as opposed to …
10:12 AM Ticket #189 (IRC should say "not connected to any networks" on irc-join rather than ...) created by ezyang@mit.edu
If you ":irc-join" with no networks connected, IRC will ask you to …
Note: See TracTimeline for information about the timeline view.