Timeline
Aug 20, 2017:
- 5:53 PM Changeset [834dc31] by
- Add tweet URL to the "i" popup AFAICT, the info popup just shows the attributes of the perl message object, so we set an otherwise-unused "url" attribute on the message. Sadly, I don't think there's a mechanism for displaying the return value of a method instead.
- 4:38 PM Changeset [1f69b54] by
- Implement Twitter at-reply prefill semantics. Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>
- 4:38 PM Changeset [38c584e] by
- Fix quoting conventions for Twitter commands. Two bugs here: 1. The documentation incorrectly implies that arguments can be omitted, when really the argument parser is much dumber than that. If there are two optional arguments, you can't omit the first one and give the second one; that's ambiguous. 2. There is a codepath for replycmd when status_id is not set (this should be impossible) which passed wrong arguments. Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>
- 4:38 PM Changeset [fb27b30] by
- Give a hint about package provenance. Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>
Aug 16, 2017:
- 12:53 PM Changeset [3f0c209] by
- Add comment about irc logging format
- 12:53 PM Changeset [8f91a70] by
- Add a bit more documentation The function was potentially a bit confusing under code review.
- 12:53 PM Changeset [09f7753] by
- Add back a comment into perl-logging from C
- 12:53 PM Changeset [b807d8f] by
- Improve some documentation of logging variables As per PR #54 review comments.
- 12:53 PM Changeset [3222df2] by
- Replace initial . with _ This is so that, e.g., we won't write to .git, .gitconfig, etc.
- 12:53 PM Changeset [9625c55] by
- Silence "Use of uninitialized value $realm in uc"
- 12:53 PM Changeset [54c5395] by
- Note conflict of loggingdirection and classlogging The description of loggingdirection specifies that it applies to all messages, and thus overrides classlogging. This implements option (2) of trac #242.
- 12:53 PM Changeset [8cec8f7] by
- Log loopbacks to loopback file in ~/zlog Not to ~/zlog/loop{sender,recip}. If compatibility logging is on, loopbacks get logged to ~/zlog/people/loopback, which is what happened before this branch.
- 12:53 PM Changeset [5dee79a] by
- Add log-to-subdirectories, a compatibility frob If disabled (the default), then logging of jabber and AIM messages behaves how it used to. If enabled, then each protocol gets its own subdirectory.
- 12:53 PM Changeset [d2ba33c] by
- Use g_utf8_casefold and g_utf8_normalize We define a convenience function compat_casefold in util.c for reuse in filters.
- 12:53 PM Changeset [47225c9] by
- Update IRC logging to be more idiomatic Based on a message from kini on #oplss at 2013-07-27 12:40: freenode / #oplss / kini 2013-07-27 12:40 (kini!kini@unaffiliated/kini) jgross: the standard format is "[timestamp] <username> message", one line per message freenode / #oplss / kini 2013-07-27 12:41 (kini!kini@unaffiliated/kini) non-message events are usually notated as "* event description", e.g. "* kini (unaffiliated/kini) joined #oplss", or whatever
- 12:53 PM Changeset [6ddfb07] by
- Add a comment about existence of logging dirs
- 12:53 PM Changeset [15b87cc] by
- Remove irc: from irc message filenames
- 12:53 PM Changeset [dce72c1] by
- Log to subfolders of a base path A different subfolder for each protocol.
- 12:53 PM Changeset [9a34040] by
- Add IRC logging filename generation Based on asedeno's comment "For IRC I'd probably want a combination of network and (channel or nick)."
- 12:53 PM Changeset [3374de9] by
- Log different realms to different files
- 12:53 PM Changeset [94b4b99e] by
- Ignore kerberos instances in the sender and recipient when logging This fixes trac-#151 (Handle logging of personal zephyrs from different instances of Kerberos principals sanely). Stripping the instance is only done for the filename, not for the actual log contents.
- 12:53 PM Changeset [03fbf66] by
- Moved the last of the logging-related variables to perl We seem to have picked logpath as the string variable we test in tester.c. Since this is no longer in C, I've replaced it with personalbell (no particular reason for that choice).
- 12:53 PM Changeset [42779f8] by
- Moved logging-specific variables to perl But only the ones that could be moved losslessly, i.e., no special validsettings and not enums.
- 12:53 PM Changeset [4ead7b3] by
- Moved notification of message logging to perl
- 12:53 PM Changeset [5093c6f] by
- Moved the checking of whether or not to log messages to perl
- 12:53 PM Changeset [9bfab40] by
- Moved outgoing zephyr error logging to perl
- 12:53 PM Changeset [ff528e6] by
- Scrapped the last bits of C code dealing with jabber. We still have an OWL_PROTOCOL_JABBER in owl.h, but it does no harm being there, and we don't use any of the other ones except for AIM. I figure there's no harm in waiting and ripping all of them out at the same time in perl/AIM
- 12:53 PM Changeset [eea7bed4] by
- Moved log file name generation to perl I don't think that the class/personal distinction is the best for general protocols, but I don't know what should replace it. I've made class-logging default to only zephyr (a slight change from previous behavior, where jabber MUC's would be logged to $classlogpath, as well as all non-private non-login messages from other protocols), but made logging path generation overridable. TODO: Decide whether or not to filter out more 'bad' characters. Perhaps we should remove '!' because it indicates history in some shells and makes things obnoxious, or '~' becase it indicates homedirs in many shells. * '/' is for separating directories, and we don't want to accidentally make subdirectories We first NFKC for zephyrs, and then apply lc. The zephyr servers apply case-folded NFKC (so says http://zephyr.1ts.org/browser/zephyr/server/zstring.c). We should probably use Unicode::CaseFold instead of lc. I'm also not sure what the order case-adjustment and normalization should be. We first NFKC, then apply lc, to jabbers, as per http://xmpp.org/internet-drafts/attic/draft-ietf-xmpp-nodeprep-03.html (though I can't actually find anything that specifies the case-folding algorithm, nor the ordering). We now use lc instead of g_utf8_strdown to normalize AIM screennames.
- 12:53 PM Changeset [da7341e] by
- Made owl_util_makepath available from perl There's probably a better way to do this. Maybe sub makepath { my $filename = shift; $filename =~ s{ ^ ~ ( [^/]* ) } { $1 ? (getpwnam($1))[7] : ( $ENV{HOME} || $ENV{LOGDIR} || (getpwuid($>))[7] ) }ex; return $filename; } (http://docstore.mik.ua/orelly/perl/cookbook/ch07_04.htm) or something. Additionally, I'm not sure why PREINIT: char *rv = NULL; CODE: { rv = foo(); RETVAL = rv; } OUTPUT: RETVAL CLEANUP: g_free(rv); is the paradigm for functions returning strings, when foo returns `char *` and not `const char *`. I've removed the `= NULL` part of the initlization, which I assume is left over from when we had to NULL-check things before freeing them, but I've copied the rest of the code.
- 12:53 PM Changeset [7f463cf] by
- Moved log generation code to perl.
Note: See TracTimeline
for information about the timeline view.
