Changes between Version 6 and Version 7 of code-review


Ignore:
Timestamp:
May 20, 2013, 1:23:10 PM (8 years ago)
Author:
jgross@mit.edu
Comment:

Note that github pull requests are just as good as email to barnowl-dev, now a days

Legend:

Unmodified
Added
Removed
Modified
  • code-review

    v6 v7  
    3333   attention, decisions or review of non-trivial branches should, in
    3434   general, happen at least largely over email (to
    35    barnowl-dev@mit.edu).
     35   barnowl-dev@mit.edu).  Pull requests made on
     36   github (http://github.com/barnowl/barnowl/pulls) automatically
     37   send email to barnowl-dev@mit.edu, as do comments on the pull
     38   request itself.  (Comments on individual commits, or on specific
     39   lines of a diff, do not result in email notification, and,
     40   furthermore, are lost if the developer updates the pull request.
     41   Therefore, please make all comments on the pull request itself.)
    3642</p></li>
    3743<li><p>
    38  Review requests should include at least one of:</p>
     44 Review requests made by any medium other than github pull requests should include at least one of:</p>
    3945 <ul>
    4046   <li>The location of a git repository containing the changes.</li>
     
    4652 If a review request to the mailing list is not responded to in any
    4753   way within seven days from time of sending, the developer may, at
    48    their option, merge it to master without review. There is no such
     54   their option, merge it to master without review.  As pull requests
     55   on github now send email to the mailing list, this timeout policy
     56   also applies to github pull requests made after May 20, 2013.  There is no such
    4957   timeout for review requests communicated in any other way.
    5058</p></li>