Changes between Version 6 and Version 7 of code-review

Timestamp:

May 20, 2013, 1:23:10 PM (11 years ago)

Author:

jgross@mit.edu

Comment:

Note that github pull requests are just as good as email to barnowl-dev, now a days

code-review

@@ -33 +33 @@
    attention, decisions or review of non-trivial branches should, in
    general, happen at least largely over email (to
-   barnowl-dev@mit.edu).
+   barnowl-dev@mit.edu).  Pull requests made on
+   github (http://github.com/barnowl/barnowl/pulls) automatically
+   send email to barnowl-dev@mit.edu, as do comments on the pull
+   request itself.  (Comments on individual commits, or on specific
+   lines of a diff, do not result in email notification, and,
+   furthermore, are lost if the developer updates the pull request.
+   Therefore, please make all comments on the pull request itself.)
 </p></li>
 <li><p>
- Review requests should include at least one of:</p>
+ Review requests made by any medium other than github pull requests should include at least one of:</p>
  <ul>
    <li>The location of a git repository containing the changes.</li>
@@ -46 +52 @@
  If a review request to the mailing list is not responded to in any
    way within seven days from time of sending, the developer may, at
-   their option, merge it to master without review. There is no such
+   their option, merge it to master without review.  As pull requests
+   on github now send email to the mailing list, this timeout policy
+   also applies to github pull requests made after May 20, 2013.  There is no such
    timeout for review requests communicated in any other way.
 </p></li>