Changes between Version 8 and Version 9 of code-review
- Timestamp:
- Nov 30, 2015, 11:44:15 PM (9 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
code-review
v8 v9 34 34 general, happen at least largely over email (to 35 35 barnowl-dev@mit.edu). Pull requests made on 36 github (http://github.com/barnowl/barnowl/pulls) automatically36 GitHub (http://github.com/barnowl/barnowl/pulls) automatically 37 37 send email to barnowl-dev@mit.edu, as do comments on the pull 38 38 request itself. (Comments on individual commits, or on specific … … 40 40 furthermore, are lost if the developer updates the pull request. 41 41 Therefore, please make all comments on the pull request itself.) 42 Note that github emails show up, at least some of the time,42 Note that GitHub emails show up, at least some of the time, 43 43 as being from notifications@github.com and to 44 44 barnowl@noreply.github.com. 45 45 </p></li> 46 46 <li><p> 47 Review requests made by any medium other than github pull requests should include at least one of:</p>47 Review requests made by any medium other than GitHub pull requests should include at least one of:</p> 48 48 <ul> 49 49 <li>The location of a git repository containing the changes.</li> … … 56 56 way within seven days from time of sending, the developer may, at 57 57 their option, merge it to master without review. As pull requests 58 on github now send email to the mailing list, this timeout policy59 also applies to github pull requests made after May 20, 2013. There is no such58 on GitHub now send email to the mailing list, this timeout policy 59 also applies to GitHub pull requests made after May 20, 2013. There is no such 60 60 timeout for review requests communicated in any other way. 61 61 </p></li>