Changes between Version 8 and Version 9 of code-review


Ignore:
Timestamp:
Nov 30, 2015, 11:44:15 PM (9 years ago)
Author:
jgross@mit.edu
Comment:

capitalize GitHub

Legend:

Unmodified
Added
Removed
Modified
  • code-review

    v8 v9  
    3434   general, happen at least largely over email (to
    3535   barnowl-dev@mit.edu).  Pull requests made on
    36    github (http://github.com/barnowl/barnowl/pulls) automatically
     36   GitHub (http://github.com/barnowl/barnowl/pulls) automatically
    3737   send email to barnowl-dev@mit.edu, as do comments on the pull
    3838   request itself.  (Comments on individual commits, or on specific
     
    4040   furthermore, are lost if the developer updates the pull request.
    4141   Therefore, please make all comments on the pull request itself.)
    42    Note that github emails show up, at least some of the time,
     42   Note that GitHub emails show up, at least some of the time,
    4343   as being from notifications@github.com and to
    4444   barnowl@noreply.github.com.
    4545</p></li>
    4646<li><p>
    47  Review requests made by any medium other than github pull requests should include at least one of:</p>
     47 Review requests made by any medium other than GitHub pull requests should include at least one of:</p>
    4848 <ul>
    4949   <li>The location of a git repository containing the changes.</li>
     
    5656   way within seven days from time of sending, the developer may, at
    5757   their option, merge it to master without review.  As pull requests
    58    on github now send email to the mailing list, this timeout policy
    59    also applies to github pull requests made after May 20, 2013.  There is no such
     58   on GitHub now send email to the mailing list, this timeout policy
     59   also applies to GitHub pull requests made after May 20, 2013.  There is no such
    6060   timeout for review requests communicated in any other way.
    6161</p></li>