Changeset 03ca005 for popexec.c

Timestamp:

Sep 18, 2010, 5:07:39 PM (14 years ago)

Author:

David Benjamin <davidben@mit.edu>

Branches:

master, release-1.10, release-1.7, release-1.8, release-1.9

Children:

61c1f19

Parents:

b3b1b05

git-author:

David Benjamin <davidben@mit.edu> (08/01/10 13:50:19)

git-committer:

David Benjamin <davidben@mit.edu> (09/18/10 17:07:39)

Message:

Create a new owl_popwin every time instead of rewiring the old one

Constantly rewiring things is weird.

File:

• popexec.c (modified) (2 diffs)

popexec.c

@@ -17 +17 @@
   pid_t pid;
 
+  if (owl_global_get_popwin(&g)) {
+    owl_function_error("Popwin already in use.");
+    return NULL;
+  }
+
   pe = owl_malloc(sizeof(owl_popexec));
   if (!pe) return NULL;
@@ -23 +28 @@
   pe->refcount=0;
 
-  pw=owl_global_get_popwin(&g);
   pe->vwin=v=owl_global_get_viewwin(&g);
+  pw = owl_popwin_new();
+  owl_global_set_popwin(&g, pw);
+  owl_popwin_up(pw);
 
-  if (owl_popwin_up(pw) != 0) {
-    owl_function_error("Popwin already in use.");
-    return NULL;
-  }
   owl_global_push_context(&g, OWL_CTX_POPLESS, v, "popless", NULL);
   owl_viewwin_init_text(v, owl_popwin_get_content(pw), "");