Changeset cb54527 for perl/lib/Net/Jabber/Dialback.pm

Timestamp:

Mar 26, 2007, 9:04:54 PM (17 years ago)

Author:

Nelson Elhage <nelhage@mit.edu>

Branches:

master, barnowl_perlaim, debian, release-1.10, release-1.4, release-1.5, release-1.6, release-1.7, release-1.8, release-1.9

Children:

4c2ec6c

Parents:

18a99d2

git-author:

Nelson Elhage <nelhage@mit.edu> (03/26/07 21:04:37)

git-committer:

Nelson Elhage <nelhage@mit.edu> (03/26/07 21:04:54)

Message:

Getting rid of indirect object syntax new calls. Quoting perlobj:

> But what if there are no arguments? In that case, Perl must guess what
> you want. Even worse, it must make that guess *at compile time*. Usually
> Perl gets it right, but when it doesn't you get a function call compiled
> as a method, or vice versa. This can introduce subtle bugs that are hard
> to detect.
> 
> For example, a call to a method "new" in indirect notation -- as C++
> programmers are wont to make -- can be miscompiled into a subroutine
> call if there's already a "new" function in scope. You'd end up calling
> the current package's "new" as a subroutine, rather than the desired
> class's method. The compiler tries to cheat by remembering bareword
> "require"s, but the grief when it messes up just isn't worth the years
> of debugging it will take you to track down such subtle bugs.
    

File:

• perl/lib/Net/Jabber/Dialback.pm (modified) (3 diffs)

perl/lib/Net/Jabber/Dialback.pm

@@ -38 +38 @@
   the XML::Stream hash.  For example:
 
-    my $dialback = new Net::Jabber::Dialback(%hash);
+    my $dialback = Net::Jabber::Dialback->new(%hash);
 
   You now have access to all of the retrieval functions available.
@@ -46 +46 @@
     use Net::Jabber qw(Server);
 
-    $DB = new Net::Jabber::Dialback("verify");
-    $DB = new Net::Jabber::Dialback("result");
+    $DB = Net::Jabber::Dialback->new("verify");
+    $DB = Net::Jabber::Dialback->new("result");
 
   Please see the specific documentation for Net::Jabber::Dialback::Result
@@ -98 +98 @@
         {
             my ($temp) = @_;
-            return new Net::Jabber::Dialback::Result()
+            return Net::Jabber::Dialback::Result->new()
                 if ($temp eq "result");
-            return new Net::Jabber::Dialback::Verify()
+            return Net::Jabber::Dialback::Verify->new()
                 if ($temp eq "verify");
 
             my @temp = @{$temp};
-            return new Net::Jabber::Dialback::Result(@temp)
+            return Net::Jabber::Dialback::Result->new(@temp)
                 if ($temp[0] eq "db:result");
-            return new Net::Jabber::Dialback::Verify(@temp)
+            return Net::Jabber::Dialback::Verify->new(@temp)
                 if ($temp[0] eq "db:verify");
         }