Changeset d427f08 for functions.c

Timestamp:

Jun 22, 2011, 3:40:50 PM (13 years ago)

Author:

Nelson Elhage <nelhage@mit.edu>

Branches:

master, release-1.10, release-1.8, release-1.9

Children:

b343c2c

Parents:

84a071f

git-author:

Jason Gross <jgross@mit.edu> (06/06/11 05:24:30)

git-committer:

Nelson Elhage <nelhage@mit.edu> (06/22/11 15:40:50)

Message:

Use G_GNUC_WARN_UNUSED_RESULT

Have gcc warn us when we ignore the result of a function that requires
the caller to free the result, or an initilization function that can
fail.  This might help (slightly) with preventing leaks and segfaults.

Additionally changed some functions that should never fail to not
return values.  (The owl_list_* functions changed only fail if
list->size < 0, which we assume is not the case elsewhere.)

File:

• functions.c (modified) (19 diffs)

functions.c

@@ -14 +14 @@
 #include "filterproc.h"
 
-char *owl_function_command(const char *cmdbuff)
+G_GNUC_WARN_UNUSED_RESULT char *owl_function_command(const char *cmdbuff)
 {
   owl_function_debugmsg("executing command: %s", cmdbuff);
@@ -21 +21 @@
 }
 
-char *owl_function_command_argv(const char *const *argv, int argc)
+G_GNUC_WARN_UNUSED_RESULT char *owl_function_command_argv(const char *const *argv, int argc)
 {
   return owl_cmddict_execute_argv(owl_global_get_cmddict(&g),
@@ -95 +95 @@
 }
 
-char *owl_function_style_describe(const char *name) {
+G_GNUC_WARN_UNUSED_RESULT char *owl_function_style_describe(const char *name)
+{
   const char *desc;
   char *s;
@@ -111 +112 @@
 }
 
-char *owl_function_cmd_describe(const char *name)
+G_GNUC_WARN_UNUSED_RESULT char *owl_function_cmd_describe(const char *name)
 {
   const owl_cmd *cmd = owl_cmddict_find(owl_global_get_cmddict(&g), name);
@@ -249 +250 @@
  * owl_global_messagequeue_addmsg() for that.
  */
-owl_message *owl_function_make_outgoing_aim(const char *body, const char *to)
+G_GNUC_WARN_UNUSED_RESULT owl_message *owl_function_make_outgoing_aim(const char *body, const char *to)
 {
   owl_message *m;
@@ -270 +271 @@
  * owl_global_messagequeue_addmsg() for that.
  */
-owl_message *owl_function_make_outgoing_loopback(const char *body)
+G_GNUC_WARN_UNUSED_RESULT owl_message *owl_function_make_outgoing_loopback(const char *body)
 {
   owl_message *m;
@@ -1899 +1900 @@
 }
 
-owl_editwin *owl_function_start_question(const char *line)
+G_GNUC_WARN_UNUSED_RESULT owl_editwin *owl_function_start_question(const char *line)
 {
   owl_editwin *tw;
@@ -1914 +1915 @@
 }
 
-owl_editwin *owl_function_start_password(const char *line)
+G_GNUC_WARN_UNUSED_RESULT owl_editwin *owl_function_start_password(const char *line)
 {
   owl_editwin *tw;
@@ -1931 +1932 @@
 }
 
-char *owl_function_exec(int argc, const char *const *argv, const char *buff, int type)
+G_GNUC_WARN_UNUSED_RESULT char *owl_function_exec(int argc, const char *const *argv, const char *buff, int type)
 {
   /* if type == 1 display in a popup
@@ -1974 +1975 @@
 }
 
-char *owl_function_perl(int argc, const char *const *argv, const char *buff, int type)
+G_GNUC_WARN_UNUSED_RESULT char *owl_function_perl(int argc, const char *const *argv, const char *buff, int type)
 {
   /* if type == 1 display in a popup
@@ -2144 +2145 @@
  * Returns the name of the negated filter, which the caller must free.
  */
-char *owl_function_create_negative_filter(const char *filtername)
+G_GNUC_WARN_UNUSED_RESULT char *owl_function_create_negative_filter(const char *filtername)
 {
   char *newname;
@@ -2241 +2242 @@
  * If 'related' is nonzero, encompass unclasses and .d classes as well.
  */
-char *owl_function_classinstfilt(const char *c, const char *i, int related) 
+G_GNUC_WARN_UNUSED_RESULT char *owl_function_classinstfilt(const char *c, const char *i, int related) 
 {
   owl_filter *f;
@@ -2328 +2329 @@
  * the filter, which the caller must free.
  */
-char *owl_function_zuserfilt(const char *longuser)
+G_GNUC_WARN_UNUSED_RESULT char *owl_function_zuserfilt(const char *longuser)
 {
   owl_filter *f;
@@ -2374 +2375 @@
  * Returns the name of the filter, which the caller must free.
  */
-char *owl_function_aimuserfilt(const char *user)
+G_GNUC_WARN_UNUSED_RESULT char *owl_function_aimuserfilt(const char *user)
 {
   owl_filter *f;
@@ -2412 +2413 @@
 }
 
-char *owl_function_typefilt(const char *type)
+G_GNUC_WARN_UNUSED_RESULT char *owl_function_typefilt(const char *type)
 {
   owl_filter *f;
@@ -2468 +2469 @@
 }
 
-static char *owl_function_smartfilter_cc(const owl_message *m) {
+static G_GNUC_WARN_UNUSED_RESULT char *owl_function_smartfilter_cc(const owl_message *m)
+{
   const char *ccs;
   char *ccs_quoted;
@@ -2519 +2521 @@
  *    name to the AIM conversation with that user 
  */
-char *owl_function_smartfilter(int type, int invert_related)
+G_GNUC_WARN_UNUSED_RESULT char *owl_function_smartfilter(int type, int invert_related)
 {
   const owl_view *v;
@@ -2858 +2860 @@
 }
 
-char *owl_function_keymap_summary(const char *name)
+G_GNUC_WARN_UNUSED_RESULT char *owl_function_keymap_summary(const char *name)
 {
   const owl_keymap *km 
@@ -2972 +2974 @@
 /* strips formatting from ztext and returns the unformatted text. 
  * caller is responsible for freeing. */
-char *owl_function_ztext_stylestrip(const char *zt)
+G_GNUC_WARN_UNUSED_RESULT char *owl_function_ztext_stylestrip(const char *zt)
 {
   owl_fmtext fm;