barnowl sometimes crashes with Jabber

[kchen@MIT.EDU]

barnowl sometimes crashes when using Jabber with an error message that mentions something about Process.

I recently turned on debug logging, and so have some possibly more useful info than before, if you don't have such info already.

It looks like it might be related to a Jabber account getting unexpectedly disconnected, although I've certainly been disconnected before without barnowl crashing.

I previously logged into mit.edu, csail.mit.edu, livejournal.com, and gmail.com Jabber accounts. I suspected that the csail.mit.edu account might have been causing the crash, but I've stopped logging into that one, and the problem has continued.

Debug log attached. The error messages continue to repeat for a long time. (Hmm. Perhaps I should be running my barnowl in gdb or allow core files.)

[kchen@MIT.EDU]

It seems that being logged into a livejournal.com Jabber account is likely to cause this bug. I was only logged into mit.edu Jabber for two months (with no problems), and then I logged into livejournal.com jabber about 14 hours ago. At some point within the last hour, the Process text showed up in barnowl, and barnowl started using high amounts of CPU.

One thing that I didn't previously realize was that one of the error messages is actually supposed to say "Jabber account [jid] disconnected!", but the uninitialized value errors are because the jid variable is undefined.

[jgross@mit.edu]

Does this error still occur? The offending line of code was removed with commit a957e9285b443c0e7c978318a7e67324b6085139 (Make Jabber try to reconnect when disconnected, at exponential intervals) (​https://github.com/barnowl/barnowl/commit/a957e9285b443c0e7c978318a7e67324b6085139).

[kchen@mit.edu]

The "Process" error mostly hasn't occurred in a long time, but geofft and I both encountered it recently around the same time. barnowl did not crash this time.

Class: barnowl Instance: personal Time: Wed Nov 3 13:41:48 2010 Host: LINERVA.MIT.EDU From: Geoffrey Thomas <geofft>

I just got about forty thousand of these: OWL ADMIN

Error in callback: 'There was an error in the last call to Process

that you did not check for and

handle. You should always check the output of the Process call.

If it was

undef then there was a fatal error that you need to check. There

is an error

in your program at

/afs/athena.mit.edu/user/g/e/geofft.owl/modules/Jabber/lib/BarnOwl/Module/Jabb er.pm line 150

'

Class: barnowl Instance: personal Time: Wed Nov 3 13:42:01 2010 Host: LINERVA.MIT.EDU From: Geoffrey Thomas <geofft>

OWL ADMIN

There was an error in the last call to Process that you did not check for an

d

handle. You should always check the output of the Process call. If it was undef then there was a fatal error that you need to check. There is an erro

r

in your program at -e line 0

Class: barnowl Instance: personal Time: Wed Nov 3 13:43:09 2010 Host: DARKMATTER.MIT.EDU From: Pending regulatory approval. <asedeno>

It's been so long since I've heard about that bug being tickled, I thought it was gone.

Class: barnowl Instance: personal Time: Wed Nov 3 13:43:20 2010 Host: LINERVA.MIT.EDU From: Geoffrey Thomas <geofft>

(punted the messages and then punted my zephyrs too) :jabberlogout ​geofft@mit.edu fixed it, but I was getting a thousand every keystroke or so until I hit enter.

Class: barnowl Instance: personal Time: Wed Nov 3 13:49:18 2010 Host: LINERVA.MIT.EDU From: Scoot Chain Thru <kchen>

Me too just now.

Class: barnowl Instance: personal Time: Wed Nov 3 13:49:25 2010 Host: LINERVA.MIT.EDU From: Fan The Top <kchen>

Although not until after Geoff's zephyrs.

Class: barnowl Instance: personal Time: Wed Nov 3 13:50:57 2010 Host: LINERVA.MIT.EDU From: Grand Swing Thru <kchen>

It appeared that jabberlogout ​kchen@mit.edu was insufficient to fix it, and I had to log out of at least one of my other accounts to. (I normally login to 3 of them. After logging out of MIT, I went ahead and logged out of both of the others, since I was just interested in getting rid of the messages asap.)

Class: barnowl Instance: personal Time: Wed Nov 3 13:54:06 2010 Host: DARKMATTER.MIT.EDU From: Pending regulatory approval. <asedeno>

If anyone figures out how to reproduce this, I will spend some time hunting it down.

[kchen@mit.edu]

Reproducible test case:

As paco: :jabberlogin ​paco@mit.edu :jabberlogin ​sipb0@mit.edu

(Alternatively, :jabberlogin ​sipb0@mit.edu followed by :jabberlogin ​sipb0@mit.edu works, because the first jabberlogin ​sipb0@mit.edu currently logs in as paco anyway.)