Changeset 0504f63 for filterelement.c

Timestamp:

Aug 10, 2008, 5:38:44 PM (16 years ago)

Author:

Nelson Elhage <nelhage@mit.edu>

Branches:

master, debian, release-1.10, release-1.4, release-1.5, release-1.6, release-1.7, release-1.8, release-1.9

Children:

e9bb404

Parents:

d81f8d0

Message:

Rewrite owl_filter_print to use GString.

barnowl will no longer segfault on `show filter' with filters over
5000 characters or so.

File:

• filterelement.c (modified) (2 diffs)

filterelement.c

@@ -126 +126 @@
 /* Print methods */
 
-static void owl_filterelement_print_true(owl_filterelement *fe, char *buf)
-{
-  strcat(buf, "true");
-}
-
-static void owl_filterelement_print_false(owl_filterelement *fe, char *buf)
-{
-  strcat(buf, "false");
-}
-
-static void owl_filterelement_print_re(owl_filterelement *fe, char *buf)
+static void owl_filterelement_print_true(owl_filterelement *fe, GString *buf)
+{
+  g_string_append(buf, "true");
+}
+
+static void owl_filterelement_print_false(owl_filterelement *fe, GString *buf)
+{
+  g_string_append(buf, "false");
+}
+
+static void owl_filterelement_print_re(owl_filterelement *fe, GString *buf)
 {
   char *re, *q;
-  strcat(buf, fe->field);
-  strcat(buf, " ");
+  g_string_append(buf, fe->field);
+  g_string_append(buf, " ");
 
   re = owl_regex_get_string(&(fe->re));
   q = owl_getquoting(re);
-  strcat(buf, q);
-  strcat(buf, re); 
-  strcat(buf, q);
-}
-
-static void owl_filterelement_print_filter(owl_filterelement *fe, char *buf)
-{
-  strcat(buf, "filter ");
-  strcat(buf, fe->field);
-}
-
-static void owl_filterelement_print_perl(owl_filterelement *fe, char *buf)
-{
-  strcat(buf, "perl ");
-  strcat(buf, fe->field);
-}
-
-static void owl_filterelement_print_group(owl_filterelement *fe, char *buf)
-{
-  strcat(buf, "( ");
+  g_string_append(buf, q);
+  g_string_append(buf, re);
+  g_string_append(buf, q);
+}
+
+static void owl_filterelement_print_filter(owl_filterelement *fe, GString *buf)
+{
+  g_string_append(buf, "filter ");
+  g_string_append(buf, fe->field);
+}
+
+static void owl_filterelement_print_perl(owl_filterelement *fe, GString *buf)
+{
+  g_string_append(buf, "perl ");
+  g_string_append(buf, fe->field);
+}
+
+static void owl_filterelement_print_group(owl_filterelement *fe, GString *buf)
+{
+  g_string_append(buf, "( ");
   owl_filterelement_print(fe->left, buf) ;
-  strcat(buf, " )");
-}
-
-static void owl_filterelement_print_or(owl_filterelement *fe, char *buf)
+  g_string_append(buf, " )");
+}
+
+static void owl_filterelement_print_or(owl_filterelement *fe, GString *buf)
 {
   owl_filterelement_print(fe->left, buf);
-  strcat(buf, " or ");
+  g_string_append(buf, " or ");
   owl_filterelement_print(fe->right, buf);
 }
 
-static void owl_filterelement_print_and(owl_filterelement *fe, char *buf)
+static void owl_filterelement_print_and(owl_filterelement *fe, GString *buf)
 {
   owl_filterelement_print(fe->left, buf);
-  strcat(buf, " and ");
+  g_string_append(buf, " and ");
   owl_filterelement_print(fe->right, buf);
 }
 
-static void owl_filterelement_print_not(owl_filterelement *fe, char *buf)
-{
-  strcat(buf, " not ");
+static void owl_filterelement_print_not(owl_filterelement *fe, GString *buf)
+{
+  g_string_append(buf, " not ");
   owl_filterelement_print(fe->left, buf);
 }
@@ -321 +321 @@
 }
 
-void owl_filterelement_print(owl_filterelement *fe, char *buf)
+void owl_filterelement_print(owl_filterelement *fe, GString *buf)
 {
   if(!fe || !fe->print_elt) return;