Changeset 3234121 for aim.c


Ignore:
Timestamp:
Jul 23, 2011, 11:28:14 PM (10 years ago)
Author:
David Benjamin <davidben@mit.edu>
Branches:
master, release-1.9
Children:
1314e49, 7abfcf2, 7e9fa84, 39adf06
Parents:
cbc8657
git-author:
David Benjamin <davidben@mit.edu> (07/23/11 23:22:47)
git-committer:
David Benjamin <davidben@mit.edu> (07/23/11 23:28:14)
Message:
Don't spin CPU in AIM connections

Embarrasing little bug. We were inheriting the G_IO_OUT from the login
code in the branch below and thus waking up from the event loop all the
time.

Also adjust the comment for G_IO_OUT. It makes it sound like far more of
a hack than it really is.

Reported-by: Edward Z. Yang <ezyang@mit.edu>
File:
1 edited

Legend:

Unmodified
Added
Removed
  • aim.c

    rff7449e r3234121  
    18291829      fd = event_source->fds->pdata[i];
    18301830      fd->fd = cur->fd;
    1831       fd->events |= G_IO_IN | G_IO_HUP | G_IO_ERR;
     1831      fd->events = G_IO_IN | G_IO_HUP | G_IO_ERR;
    18321832      if (cur->status & AIM_CONN_STATUS_INPROGRESS) {
    1833         /* Yes, we're checking writable sockets here. Without it, AIM
    1834            login is really slow. */
     1833        /* AIM login requires checking writable sockets. See aim_select. */
    18351834        fd->events |= G_IO_OUT;
    18361835      }
Note: See TracChangeset for help on using the changeset viewer.