Changeset 3234121 for aim.c

Timestamp:

Jul 23, 2011, 11:28:14 PM (13 years ago)

Author:

David Benjamin <davidben@mit.edu>

Branches:

master, release-1.10, release-1.9

Children:

1314e49, 7abfcf2, 7e9fa84, 39adf06

Parents:

cbc8657

git-author:

David Benjamin <davidben@mit.edu> (07/23/11 23:22:47)

git-committer:

David Benjamin <davidben@mit.edu> (07/23/11 23:28:14)

Message:

Don't spin CPU in AIM connections

Embarrasing little bug. We were inheriting the G_IO_OUT from the login
code in the branch below and thus waking up from the event loop all the
time.

Also adjust the comment for G_IO_OUT. It makes it sound like far more of
a hack than it really is.

Reported-by: Edward Z. Yang <ezyang@mit.edu>

File:

• aim.c (modified) (1 diff)

aim.c

@@ -1829 +1829 @@
       fd = event_source->fds->pdata[i];
       fd->fd = cur->fd;
-      fd->events |= G_IO_IN | G_IO_HUP | G_IO_ERR;
+      fd->events = G_IO_IN | G_IO_HUP | G_IO_ERR;
       if (cur->status & AIM_CONN_STATUS_INPROGRESS) {
-        /* Yes, we're checking writable sockets here. Without it, AIM
-           login is really slow. */
+        /* AIM login requires checking writable sockets. See aim_select. */
         fd->events |= G_IO_OUT;
       }