Changeset 4953c44 for t/variable.t

Timestamp:

Feb 23, 2013, 5:44:23 PM (11 years ago)

Author:

David Benjamin <davidben@mit.edu>

Branches:

master, release-1.10

Children:

6a8b519

Parents:

4419d3d

git-author:

David Benjamin <davidben@mit.edu> (02/22/13 14:12:23)

git-committer:

David Benjamin <davidben@mit.edu> (02/23/13 17:44:23)

Message:

Change set_fromstring to die on failure

Returning zero/non-zero is awkward. Leave a note for future improvement
to pass the error message along, although the default one is pretty
reasonable already.

File:

• t/variable.t (modified) (1 diff)

t/variable.t

@@ -62 +62 @@
     get_tostring => sub { "value is " . $value },
     set_fromstring => sub {
-        return -1 unless $_[0] =~ /^...?$/;
+        die "Too long" unless $_[0] =~ /^...?$/;
         $value = $_[0];
-        return 0;
     },
     takes_on_off => 1