Changeset 4c0ac34

Timestamp:

Oct 23, 2010, 4:40:24 AM (14 years ago)

Author:

David Benjamin <davidben@mit.edu>

Branches:

master, release-1.10, release-1.7, release-1.8, release-1.9

Children:

7d7326c

Parents:

c366cbd

Message:

Don't leak editwins in the viewwin

All the objects we pass the editwin to take a reference, but no one
ever claims the reference it was initially created with.

File:

• viewwin.c (modified) (2 diffs)

viewwin.c

@@ -217 +217 @@
   owl_editwin_set_callback(tw, owl_viewwin_callback_search);
   owl_editwin_set_cbdata(tw, data, owl_free);
+  /* We aren't saving tw, so release the reference we were given. */
+  owl_editwin_unref(tw);
   return NULL;
 }
@@ -236 +238 @@
   owl_global_push_context_obj(&g, ctx);
   owl_editwin_set_callback(tw, owl_callback_command);
+  /* We aren't saving tw, so release the reference we were given. */
+  owl_editwin_unref(tw);
 
   return NULL;