Changeset 9cb03bf for perlglue.xs

Timestamp:

Sep 28, 2009, 4:37:13 PM (15 years ago)

Author:

Anders Kaseorg <andersk@mit.edu>

Branches:

master, release-1.10, release-1.4, release-1.5, release-1.6, release-1.7, release-1.8, release-1.9

Children:

fbadb37

Parents:

39cff48

Message:

get_zephyr_variable: Clean up const and NULL handling.

g_strdup and g_free already do the right thing with NULL, so we don’t
need extra logic here.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>

File:

• perlglue.xs (modified) (1 diff)

perlglue.xs

@@ -418 +418 @@
 char *
 get_zephyr_variable(name)
-        char *name;
+        const char *name;
         PREINIT:
                 char *result;
         CODE:
-                result = (char *)owl_zephyr_get_variable(name);
-                result = result ? owl_strdup(result) : result;
+                result = owl_strdup(owl_zephyr_get_variable(name));
                 RETVAL = result;
         OUTPUT:
                 RETVAL
         CLEANUP:
-                if(result)
-                        owl_free(result);
+                owl_free(result);
 
 MODULE = BarnOwl                PACKAGE = BarnOwl::Internal