Changeset b9cb41b for zwrite.c

Timestamp:

Dec 6, 2008, 11:25:33 PM (16 years ago)

Author:

Anders Kaseorg <andersk@mit.edu>

Branches:

master, debian, release-1.10, release-1.4, release-1.5, release-1.6, release-1.7, release-1.8, release-1.9

Children:

56d0189

Parents:

49a8434

git-author:

Anders Kaseorg <andersk@mit.edu> (12/06/08 23:20:19)

git-committer:

Anders Kaseorg <andersk@mit.edu> (12/06/08 23:25:33)

Message:

Replace questionable sprintf(buf, "%s...", buf, ...) pattern, which is
broken by -D_FORTIFY_SOURCE.

perl -pe 's/(sprintf\s*\(\s*([^,]*))(\s*,\s*")%s([^"]*"\s*,)\s*\2\s*,/\1 + strlen(\2)\3\4/g'

File:

• zwrite.c (modified) (1 diff)

zwrite.c

@@ -231 +231 @@
     for (i=0; i<j; i++) {
       if (strcmp(z->realm, "")) {
-        sprintf(toline, "%s%s@%s ", toline, (char *) owl_list_get_element(&(z->recips), i), z->realm);
+        sprintf(toline + strlen(toline), "%s@%s ", (char *) owl_list_get_element(&(z->recips), i), z->realm);
       } else {
-        sprintf(toline, "%s%s ", toline, (char *) owl_list_get_element(&(z->recips), i));
+        sprintf(toline + strlen(toline), "%s ", (char *) owl_list_get_element(&(z->recips), i));
       }
     }