Changeset ba7ac0d for perl/modules/Twitter/lib/BarnOwl/Message/Twitter.pm

Timestamp:

Aug 9, 2014, 5:30:05 PM (10 years ago)

Author:

Edward Z. Yang <ezyang@cs.stanford.edu>

Children:

8de7c84

Parents:

ea23e6d

git-author:

Edward Z. Yang <ezyang@cs.stanford.edu> (03/22/14 02:17:36)

git-committer:

Edward Z. Yang <ezyang@cs.stanford.edu> (08/09/14 17:30:05)

Message:

Fix quoting conventions for Twitter commands.

Two bugs here:

1. The documentation incorrectly implies that arguments can be
omitted, when really the argument parser is much dumber than that.
If there are two optional arguments, you can't omit the first one
and give the second one; that's ambiguous.

2. There is a codepath for replycmd when status_id is not set
(this should be impossible) which passed wrong arguments.

Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>

File:

• perl/modules/Twitter/lib/BarnOwl/Message/Twitter.pm (modified) (1 diff)

perl/modules/Twitter/lib/BarnOwl/Message/Twitter.pm

@@ -36 +36 @@
         return BarnOwl::quote('twitter-atreply', $self->sender, $self->{status_id}, $self->account);
     } else {
-        return BarnOwl::quote('twitter-atreply', $self->sender, $self->account);
+        # Give a dummy status ID
+        return BarnOwl::quote('twitter-atreply', $self->sender, '', $self->account);
     }
 }