Changeset bdbec0a for perlglue.xs

Timestamp:

Oct 23, 2009, 3:49:11 PM (14 years ago)

Author:

Karl Ramm <kcr@1ts.org>

Branches:

master, release-1.10, release-1.5, release-1.6, release-1.7, release-1.8, release-1.9

Children:

b644688

Parents:

fb7742c

git-author:

Karl Ramm <kcr@1ts.org> (09/25/09 11:18:41)

git-committer:

Karl Ramm <kcr@1ts.org> (10/23/09 15:49:11)

Message:

refactor and clean owl editwin startup functions

Take function.c:owl_function_{z,aim}write_setup and perlglue.xs:start_edit_win,
and collide at .8c producing owl_function_write_setup which calls
owl_function_start_edit_win.

(Also ditching another three fugly char[1024]s)

Really, this ought to be in perl.

File:

• perlglue.xs (modified) (2 diffs)

perlglue.xs

@@ -203 +203 @@
         const char *line
         SV *callback
-        PREINIT:
-                owl_editwin * e;
-                char buff[1024];
         CODE:
         {
@@ -211 +208 @@
                         croak("Callback must be a subref");
 
-                e = owl_global_get_typwin(&g);
-                owl_editwin_new_style(e, OWL_EDITWIN_STYLE_MULTILINE,
-                                      owl_global_get_msg_history(&g));
-                owl_editwin_clear(e);
-                owl_editwin_set_dotsend(e);
-                snprintf(buff, 1023, "----> %s\n", line);
-                owl_editwin_set_locktext(e, buff);
-
-                owl_global_set_typwin_active(&g);
-
-                owl_editwin_set_cbdata(owl_global_get_typwin(&g), SvREFCNT_inc(callback));
-                owl_editwin_set_callback(owl_global_get_typwin(&g), owl_perlconfig_edit_callback);
+                owl_function_start_edit_win(line, owl_perlconfig_edit_callback, SvREFCNT_inc(callback));
         }