Changeset c394de8 for commands.c

Timestamp:

Sep 18, 2010, 5:07:40 PM (14 years ago)

Author:

David Benjamin <davidben@mit.edu>

Branches:

master, release-1.10, release-1.7, release-1.8, release-1.9

Children:

fc5eef4

Parents:

9190285

git-author:

David Benjamin <davidben@mit.edu> (08/14/10 01:15:47)

git-committer:

David Benjamin <davidben@mit.edu> (09/18/10 17:07:40)

Message:

Use ref-counting to make editwin ownership saner

When creating an editwin, one creates an editcontext which takes a
reference to the editwin. Likewise, the pointer in owl_global holds
reference. The reference counting manages their ownership claims. In
addition, owl_global_set_typwin_inactive now does release a reference.

Instead, the callback-calling commands take a reference and release it
later. We may wish to further improve that so that the contexts are also
ref-counted such that, when their commands are running, they will not be
deallocated, even if popped. That will avoid the callback dance.

File:

• commands.c (modified) (2 diffs)

commands.c

@@ -2693 +2693 @@
 
   owl_global_set_typwin_inactive(&g);
-  owl_editwin_unref(e);
 }
 
@@ -2746 +2745 @@
   }
 
+  /* Take a reference to the editwin, so that it survives the pop
+   * context. TODO: We should perhaps refcount or otherwise protect
+   * the context so that, even if a command pops a context, the
+   * context itself will last until the command returns. */
+  owl_editwin_ref(e);
   owl_global_set_typwin_inactive(&g);
   owl_global_pop_context(&g);