Changeset c394de8 for global.c

Timestamp:

Sep 18, 2010, 5:07:40 PM (14 years ago)

Author:

David Benjamin <davidben@mit.edu>

Branches:

master, release-1.10, release-1.7, release-1.8, release-1.9

Children:

fc5eef4

Parents:

9190285

git-author:

David Benjamin <davidben@mit.edu> (08/14/10 01:15:47)

git-committer:

David Benjamin <davidben@mit.edu> (09/18/10 17:07:40)

Message:

Use ref-counting to make editwin ownership saner

When creating an editwin, one creates an editcontext which takes a
reference to the editwin. Likewise, the pointer in owl_global holds
reference. The reference counting manages their ownership claims. In
addition, owl_global_set_typwin_inactive now does release a reference.

Instead, the callback-calling commands take a reference and release it
later. We may wish to further improve that so that the contexts are also
ref-counted such that, when their commands are running, they will not be
deallocated, even if popped. That will avoid the callback dance.

File:

• global.c (modified) (2 diffs)

global.c

@@ -285 +285 @@
 owl_editwin *owl_global_current_typwin(const owl_global *g) {
   owl_context *ctx = owl_global_get_context(g);
-  /* Get the current editwin from the context. */
-  if (ctx && owl_context_matches(ctx, OWL_CTX_TYPWIN)) {
-    return owl_context_get_data(ctx);
-  }
-  return NULL;
+  return owl_editcontext_get_editwin(ctx);
 }
 
@@ -347 +343 @@
   owl_window_dirty(g->mainpanel.typwin);
 
+  owl_editwin_unref(g->tw);
   g->tw = NULL;
 }