Changeset c681337 for perlwrap.pm

Timestamp:

Jan 9, 2007, 3:00:36 PM (18 years ago)

Author:

Nelson Elhage <nelhage@mit.edu>

Branches:

master, barnowl_perlaim, debian, release-1.10, release-1.4, release-1.5, release-1.6, release-1.7, release-1.8, release-1.9

Children:

3354cea5

Parents:

c0987a8

git-author:

Nelson Elhage <nelhage@mit.edu> (01/09/07 14:59:20)

git-committer:

Nelson Elhage <nelhage@mit.edu> (01/09/07 15:00:36)

Message:

The lack of strict and warnings was making me sad.

File:

• perlwrap.pm (modified) (10 diffs)

perlwrap.pm

@@ -6 +6 @@
 #####################################################################
 
+use strict;
+use warnings;
+
 package owl;
 
@@ -17 +20 @@
 use lib($::ENV{'HOME'}."/.owl/lib");
 
-
 our $configfile;
 
@@ -38 +40 @@
 # make owl::<command>("foo") be aliases to owl::command("<command> foo");
 sub AUTOLOAD {
+    our $AUTOLOAD;
     my $called = $AUTOLOAD;
     $called =~ s/.*:://;
@@ -66 +69 @@
     );
 
+    no warnings 'uninitialized';
     owl::new_command_internal($name, $func, $args{summary}, $args{usage}, $args{description});
 }
@@ -198 +202 @@
 package owl::Message::Admin;
 
-@ISA = qw( owl::Message );
+use base qw( owl::Message );
 
 sub header       { return shift->{"header"}; }
@@ -207 +211 @@
 package owl::Message::Generic;
 
-@ISA = qw( owl::Message );
+use base qw( owl::Message );
 
 #####################################################################
@@ -214 +218 @@
 package owl::Message::AIM;
 
-@ISA = qw( owl::Message );
+use base qw( owl::Message );
 
 # all non-loginout AIM messages are personal for now...
@@ -226 +230 @@
 package owl::Message::Zephyr;
 
-@ISA = qw( owl::Message );
+use base qw( owl::Message );
 
 sub login_tty { 
@@ -241 +245 @@
 
 sub zwriteline  { return shift->{"zwriteline"}; }
-
-sub zsig        { return shift->{"zsig"}; }
 
 sub is_ping     { return (lc(shift->opcode) eq "ping"); }
@@ -438 +440 @@
 package main;
 # alias the hooks
-foreach my $hook  qw (onStartSubs
-onReceiveMsg
-onMainLoop
-onGetBuddyList ) {
-  *{"main::".$hook} = \*{"owl::".$hook};
+{
+    no strict 'refs';
+    foreach my $hook  qw (onStartSubs
+                          onReceiveMsg
+                          onMainLoop
+                          onGetBuddyList ) {
+        *{"main::".$hook} = \*{"owl::".$hook};
+    }
 }