Changeset d222c44 for filterelement.c

Timestamp:

Jan 2, 2011, 3:35:15 PM (13 years ago)

Author:

David Benjamin <davidben@mit.edu>

Branches:

master, release-1.10, release-1.8, release-1.9

Children:

719119de

Parents:

2bc6ad35

git-author:

David Benjamin <davidben@mit.edu> (12/14/10 23:53:38)

git-committer:

David Benjamin <davidben@mit.edu> (01/02/11 15:35:15)

Message:

Kill owl_getquoting and fix quoting bugs

That function is nonsense. Fix a number of quoting bugs relating to its
use (and lack thereof).

Also quote regex characters in CC narrows.

File:

• filterelement.c (modified) (3 diffs)

filterelement.c

@@ -139 +139 @@
 static void owl_filterelement_print_re(const owl_filterelement *fe, GString *buf)
 {
-  const char *re, *q;
+  const char *re;
   g_string_append(buf, fe->field);
   g_string_append(buf, " ");
 
   re = owl_regex_get_string(&(fe->re));
-  q = owl_getquoting(re);
-  g_string_append(buf, q);
-  g_string_append(buf, re);
-  g_string_append(buf, q);
+  owl_string_append_quoted_arg(buf, re);
 }
 
@@ -153 +150 @@
 {
   g_string_append(buf, "filter ");
-  g_string_append(buf, fe->field);
+  owl_string_append_quoted_arg(buf, fe->field);
 }
 
@@ -159 +156 @@
 {
   g_string_append(buf, "perl ");
-  g_string_append(buf, fe->field);
+  owl_string_append_quoted_arg(buf, fe->field);
 }