Changeset d427f08 for zwrite.c

Timestamp:

Jun 22, 2011, 3:40:50 PM (13 years ago)

Author:

Nelson Elhage <nelhage@mit.edu>

Branches:

master, release-1.10, release-1.8, release-1.9

Children:

b343c2c

Parents:

84a071f

git-author:

Jason Gross <jgross@mit.edu> (06/06/11 05:24:30)

git-committer:

Nelson Elhage <nelhage@mit.edu> (06/22/11 15:40:50)

Message:

Use G_GNUC_WARN_UNUSED_RESULT

Have gcc warn us when we ignore the result of a function that requires
the caller to free the result, or an initilization function that can
fail.  This might help (slightly) with preventing leaks and segfaults.

Additionally changed some functions that should never fail to not
return values.  (The owl_list_* functions changed only fail if
list->size < 0, which we assume is not the case elsewhere.)

File:

• zwrite.c (modified) (4 diffs)

zwrite.c

@@ -5 +5 @@
 #include "owl.h"
 
-owl_zwrite *owl_zwrite_new(const char *line)
+G_GNUC_WARN_UNUSED_RESULT owl_zwrite *owl_zwrite_new(const char *line)
 {
   owl_zwrite *z = g_new(owl_zwrite, 1);
@@ -15 +15 @@
 }
 
-int owl_zwrite_create_from_line(owl_zwrite *z, const char *line)
+G_GNUC_WARN_UNUSED_RESULT int owl_zwrite_create_from_line(owl_zwrite *z, const char *line)
 {
   int argc, badargs, myargc;
@@ -321 +321 @@
 
 /* Caller must free the result. */
-char *owl_zwrite_get_recip_n_with_realm(const owl_zwrite *z, int n)
+G_GNUC_WARN_UNUSED_RESULT char *owl_zwrite_get_recip_n_with_realm(const owl_zwrite *z, int n)
 {
   if (z->realm[0]) {
@@ -370 +370 @@
  * If not a CC, only the recip_index'th user will be replied to.
  */
-char *owl_zwrite_get_replyline(const owl_zwrite *z, int recip_index)
+G_GNUC_WARN_UNUSED_RESULT char *owl_zwrite_get_replyline(const owl_zwrite *z, int recip_index)
 {
   /* Match ordering in zwrite help. */