Changeset e47e1b0 for logging.c

Timestamp:

Aug 5, 2017, 11:21:53 PM (7 years ago)

Author:

Jason Gross <jasongross9@gmail.com>

Branches:

master

Children:

ec36247

Parents:

8eb72d2

git-author:

Jason Gross <jgross@mit.edu> (05/26/13 12:40:04)

git-committer:

Jason Gross <jasongross9@gmail.com> (08/05/17 23:21:53)

Message:

Display log file name on failure to open file

Also, make owl_log_error be like printf.  This will be more useful in
the next commit, when we display error codes.

File:

• logging.c (modified) (2 diffs)

logging.c

@@ -151 +151 @@
 }
 
-static void owl_log_error(const char *message)
-{
-  char *data = g_strdup(message);
+static void G_GNUC_PRINTF(1, 2) owl_log_error(const char *fmt, ...)
+{
+  va_list ap;
+  char *data;
+
+  va_start(ap, fmt);
+  data = g_strdup_vprintf(fmt, ap);
+  va_end(ap);
+
   owl_select_post_task(owl_log_error_main_thread,
-                       data, g_free, g_main_context_default());
+                       data, g_free, g_main_context_default());
 }
 
@@ -164 +170 @@
   file = fopen(msg->filename, "a");
   if (!file) {
-    owl_log_error("Unable to open file for logging");
+    owl_log_error("Unable to open file for logging (%s)", msg->filename);
     return;
   }